From b34984d44c9a729b023ec37e43a359f62ce7dadb Mon Sep 17 00:00:00 2001 From: Andrei Stoian <95410270+andrei-stoian-zama@users.noreply.github.com> Date: Wed, 15 Dec 2021 11:04:30 +0100 Subject: [PATCH] fix: benchmarks for regression (#1188) Wrong variable names for measures in linear regression and missing one in logistic Closes #1187 --- benchmarks/linear_regression.py | 6 +++--- benchmarks/logistic_regression.py | 1 + script/progress_tracker_utils/measure.py | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/benchmarks/linear_regression.py b/benchmarks/linear_regression.py index e5dc084db..b57675b5b 100644 --- a/benchmarks/linear_regression.py +++ b/benchmarks/linear_regression.py @@ -169,10 +169,10 @@ def main(): print(f"Homomorphic R^2: {homomorphic_test_error:.4f}") print(f"Relative Difference Percentage: {difference:.2f}%") - # bench: Measure: Non Homomorphic Loss = non_homomorphic_loss - # bench: Measure: Homomorphic Loss = homomorphic_loss + # bench: Measure: Sklearn R^2 = sklearn_r2 + # bench: Measure: Non Homomorphic R^2 = non_homomorphic_test_error + # bench: Measure: Homomorphic R^2 = homomorphic_test_error # bench: Measure: Relative Loss Difference (%) = difference - # bench: Measure: Homomorphic Test Error = homomorphic_test_error # bench: Alert: Relative Loss Difference (%) > 7.5 diff --git a/benchmarks/logistic_regression.py b/benchmarks/logistic_regression.py index 5f5faa3a7..18ef7ca43 100644 --- a/benchmarks/logistic_regression.py +++ b/benchmarks/logistic_regression.py @@ -210,6 +210,7 @@ def main(): print(f"Homomorphic Accuracy: {homomorphic_accuracy:.4f}") print(f"Difference Percentage: {difference:.2f}%") + # bench: Measure: Sklearn accuracy = sklearn_acc # bench: Measure: Non Homomorphic Accuracy = non_homomorphic_accuracy # bench: Measure: Homomorphic Accuracy = homomorphic_accuracy # bench: Measure: Accuracy Difference Between Homomorphic and Non Homomorphic Implementation (%) = difference diff --git a/script/progress_tracker_utils/measure.py b/script/progress_tracker_utils/measure.py index 1991c2a6d..9fbb50050 100644 --- a/script/progress_tracker_utils/measure.py +++ b/script/progress_tracker_utils/measure.py @@ -28,6 +28,7 @@ def name_to_id(name): name = name.replace("]", "") name = name.replace(",", "") name = name.replace(".", "-") + name = name.replace("^", "") return urllib.parse.quote_plus(name.lower())