From b729bbd476ebb41d7aeeb08603c5c2f862250193 Mon Sep 17 00:00:00 2001
From: "Mayeul@Zama" <mayeul.debellabre@zama.ai>
Date: Tue, 5 Apr 2022 17:50:30 +0200
Subject: [PATCH] fix clippy warnings

---
 src/noise_estimator/operators/atomic_pattern.rs | 8 ++++----
 src/security/glwe.rs                            | 9 +++++----
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/noise_estimator/operators/atomic_pattern.rs b/src/noise_estimator/operators/atomic_pattern.rs
index 592490a34..648d379dd 100644
--- a/src/noise_estimator/operators/atomic_pattern.rs
+++ b/src/noise_estimator/operators/atomic_pattern.rs
@@ -231,7 +231,7 @@ mod tests {
 
     #[test]
     fn golden_python_prototype_security_variance_keyswitch_1() {
-        let golden_modular_variance = 3.260702274017557e+68;
+        let golden_modular_variance = 3.260_702_274_017_557e68;
         let input_lwe_dimension = 4096;
         let internal_ks_output_lwe_dimension = 1024;
         let ks_decomposition_level_count = 9;
@@ -257,7 +257,7 @@ mod tests {
     fn golden_python_prototype_security_variance_keyswitch_2() {
         // let golden_modular_variance = 8.580795457940938e+66;
         // the full npe implements a part of the full estimation
-        let golden_modular_variance = 3.941898681369209e+48; // full estimation
+        let golden_modular_variance = 3.941_898_681_369_209e48; // full estimation
         let input_lwe_dimension = 2048;
         let internal_ks_output_lwe_dimension = 512;
         let ks_decomposition_level_count = 2;
@@ -282,7 +282,7 @@ mod tests {
     #[test]
     fn golden_python_prototype_security_variance_bootstrap_1() {
         // golden value include fft correction
-        let golden_modular_variance = 6.283575623979502e+30;
+        let golden_modular_variance = 6.283_575_623_979_502e30;
         let internal_ks_output_lwe_dimension = 2048;
         let glwe_polynomial_size = 4096;
         let glwe_dimension = 10;
@@ -312,7 +312,7 @@ mod tests {
     #[test]
     fn golden_python_prototype_security_variance_bootstrap_2() {
         // golden value include fft correction
-        let golden_modular_variance = 1.3077694369436019e+56;
+        let golden_modular_variance = 1.307_769_436_943_601_9e56;
         let internal_ks_output_lwe_dimension = 1024;
         let glwe_polynomial_size = 4096;
         let glwe_dimension = 16;
diff --git a/src/security/glwe.rs b/src/security/glwe.rs
index 83ecaddd1..140095976 100644
--- a/src/security/glwe.rs
+++ b/src/security/glwe.rs
@@ -10,9 +10,10 @@ pub fn minimal_variance(
 ) -> Variance {
     // https://github.com/zama-ai/concrete-optimizer/blob/prototype/python/optimizer/noise_formulas/security.py
     // ensure to have a minimal on std deviation covering the 2 lowest bits on modular scale
-    if security_level != 128 {
-        panic!("Only 128 bits of security is supported")
-    }
+    assert!(
+        security_level == 128,
+        "Only 128 bits of security is supported"
+    );
     let espsilon_log2_std_modular = 2.0;
     let espsilon_log2_std = espsilon_log2_std_modular - (ciphertext_modulus_log as f64);
     let equiv_lwe_dimension = (glwe_dimension * glwe_polynomial_size) as f64;
@@ -34,7 +35,7 @@ mod tests {
         let log_poly_size = 14;
         let glwe_dimension = 10;
         let integer_size = 64;
-        let golden_std_dev = 0.312_008_988_392_6036;
+        let golden_std_dev = 0.312_008_988_392_603_6;
         let security_level = 128;
         let actual = minimal_variance(log_poly_size, glwe_dimension, integer_size, security_level);
         approx::assert_relative_eq!(