From bc80f0de10e6e145a788e24a9101080f855a1fb4 Mon Sep 17 00:00:00 2001 From: Umut Date: Wed, 29 Sep 2021 11:43:30 +0300 Subject: [PATCH] refactor: fix new pylint warnings --- concrete/numpy/np_dtypes_helpers.py | 6 +----- tests/conftest.py | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/concrete/numpy/np_dtypes_helpers.py b/concrete/numpy/np_dtypes_helpers.py index b4cab219b..72d3b52f2 100644 --- a/concrete/numpy/np_dtypes_helpers.py +++ b/concrete/numpy/np_dtypes_helpers.py @@ -123,11 +123,7 @@ def get_base_data_type_for_numpy_or_python_constant_data(constant_data: Any) -> f"Unsupported constant data of type {type(constant_data)}", ) if isinstance(constant_data, (numpy.ndarray, SUPPORTED_NUMPY_DTYPES_CLASS_TYPES)): - native_type = ( - float - if constant_data.dtype == numpy.float32 or constant_data.dtype == numpy.float64 - else int - ) + native_type = float if (constant_data.dtype in (numpy.float32, numpy.float64)) else int min_value = native_type(constant_data.min()) max_value = native_type(constant_data.max()) diff --git a/tests/conftest.py b/tests/conftest.py index 09d84a55f..2a0d48873 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -23,7 +23,7 @@ def _is_equivalent_to_binary_commutative(lhs: IntermediateNode, rhs: object) -> """is_equivalent_to for a binary and commutative operation.""" return ( isinstance(rhs, lhs.__class__) - and (lhs.inputs == rhs.inputs or lhs.inputs == rhs.inputs[::-1]) + and (lhs.inputs in (rhs.inputs, rhs.inputs[::-1])) and lhs.outputs == rhs.outputs )