From 0ab280d396ca6566deda294466e92b87f34a5d59 Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Thu, 23 Jun 2022 18:40:09 +0800 Subject: [PATCH] minor suggestions --- specs/eip4844/polynomial-commitments.md | 8 +++++--- specs/eip4844/validator.md | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/specs/eip4844/polynomial-commitments.md b/specs/eip4844/polynomial-commitments.md index 9558641c6..fc2339659 100644 --- a/specs/eip4844/polynomial-commitments.md +++ b/specs/eip4844/polynomial-commitments.md @@ -75,7 +75,7 @@ def bls_modular_inverse(x: BLSFieldElement) -> BLSFieldElement: #### `div` ```python -def div(x, y): +def div(x: BLSFieldElement, y: BLSFieldElement) -> BLSFieldElement: """Divide two field elements: `x` by `y`""" return x * inv(y) % BLS_MODULUS ``` @@ -111,7 +111,9 @@ def verify_kzg_proof(polynomial_kzg: KZGCommitment, x: BLSFieldElement, y: BLSFieldElement, quotient_kzg: KZGProof) -> bool: - """Verify KZG proof that `p(x) == y` where `p(x)` is the polynomial represented by `polynomial_kzg`""" + """ + Verify KZG proof that ``p(x) == y`` where ``p(x)`` is the polynomial represented by ``polynomial_kzg``. + """ # Verify: P - y = Q * (X - x) X_minus_x = bls.add(KZG_SETUP_G2[1], bls.multiply(bls.G2, BLS_MODULUS - x)) P_minus_y = bls.add(polynomial_kzg, bls.multiply(bls.G1, BLS_MODULUS - y)) @@ -137,7 +139,7 @@ def evaluate_polynomial_in_evaluation_form(poly: List[BLSFieldElement], x: BLSFi inverse_width = bls_modular_inverse(width) for i in range(width): - r += div(poly[i] * ROOTS_OF_UNITY[i], (x - ROOTS_OF_UNITY[i]) ) + r += div(poly[i] * ROOTS_OF_UNITY[i], (x - ROOTS_OF_UNITY[i])) r = r * (pow(x, width, BLS_MODULUS) - 1) * inverse_width % BLS_MODULUS return r diff --git a/specs/eip4844/validator.md b/specs/eip4844/validator.md index d636b39e4..fb96282c0 100644 --- a/specs/eip4844/validator.md +++ b/specs/eip4844/validator.md @@ -83,7 +83,7 @@ def vector_lincomb(vectors: List[List[BLSFieldElement]], scalars: List[BLSFieldE def verify_blobs_sidecar(slot: Slot, beacon_block_root: Root, - expected_kzgs: Sequence[KZGCommitment], blobs_sidecar: BlobsSidecar): + expected_kzgs: Sequence[KZGCommitment], blobs_sidecar: BlobsSidecar) -> None: assert slot == blobs_sidecar.beacon_block_slot assert beacon_block_root == blobs_sidecar.beacon_block_root blobs = blobs_sidecar.blobs