diff --git a/tests/core/pyspec/eth2spec/test/altair/block_processing/sync_aggregate/test_process_sync_aggregate.py b/tests/core/pyspec/eth2spec/test/altair/block_processing/sync_aggregate/test_process_sync_aggregate.py index f593353f9..25dd070a4 100644 --- a/tests/core/pyspec/eth2spec/test/altair/block_processing/sync_aggregate/test_process_sync_aggregate.py +++ b/tests/core/pyspec/eth2spec/test/altair/block_processing/sync_aggregate/test_process_sync_aggregate.py @@ -201,6 +201,74 @@ def test_sync_committee_rewards_duplicate_committee_full_participation(spec, sta yield from run_successful_sync_committee_test(spec, state, committee_indices, committee_bits) +@with_altair_and_later +@with_presets([MAINNET], reason="to create duplicate committee") +@spec_state_test +def test_sync_committee_rewards_duplicate_committee_only_participate_first_one(spec, state): + committee_indices = compute_committee_indices(state) + committee_size = len(committee_indices) + committee_bits = [False] * committee_size + + # Find duplicate indices that get selected twice + dup = {v for v in committee_indices if committee_indices.count(v) == 2} + assert len(dup) > 0 + validator_index = dup.pop() + positions = [i for i, v in enumerate(committee_indices) if v == validator_index] + committee_bits[positions[0]] = True + committee_bits[positions[1]] = False + + # Set validator's balance to 0 + state.validators[validator_index].effective_balance = 0 + state.balances[validator_index] = 0 + + active_validator_count = len(spec.get_active_validator_indices(state, spec.get_current_epoch(state))) + + # Preconditions of this test case + assert active_validator_count < spec.SYNC_COMMITTEE_SIZE + assert committee_size > len(set(committee_indices)) + + yield from run_successful_sync_committee_test(spec, state, committee_indices, committee_bits) + + # The validator gets reward first (balance > 0) and then gets the same amount of penalty (balance == 0) + assert state.balances[validator_index] == 0 + + +@with_altair_and_later +@with_presets([MAINNET], reason="to create duplicate committee") +@spec_state_test +def test_sync_committee_rewards_duplicate_committee_only_participate_second_one(spec, state): + committee_indices = compute_committee_indices(state) + committee_size = len(committee_indices) + committee_bits = [False] * committee_size + + # Find duplicate indices that get selected twice + dup = {v for v in committee_indices if committee_indices.count(v) == 2} + assert len(dup) > 0 + validator_index = dup.pop() + positions = [i for i, v in enumerate(committee_indices) if v == validator_index] + committee_bits[positions[0]] = False + committee_bits[positions[1]] = True + + # Set validator's balance to 0 + state.validators[validator_index].effective_balance = 0 + state.balances[validator_index] = 0 + + active_validator_count = len(spec.get_active_validator_indices(state, spec.get_current_epoch(state))) + + # Preconditions of this test case + assert active_validator_count < spec.SYNC_COMMITTEE_SIZE + assert committee_size > len(set(committee_indices)) + + # Skip `validate_sync_committee_rewards` because it doesn't handle the balance computation order + # inside the for loop + yield from run_successful_sync_committee_test( + spec, state, committee_indices, committee_bits, + skip_reward_validation=True) + + # The validator gets penalty first (balance is still 0) and then gets reward (balance > 0) + assert state.balances[validator_index] > 0 + + @with_altair_and_later @spec_state_test @always_bls diff --git a/tests/core/pyspec/eth2spec/test/helpers/sync_committee.py b/tests/core/pyspec/eth2spec/test/helpers/sync_committee.py index cc05b862b..d68c916ac 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/sync_committee.py +++ b/tests/core/pyspec/eth2spec/test/helpers/sync_committee.py @@ -107,10 +107,11 @@ def validate_sync_committee_rewards(spec, pre_state, post_state, committee_indic committee_bits, ) - assert post_state.balances[index] == pre_state.balances[index] + reward - penalty + balance = pre_state.balances[index] + reward + assert post_state.balances[index] == (0 if balance < penalty else balance - penalty) -def run_sync_committee_processing(spec, state, block, expect_exception=False): +def run_sync_committee_processing(spec, state, block, expect_exception=False, skip_reward_validation=False): """ Processes everything up to the sync committee work, then runs the sync committee work in isolation, and produces a pre-state and post-state (None if exception) specifically for sync-committee processing changes. @@ -131,14 +132,15 @@ def run_sync_committee_processing(spec, state, block, expect_exception=False): else: committee_indices = compute_committee_indices(state, state.current_sync_committee) committee_bits = block.body.sync_aggregate.sync_committee_bits - validate_sync_committee_rewards( - spec, - pre_state, - state, - committee_indices, - committee_bits, - block.proposer_index - ) + if not skip_reward_validation: + validate_sync_committee_rewards( + spec, + pre_state, + state, + committee_indices, + committee_bits, + block.proposer_index + ) def _build_block_for_next_slot_with_sync_participation(spec, state, committee_indices, committee_bits): @@ -156,6 +158,6 @@ def _build_block_for_next_slot_with_sync_participation(spec, state, committee_in return block -def run_successful_sync_committee_test(spec, state, committee_indices, committee_bits): +def run_successful_sync_committee_test(spec, state, committee_indices, committee_bits, skip_reward_validation=False): block = _build_block_for_next_slot_with_sync_participation(spec, state, committee_indices, committee_bits) - yield from run_sync_committee_processing(spec, state, block) + yield from run_sync_committee_processing(spec, state, block, skip_reward_validation=skip_reward_validation)