From 4ffa0dba60a4d8670f1a50ddead4f7bce2a66351 Mon Sep 17 00:00:00 2001 From: Danny Ryan Date: Tue, 5 May 2020 16:31:40 -0600 Subject: [PATCH] Apply suggestions from code review "rewards/penalties" -> "deltas" in throughout test comments/descriptions Co-authored-by: Diederik Loerakker --- tests/core/pyspec/eth2spec/test/helpers/rewards.py | 3 +-- .../eth2spec/test/phase_0/rewards/test_get_head_deltas.py | 3 +-- .../test/phase_0/rewards/test_get_inactivity_penalty_deltas.py | 3 +-- .../test/phase_0/rewards/test_get_inclusion_delay_deltas.py | 3 +-- .../eth2spec/test/phase_0/rewards/test_get_source_deltas.py | 3 +-- .../eth2spec/test/phase_0/rewards/test_get_target_deltas.py | 3 +-- tests/formats/rewards/README.md | 2 +- 7 files changed, 7 insertions(+), 13 deletions(-) diff --git a/tests/core/pyspec/eth2spec/test/helpers/rewards.py b/tests/core/pyspec/eth2spec/test/helpers/rewards.py index fa041dae4..eaeb9252e 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/rewards.py +++ b/tests/core/pyspec/eth2spec/test/helpers/rewards.py @@ -28,8 +28,7 @@ def run_attestation_component_deltas(spec, state, component_delta_fn, matching_a """ Run ``component_delta_fn``, yielding: - pre-state ('pre') - - rewards ('rewards') - - penalties ('penalties') + - deltas ('deltas') """ yield 'pre', state diff --git a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_head_deltas.py b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_head_deltas.py index ffaad15af..2e4b9dbbc 100644 --- a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_head_deltas.py +++ b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_head_deltas.py @@ -7,8 +7,7 @@ def run_get_head_deltas(spec, state): """ Run ``get_head_deltas``, yielding: - pre-state ('pre') - - rewards ('rewards') - - penalties ('penalties') + - deltas ('deltas') """ yield from run_attestation_component_deltas( diff --git a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inactivity_penalty_deltas.py b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inactivity_penalty_deltas.py index 52ad631ca..4940cdc63 100644 --- a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inactivity_penalty_deltas.py +++ b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inactivity_penalty_deltas.py @@ -9,8 +9,7 @@ def run_get_inactivity_penalty_deltas(spec, state): """ Run ``get_inactivity_penalty_deltas``, yielding: - pre-state ('pre') - - rewards ('rewards') - - penalties ('penalties') + - deltas ('deltas') """ yield 'pre', state diff --git a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inclusion_delay_deltas.py b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inclusion_delay_deltas.py index 29ac10131..526d135ed 100644 --- a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inclusion_delay_deltas.py +++ b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_inclusion_delay_deltas.py @@ -10,8 +10,7 @@ def run_get_inclusion_delay_deltas(spec, state): """ Run ``get_inclusion_delay_deltas``, yielding: - pre-state ('pre') - - rewards ('rewards') - - penalties ('penalties') + - deltas ('deltas') """ yield 'pre', state diff --git a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_source_deltas.py b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_source_deltas.py index 120260d82..54f8f3b5d 100644 --- a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_source_deltas.py +++ b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_source_deltas.py @@ -7,8 +7,7 @@ def run_get_source_deltas(spec, state): """ Run ``get_source_deltas``, yielding: - pre-state ('pre') - - rewards ('rewards') - - penalties ('penalties') + - deltas ('deltas') """ yield from run_attestation_component_deltas( diff --git a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_target_deltas.py b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_target_deltas.py index ad7198c84..0ae985086 100644 --- a/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_target_deltas.py +++ b/tests/core/pyspec/eth2spec/test/phase_0/rewards/test_get_target_deltas.py @@ -7,8 +7,7 @@ def run_get_target_deltas(spec, state): """ Run ``get_target_deltas``, yielding: - pre-state ('pre') - - rewards ('rewards') - - penalties ('penalties') + - deltas ('deltas') """ yield from run_attestation_component_deltas( diff --git a/tests/formats/rewards/README.md b/tests/formats/rewards/README.md index bffe2e7de..f70a20f9c 100644 --- a/tests/formats/rewards/README.md +++ b/tests/formats/rewards/README.md @@ -33,7 +33,7 @@ class Deltas(Container): penalties: List[uint64, VALIDATOR_REGISTRY_LIMIT] ``` -Also available as `rewards.ssz`. +Also available as `deltas.ssz`. ## Condition