From 72a4ff803b3be39da3a29730a273b04ec6f35a87 Mon Sep 17 00:00:00 2001
From: Alex Stokes <r.alex.stokes@gmail.com>
Date: Fri, 7 May 2021 17:02:52 -0700
Subject: [PATCH] add test to ensure sync committees are referenced from the
 state

---
 .../test_process_sync_committee.py            | 55 ++++++++++++++++---
 1 file changed, 48 insertions(+), 7 deletions(-)

diff --git a/tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_committee.py b/tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_committee.py
index e0faf3d0d..3e4d77c0f 100644
--- a/tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_committee.py
+++ b/tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_committee.py
@@ -7,6 +7,7 @@ from eth2spec.test.helpers.block_processing import run_block_processing_to
 from eth2spec.test.helpers.state import (
     state_transition_and_sign_block,
     transition_to,
+    next_epoch,
 )
 from eth2spec.test.helpers.constants import (
     PHASE0,
@@ -160,13 +161,13 @@ def validate_sync_committee_rewards(spec, pre_state, post_state, committee, comm
                 committee_bits,
             )
 
-            if proposer_index == index:
-                reward += compute_sync_committee_proposer_reward(
-                    spec,
-                    pre_state,
-                    committee,
-                    committee_bits,
-                )
+        if proposer_index == index:
+            reward += compute_sync_committee_proposer_reward(
+                spec,
+                pre_state,
+                committee,
+                committee_bits,
+            )
 
         assert post_state.balances[index] == pre_state.balances[index] + reward
 
@@ -367,3 +368,43 @@ def test_valid_signature_future_committee(spec, state):
     )
 
     yield from run_sync_committee_processing(spec, state, block)
+
+
+@with_all_phases_except([PHASE0])
+@spec_state_test
+def test_sync_committee_is_only_computed_at_epoch_boundary(spec, state):
+    """
+    Sync committees can only be computed at sync committee period boundaries.
+    Ensure a client respects the committee in the state (assumed to be derived
+    in the correct way).
+    """
+    current_epoch = spec.get_current_epoch(state)
+
+    # use a "synthetic" committee to simulate the situation
+    # where ``spec.get_sync_committee`` at the sync committee
+    # period epoch boundary would have diverged some epochs into the
+    # period; ``aggregate_pubkey`` is not relevant to this test
+    pubkeys = []
+    committee_indices = []
+    i = 0
+    active_validator_count = len(spec.get_active_validator_indices(state, current_epoch))
+    while len(pubkeys) < spec.SYNC_COMMITTEE_SIZE:
+        v = state.validators[i % active_validator_count]
+        if spec.is_active_validator(v, current_epoch):
+            pubkeys.append(v.pubkey)
+            committee_indices.append(i)
+        i += 1
+
+    synthetic_committee = spec.SyncCommittee(pubkeys=pubkeys, aggregate_pubkey=spec.BLSPubkey())
+    state.current_sync_committee = synthetic_committee
+
+    assert spec.EPOCHS_PER_SYNC_COMMITTEE_PERIOD > 3
+    for _ in range(3):
+        next_epoch(spec, state)
+
+    committee = get_committee_indices(spec, state)
+    assert committee != committee_indices
+    committee_size = len(committee_indices)
+    committee_bits = [True] * committee_size
+
+    yield from run_successful_sync_committee_test(spec, state, committee_indices, committee_bits)