From 6ffd27bd60194ba135107af6bfd6d33a843df456 Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Fri, 16 Feb 2024 12:29:00 +0800 Subject: [PATCH 01/25] Rename EIP6110 to Electra --- .circleci/config.yml | 6 ++-- .github/workflows/run-tests.yml | 2 +- .gitignore | 2 +- Makefile | 2 +- README.md | 2 +- configs/mainnet.yaml | 6 ++-- configs/minimal.yaml | 6 ++-- .../mainnet/{eip6110.yaml => electra.yaml} | 2 +- .../minimal/{eip6110.yaml => electra.yaml} | 2 +- pysetup/constants.py | 2 +- pysetup/md_doc_paths.py | 4 +-- pysetup/spec_builders/__init__.py | 4 +-- .../spec_builders/{eip6110.py => electra.py} | 6 ++-- scripts/build_run_docker_tests.sh | 2 +- .../eip6110 => electra}/beacon-chain.md | 6 ++-- specs/{_features/eip6110 => electra}/fork.md | 18 +++++----- .../eip6110 => electra}/validator.md | 0 tests/core/pyspec/eth2spec/test/context.py | 6 ++-- .../test/{eip6110 => electra}/__init__.py | 0 .../block_processing/__init__.py | 0 .../test_process_deposit_receipt.py | 36 +++++++++---------- .../{eip6110 => electra}/sanity/__init__.py | 0 .../sanity/blocks/__init__.py | 0 .../sanity/blocks/test_deposit_transition.py | 18 +++++----- .../pyspec/eth2spec/test/helpers/constants.py | 10 +++--- .../test/helpers/execution_payload.py | 10 +++--- .../pyspec/eth2spec/test/helpers/forks.py | 6 ++-- .../pyspec/eth2spec/test/helpers/genesis.py | 6 ++-- tests/formats/operations/README.md | 2 +- tests/generators/epoch_processing/main.py | 6 ++-- tests/generators/finality/main.py | 6 ++-- tests/generators/fork_choice/main.py | 6 ++-- tests/generators/genesis/main.py | 6 ++-- tests/generators/operations/main.py | 8 ++--- tests/generators/rewards/main.py | 6 ++-- tests/generators/sanity/main.py | 8 ++--- tests/generators/sync/main.py | 6 ++-- 37 files changed, 109 insertions(+), 109 deletions(-) rename presets/mainnet/{eip6110.yaml => electra.yaml} (84%) rename presets/minimal/{eip6110.yaml => electra.yaml} (82%) rename pysetup/spec_builders/{eip6110.py => electra.py} (62%) rename specs/{_features/eip6110 => electra}/beacon-chain.md (98%) rename specs/{_features/eip6110 => electra}/fork.md (91%) rename specs/{_features/eip6110 => electra}/validator.md (100%) rename tests/core/pyspec/eth2spec/test/{eip6110 => electra}/__init__.py (100%) rename tests/core/pyspec/eth2spec/test/{eip6110 => electra}/block_processing/__init__.py (100%) rename tests/core/pyspec/eth2spec/test/{eip6110 => electra}/block_processing/test_process_deposit_receipt.py (96%) rename tests/core/pyspec/eth2spec/test/{eip6110 => electra}/sanity/__init__.py (100%) rename tests/core/pyspec/eth2spec/test/{eip6110 => electra}/sanity/blocks/__init__.py (100%) rename tests/core/pyspec/eth2spec/test/{eip6110 => electra}/sanity/blocks/test_deposit_transition.py (98%) diff --git a/.circleci/config.yml b/.circleci/config.yml index 0367da9dd..4a29702e5 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -155,7 +155,7 @@ jobs: command: make citest fork=deneb - store_test_results: path: tests/core/pyspec/test-reports - test-eip6110: + test-electra: docker: - image: circleci/python:3.9 working_directory: ~/specs-repo @@ -165,7 +165,7 @@ jobs: - restore_pyspec_cached_venv - run: name: Run py-tests - command: make citest fork=eip6110 + command: make citest fork=electra - store_test_results: path: tests/core/pyspec/test-reports test-eip7002: @@ -327,7 +327,7 @@ workflows: - test-deneb: requires: - install_pyspec_test - - test-eip6110: + - test-electra: requires: - install_pyspec_test - test-eip7002: diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 2973afb06..e83968979 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -71,7 +71,7 @@ jobs: needs: [preclear,lint,codespell,table_of_contents] strategy: matrix: - version: ["phase0", "altair", "bellatrix", "capella", "deneb", "eip6110", "eip7002", "whisk", "eip7594"] + version: ["phase0", "altair", "bellatrix", "capella", "deneb", "electra", "eip7002", "whisk", "eip7594"] steps: - name: Checkout this repo uses: actions/checkout@v3.2.0 diff --git a/.gitignore b/.gitignore index 474db02c5..f3d9881cb 100644 --- a/.gitignore +++ b/.gitignore @@ -21,7 +21,7 @@ tests/core/pyspec/eth2spec/altair/ tests/core/pyspec/eth2spec/bellatrix/ tests/core/pyspec/eth2spec/capella/ tests/core/pyspec/eth2spec/deneb/ -tests/core/pyspec/eth2spec/eip6110/ +tests/core/pyspec/eth2spec/electra/ tests/core/pyspec/eth2spec/eip7002/ tests/core/pyspec/eth2spec/whisk/ tests/core/pyspec/eth2spec/eip7594/ diff --git a/Makefile b/Makefile index d0d750e89..5cd022669 100644 --- a/Makefile +++ b/Makefile @@ -35,7 +35,7 @@ MARKDOWN_FILES = $(wildcard $(SPEC_DIR)/*/*.md) \ $(wildcard $(SPEC_DIR)/_features/*/*/*.md) \ $(wildcard $(SSZ_DIR)/*.md) -ALL_EXECUTABLE_SPEC_NAMES = phase0 altair bellatrix capella deneb eip6110 eip7002 whisk +ALL_EXECUTABLE_SPEC_NAMES = phase0 altair bellatrix capella deneb electra eip7002 whisk # The parameters for commands. Use `foreach` to avoid listing specs again. COVERAGE_SCOPE := $(foreach S,$(ALL_EXECUTABLE_SPEC_NAMES), --cov=eth2spec.$S.$(TEST_PRESET_TYPE)) PYLINT_SCOPE := $(foreach S,$(ALL_EXECUTABLE_SPEC_NAMES), ./eth2spec/$S) diff --git a/README.md b/README.md index 1e4ceebf5..e59e09612 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ Features are researched and developed in parallel, and then consolidated into se | Sharding (outdated) | | | Custody Game (outdated) | | Dependent on sharding | | Data Availability Sampling (outdated) | | | -| EIP-6110 | | +| EIP-6110 | | ### Accompanying documents can be found in [specs](specs) and include: diff --git a/configs/mainnet.yaml b/configs/mainnet.yaml index 317daa1a4..f3bf4327a 100644 --- a/configs/mainnet.yaml +++ b/configs/mainnet.yaml @@ -50,9 +50,9 @@ CAPELLA_FORK_EPOCH: 194048 # April 12, 2023, 10:27:35pm UTC # Deneb DENEB_FORK_VERSION: 0x04000000 DENEB_FORK_EPOCH: 269568 # March 13, 2024, 01:55:35pm UTC -# EIP6110 -EIP6110_FORK_VERSION: 0x05000000 # temporary stub -EIP6110_FORK_EPOCH: 18446744073709551615 +# Electra +ELECTRA_FORK_VERSION: 0x05000000 # temporary stub +ELECTRA_FORK_EPOCH: 18446744073709551615 # EIP7002 EIP7002_FORK_VERSION: 0x05000000 # temporary stub EIP7002_FORK_EPOCH: 18446744073709551615 diff --git a/configs/minimal.yaml b/configs/minimal.yaml index 6b2da84fd..2992881b1 100644 --- a/configs/minimal.yaml +++ b/configs/minimal.yaml @@ -49,9 +49,9 @@ CAPELLA_FORK_EPOCH: 18446744073709551615 # DENEB DENEB_FORK_VERSION: 0x04000001 DENEB_FORK_EPOCH: 18446744073709551615 -# EIP6110 -EIP6110_FORK_VERSION: 0x05000001 -EIP6110_FORK_EPOCH: 18446744073709551615 +# ELECTRA +ELECTRA_FORK_VERSION: 0x05000001 +ELECTRA_FORK_EPOCH: 18446744073709551615 # EIP7002 EIP7002_FORK_VERSION: 0x05000001 EIP7002_FORK_EPOCH: 18446744073709551615 diff --git a/presets/mainnet/eip6110.yaml b/presets/mainnet/electra.yaml similarity index 84% rename from presets/mainnet/eip6110.yaml rename to presets/mainnet/electra.yaml index 16bf787d0..1f64c2332 100644 --- a/presets/mainnet/eip6110.yaml +++ b/presets/mainnet/electra.yaml @@ -1,4 +1,4 @@ -# Mainnet preset - EIP6110 +# Mainnet preset - ELECTRA # Execution # --------------------------------------------------------------- diff --git a/presets/minimal/eip6110.yaml b/presets/minimal/electra.yaml similarity index 82% rename from presets/minimal/eip6110.yaml rename to presets/minimal/electra.yaml index 7486aa16e..75664afa5 100644 --- a/presets/minimal/eip6110.yaml +++ b/presets/minimal/electra.yaml @@ -1,4 +1,4 @@ -# Minimal preset - EIP6110 +# Minimal preset - Electra # Execution # --------------------------------------------------------------- diff --git a/pysetup/constants.py b/pysetup/constants.py index 238b3b02c..d017d8c01 100644 --- a/pysetup/constants.py +++ b/pysetup/constants.py @@ -4,7 +4,7 @@ ALTAIR = 'altair' BELLATRIX = 'bellatrix' CAPELLA = 'capella' DENEB = 'deneb' -EIP6110 = 'eip6110' +ELECTRA = 'electra' EIP7002 = 'eip7002' WHISK = 'whisk' EIP7594 = 'eip7594' diff --git a/pysetup/md_doc_paths.py b/pysetup/md_doc_paths.py index c93c0c032..d8465f233 100644 --- a/pysetup/md_doc_paths.py +++ b/pysetup/md_doc_paths.py @@ -6,7 +6,7 @@ from .constants import ( BELLATRIX, CAPELLA, DENEB, - EIP6110, + ELECTRA, WHISK, EIP7002, EIP7594, @@ -19,7 +19,7 @@ PREVIOUS_FORK_OF = { BELLATRIX: ALTAIR, CAPELLA: BELLATRIX, DENEB: CAPELLA, - EIP6110: DENEB, + ELECTRA: DENEB, WHISK: CAPELLA, EIP7002: CAPELLA, EIP7594: DENEB, diff --git a/pysetup/spec_builders/__init__.py b/pysetup/spec_builders/__init__.py index 061d11626..0a6cfcc43 100644 --- a/pysetup/spec_builders/__init__.py +++ b/pysetup/spec_builders/__init__.py @@ -3,7 +3,7 @@ from .altair import AltairSpecBuilder from .bellatrix import BellatrixSpecBuilder from .capella import CapellaSpecBuilder from .deneb import DenebSpecBuilder -from .eip6110 import EIP6110SpecBuilder +from .electra import ElectraSpecBuilder from .eip7002 import EIP7002SpecBuilder from .whisk import WhiskSpecBuilder from .eip7594 import EIP7594SpecBuilder @@ -13,6 +13,6 @@ spec_builders = { builder.fork: builder for builder in ( Phase0SpecBuilder, AltairSpecBuilder, BellatrixSpecBuilder, CapellaSpecBuilder, DenebSpecBuilder, - EIP6110SpecBuilder, EIP7002SpecBuilder, WhiskSpecBuilder, EIP7594SpecBuilder, + ElectraSpecBuilder, EIP7002SpecBuilder, WhiskSpecBuilder, EIP7594SpecBuilder, ) } diff --git a/pysetup/spec_builders/eip6110.py b/pysetup/spec_builders/electra.py similarity index 62% rename from pysetup/spec_builders/eip6110.py rename to pysetup/spec_builders/electra.py index e0fd253f1..bee1e72e9 100644 --- a/pysetup/spec_builders/eip6110.py +++ b/pysetup/spec_builders/electra.py @@ -1,9 +1,9 @@ from .base import BaseSpecBuilder -from ..constants import EIP6110 +from ..constants import ELECTRA -class EIP6110SpecBuilder(BaseSpecBuilder): - fork: str = EIP6110 +class ElectraSpecBuilder(BaseSpecBuilder): + fork: str = ELECTRA @classmethod def imports(cls, preset_name: str): diff --git a/scripts/build_run_docker_tests.sh b/scripts/build_run_docker_tests.sh index 368fab94c..a7fdfbc3d 100755 --- a/scripts/build_run_docker_tests.sh +++ b/scripts/build_run_docker_tests.sh @@ -10,7 +10,7 @@ # Set variables -ALL_EXECUTABLE_SPECS=("phase0" "altair" "bellatrix" "capella" "deneb" "eip6110" "whisk") +ALL_EXECUTABLE_SPECS=("phase0" "altair" "bellatrix" "capella" "deneb" "electra" "whisk") TEST_PRESET_TYPE=minimal FORK_TO_TEST=phase0 NUMBER_OF_CORES=4 diff --git a/specs/_features/eip6110/beacon-chain.md b/specs/electra/beacon-chain.md similarity index 98% rename from specs/_features/eip6110/beacon-chain.md rename to specs/electra/beacon-chain.md index e2964267d..4351c7482 100644 --- a/specs/_features/eip6110/beacon-chain.md +++ b/specs/electra/beacon-chain.md @@ -284,7 +284,7 @@ def process_execution_payload(state: BeaconState, body: BeaconBlockBody, executi *Note*: The function `initialize_beacon_state_from_eth1` is modified for pure EIP-6110 testing only. Modifications include: -1. Use `EIP6110_FORK_VERSION` as the previous and current fork version. +1. Use `ELECTRA_FORK_VERSION` as the previous and current fork version. 2. Utilize the EIP-6110 `BeaconBlockBody` when constructing the initial `latest_block_header`. 3. Add `deposit_receipts_start_index` variable to the genesis state initialization. @@ -295,8 +295,8 @@ def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, execution_payload_header: ExecutionPayloadHeader=ExecutionPayloadHeader() ) -> BeaconState: fork = Fork( - previous_version=EIP6110_FORK_VERSION, # [Modified in EIP6110] for testing only - current_version=EIP6110_FORK_VERSION, # [Modified in EIP6110] + previous_version=ELECTRA_FORK_VERSION, # [Modified in EIP6110] for testing only + current_version=ELECTRA_FORK_VERSION, # [Modified in EIP6110] epoch=GENESIS_EPOCH, ) state = BeaconState( diff --git a/specs/_features/eip6110/fork.md b/specs/electra/fork.md similarity index 91% rename from specs/_features/eip6110/fork.md rename to specs/electra/fork.md index 6b5ab0431..a592f1c5e 100644 --- a/specs/_features/eip6110/fork.md +++ b/specs/electra/fork.md @@ -28,8 +28,8 @@ Warning: this configuration is not definitive. | Name | Value | | - | - | -| `EIP6110_FORK_VERSION` | `Version('0x05000000')` | -| `EIP6110_FORK_EPOCH` | `Epoch(18446744073709551615)` **TBD** | +| `ELECTRA_FORK_VERSION` | `Version('0x05000000')` | +| `ELECTRA_FORK_EPOCH` | `Epoch(18446744073709551615)` **TBD** | ## Helper functions @@ -42,8 +42,8 @@ def compute_fork_version(epoch: Epoch) -> Version: """ Return the fork version at the given ``epoch``. """ - if epoch >= EIP6110_FORK_EPOCH: - return EIP6110_FORK_VERSION + if epoch >= ELECTRA_FORK_EPOCH: + return ELECTRA_FORK_VERSION if epoch >= DENEB_FORK_EPOCH: return DENEB_FORK_VERSION if epoch >= CAPELLA_FORK_EPOCH: @@ -60,17 +60,17 @@ def compute_fork_version(epoch: Epoch) -> Version: ### Fork trigger TBD. This fork is defined for testing purposes, the EIP may be combined with other consensus-layer upgrade. -For now, we assume the condition will be triggered at epoch `EIP6110_FORK_EPOCH`. +For now, we assume the condition will be triggered at epoch `ELECTRA_FORK_EPOCH`. -Note that for the pure EIP-6110 networks, we don't apply `upgrade_to_eip6110` since it starts with EIP-6110 version logic. +Note that for the pure EIP-6110 networks, we don't apply `upgrade_to_electra` since it starts with EIP-6110 version logic. ### Upgrading the state -If `state.slot % SLOTS_PER_EPOCH == 0` and `compute_epoch_at_slot(state.slot) == EIP6110_FORK_EPOCH`, +If `state.slot % SLOTS_PER_EPOCH == 0` and `compute_epoch_at_slot(state.slot) == ELECTRA_FORK_EPOCH`, an irregular state change is made to upgrade to EIP-6110. ```python -def upgrade_to_eip6110(pre: deneb.BeaconState) -> BeaconState: +def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: epoch = deneb.get_current_epoch(pre) latest_execution_payload_header = ExecutionPayloadHeader( parent_hash=pre.latest_execution_payload_header.parent_hash, @@ -99,7 +99,7 @@ def upgrade_to_eip6110(pre: deneb.BeaconState) -> BeaconState: slot=pre.slot, fork=Fork( previous_version=pre.fork.current_version, - current_version=EIP6110_FORK_VERSION, # [Modified in EIP-6110] + current_version=ELECTRA_FORK_VERSION, # [Modified in EIP-6110] epoch=epoch, ), # History diff --git a/specs/_features/eip6110/validator.md b/specs/electra/validator.md similarity index 100% rename from specs/_features/eip6110/validator.md rename to specs/electra/validator.md diff --git a/tests/core/pyspec/eth2spec/test/context.py b/tests/core/pyspec/eth2spec/test/context.py index e940e24e7..74fd3b2db 100644 --- a/tests/core/pyspec/eth2spec/test/context.py +++ b/tests/core/pyspec/eth2spec/test/context.py @@ -7,8 +7,8 @@ from eth2spec.utils import bls from .exceptions import SkippedTest from .helpers.constants import ( - PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, - EIP6110, EIP7002, EIP7594, + PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA, + EIP7002, EIP7594, WHISK, MINIMAL, ALL_PHASES, @@ -507,7 +507,7 @@ with_altair_and_later = with_all_phases_from(ALTAIR) with_bellatrix_and_later = with_all_phases_from(BELLATRIX) with_capella_and_later = with_all_phases_from(CAPELLA) with_deneb_and_later = with_all_phases_from(DENEB) -with_eip6110_and_later = with_all_phases_from(EIP6110) +with_electra_and_later = with_all_phases_from(ELECTRA) with_eip7002_and_later = with_all_phases_from(EIP7002) with_whisk_and_later = with_all_phases_from(WHISK, all_phases=ALLOWED_TEST_RUNNER_FORKS) with_eip7594_and_later = with_all_phases_from(EIP7594, all_phases=ALLOWED_TEST_RUNNER_FORKS) diff --git a/tests/core/pyspec/eth2spec/test/eip6110/__init__.py b/tests/core/pyspec/eth2spec/test/electra/__init__.py similarity index 100% rename from tests/core/pyspec/eth2spec/test/eip6110/__init__.py rename to tests/core/pyspec/eth2spec/test/electra/__init__.py diff --git a/tests/core/pyspec/eth2spec/test/eip6110/block_processing/__init__.py b/tests/core/pyspec/eth2spec/test/electra/block_processing/__init__.py similarity index 100% rename from tests/core/pyspec/eth2spec/test/eip6110/block_processing/__init__.py rename to tests/core/pyspec/eth2spec/test/electra/block_processing/__init__.py diff --git a/tests/core/pyspec/eth2spec/test/eip6110/block_processing/test_process_deposit_receipt.py b/tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_deposit_receipt.py similarity index 96% rename from tests/core/pyspec/eth2spec/test/eip6110/block_processing/test_process_deposit_receipt.py rename to tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_deposit_receipt.py index d78c18ecb..d1b8fec12 100644 --- a/tests/core/pyspec/eth2spec/test/eip6110/block_processing/test_process_deposit_receipt.py +++ b/tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_deposit_receipt.py @@ -1,4 +1,4 @@ -from eth2spec.test.context import spec_state_test, always_bls, with_eip6110_and_later +from eth2spec.test.context import spec_state_test, always_bls, with_electra_and_later from eth2spec.test.helpers.deposits import ( prepare_deposit_receipt, run_deposit_receipt_processing, @@ -8,7 +8,7 @@ from eth2spec.test.helpers.state import next_epoch_via_block from eth2spec.test.helpers.withdrawals import set_validator_fully_withdrawable -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_new_deposit_under_max(spec, state): # fresh deposit = next validator index = validator appended to registry @@ -20,7 +20,7 @@ def test_new_deposit_under_max(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_new_deposit_max(spec, state): # fresh deposit = next validator index = validator appended to registry @@ -32,7 +32,7 @@ def test_new_deposit_max(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_new_deposit_over_max(spec, state): # fresh deposit = next validator index = validator appended to registry @@ -44,7 +44,7 @@ def test_new_deposit_over_max(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_new_deposit_eth1_withdrawal_credentials(spec, state): # fresh deposit = next validator index = validator appended to registry @@ -66,7 +66,7 @@ def test_new_deposit_eth1_withdrawal_credentials(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_new_deposit_non_versioned_withdrawal_credentials(spec, state): # fresh deposit = next validator index = validator appended to registry @@ -87,7 +87,7 @@ def test_new_deposit_non_versioned_withdrawal_credentials(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test @always_bls def test_correct_sig_but_forked_state(spec, state): @@ -99,7 +99,7 @@ def test_correct_sig_but_forked_state(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test @always_bls def test_incorrect_sig_new_deposit(spec, state): @@ -110,7 +110,7 @@ def test_incorrect_sig_new_deposit(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index, effective=False) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_top_up__max_effective_balance(spec, state): validator_index = 0 @@ -126,7 +126,7 @@ def test_top_up__max_effective_balance(spec, state): assert state.validators[validator_index].effective_balance == spec.MAX_EFFECTIVE_BALANCE -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_top_up__less_effective_balance(spec, state): validator_index = 0 @@ -145,7 +145,7 @@ def test_top_up__less_effective_balance(spec, state): assert state.validators[validator_index].effective_balance == initial_effective_balance -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_top_up__zero_balance(spec, state): validator_index = 0 @@ -164,7 +164,7 @@ def test_top_up__zero_balance(spec, state): assert state.validators[validator_index].effective_balance == initial_effective_balance -@with_eip6110_and_later +@with_electra_and_later @spec_state_test @always_bls def test_incorrect_sig_top_up(spec, state): @@ -176,7 +176,7 @@ def test_incorrect_sig_top_up(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_incorrect_withdrawal_credentials_top_up(spec, state): validator_index = 0 @@ -193,7 +193,7 @@ def test_incorrect_withdrawal_credentials_top_up(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_key_validate_invalid_subgroup(spec, state): validator_index = len(state.validators) @@ -207,7 +207,7 @@ def test_key_validate_invalid_subgroup(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_key_validate_invalid_decompression(spec, state): validator_index = len(state.validators) @@ -223,7 +223,7 @@ def test_key_validate_invalid_decompression(spec, state): yield from run_deposit_receipt_processing(spec, state, deposit_receipt, validator_index) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test @always_bls def test_ineffective_deposit_with_previous_fork_version(spec, state): @@ -240,7 +240,7 @@ def test_ineffective_deposit_with_previous_fork_version(spec, state): ) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test @always_bls def test_effective_deposit_with_genesis_fork_version(spec, state): @@ -253,7 +253,7 @@ def test_effective_deposit_with_genesis_fork_version(spec, state): ) -@with_eip6110_and_later +@with_electra_and_later @spec_state_test def test_success_top_up_to_withdrawn_validator(spec, state): validator_index = 0 diff --git a/tests/core/pyspec/eth2spec/test/eip6110/sanity/__init__.py b/tests/core/pyspec/eth2spec/test/electra/sanity/__init__.py similarity index 100% rename from tests/core/pyspec/eth2spec/test/eip6110/sanity/__init__.py rename to tests/core/pyspec/eth2spec/test/electra/sanity/__init__.py diff --git a/tests/core/pyspec/eth2spec/test/eip6110/sanity/blocks/__init__.py b/tests/core/pyspec/eth2spec/test/electra/sanity/blocks/__init__.py similarity index 100% rename from tests/core/pyspec/eth2spec/test/eip6110/sanity/blocks/__init__.py rename to tests/core/pyspec/eth2spec/test/electra/sanity/blocks/__init__.py diff --git a/tests/core/pyspec/eth2spec/test/eip6110/sanity/blocks/test_deposit_transition.py b/tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_deposit_transition.py similarity index 98% rename from tests/core/pyspec/eth2spec/test/eip6110/sanity/blocks/test_deposit_transition.py rename to tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_deposit_transition.py index 51ef10960..419bc55cf 100644 --- a/tests/core/pyspec/eth2spec/test/eip6110/sanity/blocks/test_deposit_transition.py +++ b/tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_deposit_transition.py @@ -4,7 +4,7 @@ from eth2spec.test.helpers.block import ( from eth2spec.test.context import ( spec_state_test, with_phases, - EIP6110, + ELECTRA, ) from eth2spec.test.helpers.deposits import ( build_deposit_data, @@ -108,7 +108,7 @@ def prepare_state_and_block(spec, return state, block -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__start_index_is_set(spec, state): # 0 deposits, 2 deposit receipts, unset deposit_receipts_start_index @@ -123,7 +123,7 @@ def test_deposit_transition__start_index_is_set(spec, state): assert state.deposit_receipts_start_index == block.body.execution_payload.deposit_receipts[0].index -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__process_eth1_deposits(spec, state): # 3 deposits, 1 deposit receipt, state.eth1_data.deposit_count < state.deposit_receipts_start_index @@ -136,7 +136,7 @@ def test_deposit_transition__process_eth1_deposits(spec, state): yield from run_deposit_transition_block(spec, state, block) -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__process_max_eth1_deposits(spec, state): # spec.MAX_DEPOSITS deposits, 1 deposit receipt, state.eth1_data.deposit_count > state.deposit_receipts_start_index @@ -151,7 +151,7 @@ def test_deposit_transition__process_max_eth1_deposits(spec, state): yield from run_deposit_transition_block(spec, state, block) -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__process_eth1_deposits_up_to_start_index(spec, state): # 3 deposits, 1 deposit receipt, state.eth1_data.deposit_count == state.deposit_receipts_start_index @@ -164,7 +164,7 @@ def test_deposit_transition__process_eth1_deposits_up_to_start_index(spec, state yield from run_deposit_transition_block(spec, state, block) -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__invalid_not_enough_eth1_deposits(spec, state): # 3 deposits, 1 deposit receipt, state.eth1_data.deposit_count < state.deposit_receipts_start_index @@ -178,7 +178,7 @@ def test_deposit_transition__invalid_not_enough_eth1_deposits(spec, state): yield from run_deposit_transition_block(spec, state, block, valid=False) -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__invalid_too_many_eth1_deposits(spec, state): # 3 deposits, 1 deposit receipt, state.eth1_data.deposit_count < state.eth1_data_index @@ -192,7 +192,7 @@ def test_deposit_transition__invalid_too_many_eth1_deposits(spec, state): yield from run_deposit_transition_block(spec, state, block, valid=False) -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__invalid_eth1_deposits_overlap_in_protocol_deposits(spec, state): # spec.MAX_DEPOSITS deposits, 1 deposit receipt, state.eth1_data.deposit_count > state.deposit_receipts_start_index @@ -207,7 +207,7 @@ def test_deposit_transition__invalid_eth1_deposits_overlap_in_protocol_deposits( yield from run_deposit_transition_block(spec, state, block, valid=False) -@with_phases([EIP6110]) +@with_phases([ELECTRA]) @spec_state_test def test_deposit_transition__deposit_and_top_up_same_block(spec, state): # 1 deposit, 1 deposit receipt that top ups deposited validator diff --git a/tests/core/pyspec/eth2spec/test/helpers/constants.py b/tests/core/pyspec/eth2spec/test/helpers/constants.py index a51201906..dc2f125e6 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/constants.py +++ b/tests/core/pyspec/eth2spec/test/helpers/constants.py @@ -16,7 +16,7 @@ DENEB = SpecForkName('deneb') SHARDING = SpecForkName('sharding') CUSTODY_GAME = SpecForkName('custody_game') DAS = SpecForkName('das') -EIP6110 = SpecForkName('eip6110') +ELECTRA = SpecForkName('electra') EIP7002 = SpecForkName('eip7002') WHISK = SpecForkName('whisk') EIP7594 = SpecForkName('eip7594') @@ -35,15 +35,15 @@ ALL_PHASES = ( # Formal forks *MAINNET_FORKS, DENEB, + ELECTRA, # Experimental patches - EIP6110, EIP7002, EIP7594, ) # The forks that have light client specs LIGHT_CLIENT_TESTING_FORKS = (*[item for item in MAINNET_FORKS if item != PHASE0], DENEB) # The forks that output to the test vectors. -TESTGEN_FORKS = (*MAINNET_FORKS, DENEB, EIP6110, WHISK) +TESTGEN_FORKS = (*MAINNET_FORKS, DENEB, ELECTRA, WHISK) # Forks allowed in the test runner `--fork` flag, to fail fast in case of typos ALLOWED_TEST_RUNNER_FORKS = (*ALL_PHASES, WHISK) @@ -55,8 +55,8 @@ PREVIOUS_FORK_OF = { BELLATRIX: ALTAIR, CAPELLA: BELLATRIX, DENEB: CAPELLA, + ELECTRA: DENEB, # Experimental patches - EIP6110: DENEB, WHISK: CAPELLA, EIP7002: CAPELLA, EIP7594: DENEB, @@ -69,7 +69,7 @@ POST_FORK_OF = { ALTAIR: BELLATRIX, BELLATRIX: CAPELLA, CAPELLA: DENEB, - DENEB: EIP6110, + DENEB: ELECTRA, } ALL_PRE_POST_FORKS = POST_FORK_OF.items() diff --git a/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py b/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py index adec1d781..0d1269dda 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py +++ b/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py @@ -7,7 +7,7 @@ from eth2spec.debug.random_value import get_random_bytes_list from eth2spec.test.helpers.forks import ( is_post_capella, is_post_deneb, - is_post_eip6110, + is_post_electra, is_post_eip7002, ) @@ -34,7 +34,7 @@ def get_execution_payload_header(spec, execution_payload): if is_post_deneb(spec): payload_header.blob_gas_used = execution_payload.blob_gas_used payload_header.excess_blob_gas = execution_payload.excess_blob_gas - if is_post_eip6110(spec): + if is_post_electra(spec): payload_header.deposit_receipts_root = spec.hash_tree_root(execution_payload.deposit_receipts) if is_post_eip7002(spec): payload_header.exits_root = spec.hash_tree_root(execution_payload.exits) @@ -105,7 +105,7 @@ def compute_el_header_block_hash(spec, # excess_blob_gas execution_payload_header_rlp.append((big_endian_int, payload_header.blob_gas_used)) execution_payload_header_rlp.append((big_endian_int, payload_header.excess_blob_gas)) - if is_post_eip6110(spec): + if is_post_electra(spec): # deposit_receipts_root assert deposit_receipts_trie_root is not None execution_payload_header_rlp.append((Binary(32, 32), deposit_receipts_trie_root)) @@ -181,7 +181,7 @@ def compute_el_block_hash(spec, payload): if is_post_capella(spec): withdrawals_encoded = [get_withdrawal_rlp(withdrawal) for withdrawal in payload.withdrawals] withdrawals_trie_root = compute_trie_root_from_indexed_data(withdrawals_encoded) - if is_post_eip6110(spec): + if is_post_electra(spec): deposit_receipts_encoded = [get_deposit_receipt_rlp(spec, receipt) for receipt in payload.deposit_receipts] deposit_receipts_trie_root = compute_trie_root_from_indexed_data(deposit_receipts_encoded) if is_post_eip7002(spec): @@ -231,7 +231,7 @@ def build_empty_execution_payload(spec, state, randao_mix=None): if is_post_deneb(spec): payload.blob_gas_used = 0 payload.excess_blob_gas = 0 - if is_post_eip6110(spec): + if is_post_electra(spec): # just to be clear payload.deposit_receipts = [] diff --git a/tests/core/pyspec/eth2spec/test/helpers/forks.py b/tests/core/pyspec/eth2spec/test/helpers/forks.py index d58743a7d..17a4050bf 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/forks.py +++ b/tests/core/pyspec/eth2spec/test/helpers/forks.py @@ -1,6 +1,6 @@ from .constants import ( PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, - EIP6110, EIP7002, WHISK, + ELECTRA, EIP7002, WHISK, PREVIOUS_FORK_OF, ) @@ -37,8 +37,8 @@ def is_post_deneb(spec): return is_post_fork(spec.fork, DENEB) -def is_post_eip6110(spec): - return is_post_fork(spec.fork, EIP6110) +def is_post_electra(spec): + return is_post_fork(spec.fork, ELECTRA) def is_post_eip7002(spec): diff --git a/tests/core/pyspec/eth2spec/test/helpers/genesis.py b/tests/core/pyspec/eth2spec/test/helpers/genesis.py index ab8273f66..78f678825 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/genesis.py +++ b/tests/core/pyspec/eth2spec/test/helpers/genesis.py @@ -6,7 +6,7 @@ from eth2spec.test.helpers.execution_payload import ( compute_el_header_block_hash, ) from eth2spec.test.helpers.forks import ( - is_post_altair, is_post_bellatrix, is_post_capella, is_post_eip6110, is_post_eip7002, is_post_whisk, + is_post_altair, is_post_bellatrix, is_post_capella, is_post_electra, is_post_eip7002, is_post_whisk, ) from eth2spec.test.helpers.keys import pubkeys from eth2spec.test.helpers.whisk import compute_whisk_initial_tracker_cached, compute_whisk_initial_k_commitment_cached @@ -55,7 +55,7 @@ def get_sample_genesis_execution_payload_header(spec, if is_post_capella(spec): withdrawals_trie_root = bytes.fromhex("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421") - if is_post_eip6110(spec): + if is_post_electra(spec): deposit_receipts_trie_root = bytes.fromhex("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421") if is_post_eip7002(spec): exits_trie_root = bytes.fromhex("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421") @@ -134,7 +134,7 @@ def create_genesis_state(spec, validator_balances, activation_threshold): eth1_block_hash=eth1_block_hash, ) - if is_post_eip6110(spec): + if is_post_electra(spec): state.deposit_receipts_start_index = spec.UNSET_DEPOSIT_RECEIPTS_START_INDEX if is_post_whisk(spec): diff --git a/tests/formats/operations/README.md b/tests/formats/operations/README.md index ba764879b..8e9841618 100644 --- a/tests/formats/operations/README.md +++ b/tests/formats/operations/README.md @@ -45,7 +45,7 @@ Operations: | `execution_payload` | `BeaconBlockBody` | **`body`** | `process_execution_payload(state, body)` (new in Bellatrix) | | `withdrawals` | `ExecutionPayload` | `execution_payload` | `process_withdrawals(state, execution_payload)` (new in Capella) | | `bls_to_execution_change` | `SignedBLSToExecutionChange` | `address_change` | `process_bls_to_execution_change(state, address_change)` (new in Capella) | -| `deposit_receipt` | `DepositReceipt` | `deposit_receipt` | `process_deposit_receipt(state, deposit_receipt)` (new in EIP6110) | +| `deposit_receipt` | `DepositReceipt` | `deposit_receipt` | `process_deposit_receipt(state, deposit_receipt)` (new in Electra) | Note that `block_header` is not strictly an operation (and is a full `Block`), but processed in the same manner, and hence included here. diff --git a/tests/generators/epoch_processing/main.py b/tests/generators/epoch_processing/main.py index 63c2a548f..93e9a366c 100644 --- a/tests/generators/epoch_processing/main.py +++ b/tests/generators/epoch_processing/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators, combine_mods -from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -37,7 +37,7 @@ if __name__ == "__main__": ]} deneb_mods = combine_mods(_new_deneb_mods, capella_mods) - eip6110_mods = deneb_mods + electra_mods = deneb_mods # TODO Custody Game testgen is disabled for now # custody_game_mods = {**{key: 'eth2spec.test.custody_game.epoch_processing.test_process_' + key for key in [ @@ -52,7 +52,7 @@ if __name__ == "__main__": BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="epoch_processing", all_mods=all_mods) diff --git a/tests/generators/finality/main.py b/tests/generators/finality/main.py index 15c6cad8d..6d33ae6bd 100644 --- a/tests/generators/finality/main.py +++ b/tests/generators/finality/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators -from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -8,7 +8,7 @@ if __name__ == "__main__": bellatrix_mods = altair_mods # No additional Bellatrix specific finality tests capella_mods = bellatrix_mods # No additional Capella specific finality tests deneb_mods = capella_mods # No additional Deneb specific finality tests - eip6110_mods = deneb_mods # No additional EIP6110 specific finality tests + electra_mods = deneb_mods # No additional Electra specific finality tests all_mods = { PHASE0: phase_0_mods, @@ -16,7 +16,7 @@ if __name__ == "__main__": BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="finality", all_mods=all_mods) diff --git a/tests/generators/fork_choice/main.py b/tests/generators/fork_choice/main.py index df117ccd1..92c67e4c0 100644 --- a/tests/generators/fork_choice/main.py +++ b/tests/generators/fork_choice/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators, combine_mods -from eth2spec.test.helpers.constants import ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -28,14 +28,14 @@ if __name__ == "__main__": ]} deneb_mods = combine_mods(_new_deneb_mods, capella_mods) - eip6110_mods = deneb_mods # No additional EIP6110 specific fork choice tests + electra_mods = deneb_mods # No additional Electra specific fork choice tests all_mods = { ALTAIR: altair_mods, BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="fork_choice", all_mods=all_mods) diff --git a/tests/generators/genesis/main.py b/tests/generators/genesis/main.py index feffde8e3..57b680eba 100644 --- a/tests/generators/genesis/main.py +++ b/tests/generators/genesis/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators, combine_mods -from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -17,14 +17,14 @@ if __name__ == "__main__": bellatrix_mods = combine_mods(_new_bellatrix_mods, altair_mods) capella_mods = bellatrix_mods # No additional Capella specific genesis tests deneb_mods = capella_mods # No additional Deneb specific genesis tests - eip6110_mods = deneb_mods # No additional EIP6110 specific genesis tests + electra_mods = deneb_mods # No additional Electra specific genesis tests all_mods = { PHASE0: phase_0_mods, ALTAIR: altair_mods, BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="genesis", all_mods=all_mods) diff --git a/tests/generators/operations/main.py b/tests/generators/operations/main.py index 053236c8d..c31a72285 100644 --- a/tests/generators/operations/main.py +++ b/tests/generators/operations/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators, combine_mods -from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -43,10 +43,10 @@ if __name__ == "__main__": ]} deneb_mods = combine_mods(_new_deneb_mods, capella_mods) - _new_eip6110_mods = {key: 'eth2spec.test.eip6110.block_processing.test_process_' + key for key in [ + _new_electra_mods = {key: 'eth2spec.test.electra.block_processing.test_process_' + key for key in [ 'deposit_receipt', ]} - eip6110_mods = combine_mods(_new_eip6110_mods, deneb_mods) + electra_mods = combine_mods(_new_electra_mods, deneb_mods) # TODO Custody Game testgen is disabled for now # _new_custody_game_mods = {key: 'eth2spec.test.custody_game.block_processing.test_process_' + key for key in [ @@ -64,7 +64,7 @@ if __name__ == "__main__": BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="operations", all_mods=all_mods) diff --git a/tests/generators/rewards/main.py b/tests/generators/rewards/main.py index d01d4a424..dcf2c6ce2 100644 --- a/tests/generators/rewards/main.py +++ b/tests/generators/rewards/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators -from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -17,7 +17,7 @@ if __name__ == "__main__": bellatrix_mods = altair_mods capella_mods = bellatrix_mods deneb_mods = capella_mods - eip6110_mods = deneb_mods + electra_mods = deneb_mods all_mods = { PHASE0: phase_0_mods, @@ -25,7 +25,7 @@ if __name__ == "__main__": BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="rewards", all_mods=all_mods) diff --git a/tests/generators/sanity/main.py b/tests/generators/sanity/main.py index b9f6d7fbb..f2485eef5 100644 --- a/tests/generators/sanity/main.py +++ b/tests/generators/sanity/main.py @@ -1,4 +1,4 @@ -from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators, combine_mods @@ -28,10 +28,10 @@ if __name__ == "__main__": ]} deneb_mods = combine_mods(_new_deneb_mods, capella_mods) - _new_eip6110_mods = {key: 'eth2spec.test.eip6110.sanity.' + key for key in [ + _new_electra_mods = {key: 'eth2spec.test.electra.sanity.' + key for key in [ 'blocks', ]} - eip6110_mods = combine_mods(_new_eip6110_mods, deneb_mods) + electra_mods = combine_mods(_new_electra_mods, deneb_mods) all_mods = { PHASE0: phase_0_mods, @@ -39,7 +39,7 @@ if __name__ == "__main__": BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="sanity", all_mods=all_mods) diff --git a/tests/generators/sync/main.py b/tests/generators/sync/main.py index 5563e6f8c..94e392b77 100644 --- a/tests/generators/sync/main.py +++ b/tests/generators/sync/main.py @@ -1,5 +1,5 @@ from eth2spec.gen_helpers.gen_from_tests.gen import run_state_test_generators -from eth2spec.test.helpers.constants import BELLATRIX, CAPELLA, DENEB, EIP6110 +from eth2spec.test.helpers.constants import BELLATRIX, CAPELLA, DENEB, ELECTRA if __name__ == "__main__": @@ -8,13 +8,13 @@ if __name__ == "__main__": ]} capella_mods = bellatrix_mods deneb_mods = capella_mods - eip6110_mods = deneb_mods + electra_mods = deneb_mods all_mods = { BELLATRIX: bellatrix_mods, CAPELLA: capella_mods, DENEB: deneb_mods, - EIP6110: eip6110_mods, + ELECTRA: electra_mods, } run_state_test_generators(runner_name="sync", all_mods=all_mods) From 82271d122950341f9421cf0fac4a6a1d21a14d17 Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Wed, 6 Mar 2024 14:00:55 +0800 Subject: [PATCH 02/25] EIP6110 meta update --- README.md | 2 +- specs/deneb/beacon-chain.md | 2 -- specs/electra/beacon-chain.md | 50 +++++++++++++++++++---------------- specs/electra/fork.md | 20 +++++++------- specs/electra/validator.md | 8 +++--- 5 files changed, 42 insertions(+), 40 deletions(-) diff --git a/README.md b/README.md index e59e09612..58bff5b9e 100644 --- a/README.md +++ b/README.md @@ -26,10 +26,10 @@ Features are researched and developed in parallel, and then consolidated into se ### In-development Specifications | Code Name or Topic | Specs | Notes | | - | - | - | +| Electra | | | Sharding (outdated) | | | Custody Game (outdated) | | Dependent on sharding | | Data Availability Sampling (outdated) | | | -| EIP-6110 | | ### Accompanying documents can be found in [specs](specs) and include: diff --git a/specs/deneb/beacon-chain.md b/specs/deneb/beacon-chain.md index b6c97d6f4..fce8f354c 100644 --- a/specs/deneb/beacon-chain.md +++ b/specs/deneb/beacon-chain.md @@ -1,7 +1,5 @@ # Deneb -- The Beacon Chain -**Notice**: This document is a work-in-progress for researchers and implementers. - ## Table of contents diff --git a/specs/electra/beacon-chain.md b/specs/electra/beacon-chain.md index 4351c7482..34b8b4b45 100644 --- a/specs/electra/beacon-chain.md +++ b/specs/electra/beacon-chain.md @@ -1,4 +1,6 @@ -# EIP-6110 -- The Beacon Chain +# Electra -- The Beacon Chain + +**Notice**: This document is a work-in-progress for researchers and implementers. ## Table of contents @@ -30,10 +32,8 @@ ## Introduction -This is the beacon chain specification of in-protocol deposits processing mechanism. -This mechanism relies on the changes proposed by [EIP-6110](http://eips.ethereum.org/EIPS/eip-6110). - -*Note:* This specification is built upon [Deneb](../../deneb/beacon-chain.md) and is under active development. +Electra is a consensus-layer upgrade containing a number of features. Including: +* [EIP-6110](https://eips.ethereum.org/EIPS/eip-6110): Supply validator deposits on chain ## Constants @@ -41,9 +41,9 @@ The following values are (non-configurable) constants used throughout the specif ### Misc -| Name | Value | -| - | - | -| `UNSET_DEPOSIT_RECEIPTS_START_INDEX` | `uint64(2**64 - 1)` | +| Name | Value | Description | +| - | - | - | +| `UNSET_DEPOSIT_RECEIPTS_START_INDEX` | `uint64(2**64 - 1)` | *[New in Electra:EIP6110]* | ## Preset @@ -51,7 +51,7 @@ The following values are (non-configurable) constants used throughout the specif | Name | Value | Description | | - | - | - | -| `MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD` | `uint64(2**13)` (= 8,192) | Maximum number of deposit receipts allowed in each payload | +| `MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD` | `uint64(2**13)` (= 8,192) | *[New in Electra:EIP6110]* Maximum number of deposit receipts allowed in each payload | ## Containers @@ -59,6 +59,8 @@ The following values are (non-configurable) constants used throughout the specif #### `DepositReceipt` +*Note*: The container is new in EIP6110. + ```python class DepositReceipt(Container): pubkey: BLSPubkey @@ -93,7 +95,7 @@ class ExecutionPayload(Container): withdrawals: List[Withdrawal, MAX_WITHDRAWALS_PER_PAYLOAD] blob_gas_used: uint64 excess_blob_gas: uint64 - deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD] # [New in EIP6110] + deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD] # [New in Electra:EIP6110] ``` #### `ExecutionPayloadHeader` @@ -119,7 +121,7 @@ class ExecutionPayloadHeader(Container): withdrawals_root: Root blob_gas_used: uint64 excess_blob_gas: uint64 - deposit_receipts_root: Root # [New in EIP6110] + deposit_receipts_root: Root # [New in Electra:EIP6110] ``` #### `BeaconState` @@ -161,13 +163,13 @@ class BeaconState(Container): current_sync_committee: SyncCommittee next_sync_committee: SyncCommittee # Execution - latest_execution_payload_header: ExecutionPayloadHeader # [Modified in EIP6110] + latest_execution_payload_header: ExecutionPayloadHeader # [Modified in Electra:EIP6110] # Withdrawals next_withdrawal_index: WithdrawalIndex next_withdrawal_validator_index: ValidatorIndex # Deep history valid from Capella onwards historical_summaries: List[HistoricalSummary, HISTORICAL_ROOTS_LIMIT] - # [New in EIP6110] + # [New in Electra:EIP6110] deposit_receipts_start_index: uint64 ``` @@ -179,10 +181,10 @@ class BeaconState(Container): def process_block(state: BeaconState, block: BeaconBlock) -> None: process_block_header(state, block) process_withdrawals(state, block.body.execution_payload) - process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in EIP6110] + process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Electra:EIP6110] process_randao(state, block.body) process_eth1_data(state, block.body) - process_operations(state, block.body) # [Modified in EIP6110] + process_operations(state, block.body) # [Modified in Electra:EIP6110] process_sync_aggregate(state, block.body.sync_aggregate) ``` @@ -192,7 +194,7 @@ def process_block(state: BeaconState, block: BeaconBlock) -> None: ```python def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: - # [Modified in EIP6110] + # [Modified in Electra:EIP6110] # Disable former deposit mechanism once all prior deposits are processed eth1_deposit_index_limit = min(state.eth1_data.deposit_count, state.deposit_receipts_start_index) if state.eth1_deposit_index < eth1_deposit_index_limit: @@ -217,6 +219,8 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: #### New `process_deposit_receipt` +*Note*: This function is new in Electra:EIP6110. + ```python def process_deposit_receipt(state: BeaconState, deposit_receipt: DepositReceipt) -> None: # Set deposit receipt start index @@ -276,17 +280,17 @@ def process_execution_payload(state: BeaconState, body: BeaconBlockBody, executi withdrawals_root=hash_tree_root(payload.withdrawals), blob_gas_used=payload.blob_gas_used, excess_blob_gas=payload.excess_blob_gas, - deposit_receipts_root=hash_tree_root(payload.deposit_receipts), # [New in EIP6110] + deposit_receipts_root=hash_tree_root(payload.deposit_receipts), # [New in Electra:EIP6110] ) ``` ## Testing -*Note*: The function `initialize_beacon_state_from_eth1` is modified for pure EIP-6110 testing only. +*Note*: The function `initialize_beacon_state_from_eth1` is modified for pure Electra testing only. Modifications include: 1. Use `ELECTRA_FORK_VERSION` as the previous and current fork version. -2. Utilize the EIP-6110 `BeaconBlockBody` when constructing the initial `latest_block_header`. -3. Add `deposit_receipts_start_index` variable to the genesis state initialization. +2. Utilize the Electra `BeaconBlockBody` when constructing the initial `latest_block_header`. +3. *[New in Electra:EIP6110]* Add `deposit_receipts_start_index` variable to the genesis state initialization. ```python def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, @@ -295,8 +299,8 @@ def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, execution_payload_header: ExecutionPayloadHeader=ExecutionPayloadHeader() ) -> BeaconState: fork = Fork( - previous_version=ELECTRA_FORK_VERSION, # [Modified in EIP6110] for testing only - current_version=ELECTRA_FORK_VERSION, # [Modified in EIP6110] + previous_version=ELECTRA_FORK_VERSION, # [Modified in Electra:EIP6110] for testing only + current_version=ELECTRA_FORK_VERSION, # [Modified in Electra:EIP6110] epoch=GENESIS_EPOCH, ) state = BeaconState( @@ -305,7 +309,7 @@ def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, eth1_data=Eth1Data(block_hash=eth1_block_hash, deposit_count=uint64(len(deposits))), latest_block_header=BeaconBlockHeader(body_root=hash_tree_root(BeaconBlockBody())), randao_mixes=[eth1_block_hash] * EPOCHS_PER_HISTORICAL_VECTOR, # Seed RANDAO with Eth1 entropy - deposit_receipts_start_index=UNSET_DEPOSIT_RECEIPTS_START_INDEX, # [New in EIP6110] + deposit_receipts_start_index=UNSET_DEPOSIT_RECEIPTS_START_INDEX, # [New in Electra:EIP6110] ) # Process deposits diff --git a/specs/electra/fork.md b/specs/electra/fork.md index a592f1c5e..f93ef03df 100644 --- a/specs/electra/fork.md +++ b/specs/electra/fork.md @@ -1,4 +1,4 @@ -# EIP-6110 -- Fork Logic +# Electra -- Fork Logic **Notice**: This document is a work-in-progress for researchers and implementers. @@ -12,7 +12,7 @@ - [Helper functions](#helper-functions) - [Misc](#misc) - [Modified `compute_fork_version`](#modified-compute_fork_version) -- [Fork to EIP-6110](#fork-to-eip-6110) +- [Fork to Electra](#fork-to-electra) - [Fork trigger](#fork-trigger) - [Upgrading the state](#upgrading-the-state) @@ -55,19 +55,19 @@ def compute_fork_version(epoch: Epoch) -> Version: return GENESIS_FORK_VERSION ``` -## Fork to EIP-6110 +## Fork to Electra ### Fork trigger TBD. This fork is defined for testing purposes, the EIP may be combined with other consensus-layer upgrade. For now, we assume the condition will be triggered at epoch `ELECTRA_FORK_EPOCH`. -Note that for the pure EIP-6110 networks, we don't apply `upgrade_to_electra` since it starts with EIP-6110 version logic. +Note that for the pure Electra networks, we don't apply `upgrade_to_electra` since it starts with Electra version logic. ### Upgrading the state If `state.slot % SLOTS_PER_EPOCH == 0` and `compute_epoch_at_slot(state.slot) == ELECTRA_FORK_EPOCH`, -an irregular state change is made to upgrade to EIP-6110. +an irregular state change is made to upgrade to Electra. ```python def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: @@ -90,7 +90,7 @@ def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: withdrawals_root=pre.latest_execution_payload_header.withdrawals_root, blob_gas_used=uint64(0), excess_blob_gas=uint64(0), - deposit_receipts_root=Root(), # [New in EIP-6110] + deposit_receipts_root=Root(), # [New in Electra:EIP6110] ) post = BeaconState( # Versioning @@ -99,7 +99,7 @@ def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: slot=pre.slot, fork=Fork( previous_version=pre.fork.current_version, - current_version=ELECTRA_FORK_VERSION, # [Modified in EIP-6110] + current_version=ELECTRA_FORK_VERSION, # [Modified in Electra:EIP6110] epoch=epoch, ), # History @@ -132,14 +132,14 @@ def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: current_sync_committee=pre.current_sync_committee, next_sync_committee=pre.next_sync_committee, # Execution-layer - latest_execution_payload_header=latest_execution_payload_header, # [Modified in EIP-6110] + latest_execution_payload_header=latest_execution_payload_header, # [Modified in Electra:EIP6110] # Withdrawals next_withdrawal_index=pre.next_withdrawal_index, next_withdrawal_validator_index=pre.next_withdrawal_validator_index, # Deep history valid from Capella onwards historical_summaries=pre.historical_summaries, - # EIP-6110 - deposit_receipts_start_index=UNSET_DEPOSIT_RECEIPTS_START_INDEX, # [New in EIP-6110] + # EIP6110 + deposit_receipts_start_index=UNSET_DEPOSIT_RECEIPTS_START_INDEX, # [New in Electra:EIP6110] ) return post diff --git a/specs/electra/validator.md b/specs/electra/validator.md index 6770ef56a..d2eeb1e01 100644 --- a/specs/electra/validator.md +++ b/specs/electra/validator.md @@ -1,4 +1,4 @@ -# EIP-6110 -- Honest Validator +# Electra -- Honest Validator ## Table of contents @@ -16,21 +16,21 @@ ## Introduction -This document represents the changes to be made in the code of an "honest validator" to implement EIP-6110. +This document represents the changes to be made in the code of an "honest validator" to implement Electra. ## Prerequisites This document is an extension of the [Deneb -- Honest Validator](../../deneb/validator.md) guide. All behaviors and definitions defined in this document, and documents it extends, carry over unless explicitly noted or overridden. -All terminology, constants, functions, and protocol mechanics defined in the updated Beacon Chain doc of [EIP-6110](./beacon-chain.md) are requisite for this document and used throughout. +All terminology, constants, functions, and protocol mechanics defined in the updated Beacon Chain doc of [Electra](./beacon-chain.md) are requisite for this document and used throughout. Please see related Beacon Chain doc before continuing and use them as a reference throughout. ## Block proposal ### Deposits -The expected number of deposits MUST be changed from `min(MAX_DEPOSITS, eth1_data.deposit_count - state.eth1_deposit_index)` to the result of the following function: +*[New in Electra:EIP6110* The expected number of deposits MUST be changed from `min(MAX_DEPOSITS, eth1_data.deposit_count - state.eth1_deposit_index)` to the result of the following function: ```python def get_eth1_deposit_count(state: BeaconState) -> uint64: From ec9bbfa2ea8bc8c32b1f0a54ea4de0e2fd9f01b9 Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Wed, 6 Mar 2024 14:23:23 +0800 Subject: [PATCH 03/25] Merge EIP7002 into Electra --- .circleci/config.yml | 16 - .github/workflows/run-tests.yml | 2 +- .gitignore | 1 - Makefile | 2 +- configs/mainnet.yaml | 3 - configs/minimal.yaml | 3 - presets/mainnet/electra.yaml | 2 + presets/minimal/electra.yaml | 2 + pysetup/constants.py | 1 - pysetup/md_doc_paths.py | 2 - pysetup/spec_builders/__init__.py | 3 +- specs/_features/eip7002/beacon-chain.md | 300 ------------------ specs/_features/eip7002/fork.md | 140 -------- specs/electra/beacon-chain.md | 51 ++- specs/electra/fork.md | 3 +- tests/core/pyspec/eth2spec/test/context.py | 3 +- .../test_process_execution_layer_exit.py | 12 +- .../sanity/blocks}/test_blocks.py | 10 +- .../pyspec/eth2spec/test/helpers/constants.py | 3 - .../test/helpers/execution_payload.py | 4 - .../pyspec/eth2spec/test/helpers/forks.py | 6 +- .../pyspec/eth2spec/test/helpers/genesis.py | 3 +- 22 files changed, 72 insertions(+), 500 deletions(-) delete mode 100644 specs/_features/eip7002/beacon-chain.md delete mode 100644 specs/_features/eip7002/fork.md rename tests/core/pyspec/eth2spec/test/{eip7002 => electra}/block_processing/test_process_execution_layer_exit.py (95%) rename tests/core/pyspec/eth2spec/test/{eip7002/sanity => electra/sanity/blocks}/test_blocks.py (98%) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4a29702e5..6c20422cd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -168,19 +168,6 @@ jobs: command: make citest fork=electra - store_test_results: path: tests/core/pyspec/test-reports - test-eip7002: - docker: - - image: circleci/python:3.9 - working_directory: ~/specs-repo - steps: - - restore_cache: - key: v3-specs-repo-{{ .Branch }}-{{ .Revision }} - - restore_pyspec_cached_venv - - run: - name: Run py-tests - command: make citest fork=eip7002 - - store_test_results: - path: tests/core/pyspec/test-reports test-whisk: docker: - image: circleci/python:3.9 @@ -330,9 +317,6 @@ workflows: - test-electra: requires: - install_pyspec_test - - test-eip7002: - requires: - - install_pyspec_test - test-whisk: requires: - install_pyspec_test diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index e83968979..4613e6d2d 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -71,7 +71,7 @@ jobs: needs: [preclear,lint,codespell,table_of_contents] strategy: matrix: - version: ["phase0", "altair", "bellatrix", "capella", "deneb", "electra", "eip7002", "whisk", "eip7594"] + version: ["phase0", "altair", "bellatrix", "capella", "deneb", "electra", "whisk", "eip7594"] steps: - name: Checkout this repo uses: actions/checkout@v3.2.0 diff --git a/.gitignore b/.gitignore index f3d9881cb..3e4413e97 100644 --- a/.gitignore +++ b/.gitignore @@ -22,7 +22,6 @@ tests/core/pyspec/eth2spec/bellatrix/ tests/core/pyspec/eth2spec/capella/ tests/core/pyspec/eth2spec/deneb/ tests/core/pyspec/eth2spec/electra/ -tests/core/pyspec/eth2spec/eip7002/ tests/core/pyspec/eth2spec/whisk/ tests/core/pyspec/eth2spec/eip7594/ diff --git a/Makefile b/Makefile index 5cd022669..d177e7b31 100644 --- a/Makefile +++ b/Makefile @@ -35,7 +35,7 @@ MARKDOWN_FILES = $(wildcard $(SPEC_DIR)/*/*.md) \ $(wildcard $(SPEC_DIR)/_features/*/*/*.md) \ $(wildcard $(SSZ_DIR)/*.md) -ALL_EXECUTABLE_SPEC_NAMES = phase0 altair bellatrix capella deneb electra eip7002 whisk +ALL_EXECUTABLE_SPEC_NAMES = phase0 altair bellatrix capella deneb electra whisk # The parameters for commands. Use `foreach` to avoid listing specs again. COVERAGE_SCOPE := $(foreach S,$(ALL_EXECUTABLE_SPEC_NAMES), --cov=eth2spec.$S.$(TEST_PRESET_TYPE)) PYLINT_SCOPE := $(foreach S,$(ALL_EXECUTABLE_SPEC_NAMES), ./eth2spec/$S) diff --git a/configs/mainnet.yaml b/configs/mainnet.yaml index f3bf4327a..2b264aa4e 100644 --- a/configs/mainnet.yaml +++ b/configs/mainnet.yaml @@ -53,9 +53,6 @@ DENEB_FORK_EPOCH: 269568 # March 13, 2024, 01:55:35pm UTC # Electra ELECTRA_FORK_VERSION: 0x05000000 # temporary stub ELECTRA_FORK_EPOCH: 18446744073709551615 -# EIP7002 -EIP7002_FORK_VERSION: 0x05000000 # temporary stub -EIP7002_FORK_EPOCH: 18446744073709551615 # WHISK WHISK_FORK_VERSION: 0x06000000 # temporary stub WHISK_FORK_EPOCH: 18446744073709551615 diff --git a/configs/minimal.yaml b/configs/minimal.yaml index 2992881b1..ccf3ff6e2 100644 --- a/configs/minimal.yaml +++ b/configs/minimal.yaml @@ -52,9 +52,6 @@ DENEB_FORK_EPOCH: 18446744073709551615 # ELECTRA ELECTRA_FORK_VERSION: 0x05000001 ELECTRA_FORK_EPOCH: 18446744073709551615 -# EIP7002 -EIP7002_FORK_VERSION: 0x05000001 -EIP7002_FORK_EPOCH: 18446744073709551615 # WHISK WHISK_FORK_VERSION: 0x06000001 WHISK_FORK_EPOCH: 18446744073709551615 diff --git a/presets/mainnet/electra.yaml b/presets/mainnet/electra.yaml index 1f64c2332..badb4e95d 100644 --- a/presets/mainnet/electra.yaml +++ b/presets/mainnet/electra.yaml @@ -4,3 +4,5 @@ # --------------------------------------------------------------- # 2**13 (= 8192) receipts MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD: 8192 +# 2**4 (= 16) exits +MAX_EXECUTION_LAYER_EXITS: 16 diff --git a/presets/minimal/electra.yaml b/presets/minimal/electra.yaml index 75664afa5..5c359728b 100644 --- a/presets/minimal/electra.yaml +++ b/presets/minimal/electra.yaml @@ -4,3 +4,5 @@ # --------------------------------------------------------------- # [customized] MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD: 4 +# 2**4 (= 16) exits +MAX_EXECUTION_LAYER_EXITS: 16 diff --git a/pysetup/constants.py b/pysetup/constants.py index d017d8c01..c374566bf 100644 --- a/pysetup/constants.py +++ b/pysetup/constants.py @@ -5,7 +5,6 @@ BELLATRIX = 'bellatrix' CAPELLA = 'capella' DENEB = 'deneb' ELECTRA = 'electra' -EIP7002 = 'eip7002' WHISK = 'whisk' EIP7594 = 'eip7594' diff --git a/pysetup/md_doc_paths.py b/pysetup/md_doc_paths.py index d8465f233..5beb1ae65 100644 --- a/pysetup/md_doc_paths.py +++ b/pysetup/md_doc_paths.py @@ -8,7 +8,6 @@ from .constants import ( DENEB, ELECTRA, WHISK, - EIP7002, EIP7594, ) @@ -21,7 +20,6 @@ PREVIOUS_FORK_OF = { DENEB: CAPELLA, ELECTRA: DENEB, WHISK: CAPELLA, - EIP7002: CAPELLA, EIP7594: DENEB, } diff --git a/pysetup/spec_builders/__init__.py b/pysetup/spec_builders/__init__.py index 0a6cfcc43..ea74b50b7 100644 --- a/pysetup/spec_builders/__init__.py +++ b/pysetup/spec_builders/__init__.py @@ -4,7 +4,6 @@ from .bellatrix import BellatrixSpecBuilder from .capella import CapellaSpecBuilder from .deneb import DenebSpecBuilder from .electra import ElectraSpecBuilder -from .eip7002 import EIP7002SpecBuilder from .whisk import WhiskSpecBuilder from .eip7594 import EIP7594SpecBuilder @@ -13,6 +12,6 @@ spec_builders = { builder.fork: builder for builder in ( Phase0SpecBuilder, AltairSpecBuilder, BellatrixSpecBuilder, CapellaSpecBuilder, DenebSpecBuilder, - ElectraSpecBuilder, EIP7002SpecBuilder, WhiskSpecBuilder, EIP7594SpecBuilder, + ElectraSpecBuilder, WhiskSpecBuilder, EIP7594SpecBuilder, ) } diff --git a/specs/_features/eip7002/beacon-chain.md b/specs/_features/eip7002/beacon-chain.md deleted file mode 100644 index 39b03e878..000000000 --- a/specs/_features/eip7002/beacon-chain.md +++ /dev/null @@ -1,300 +0,0 @@ -# EIP-7002 -- The Beacon Chain - -## Table of contents - - - - - -- [Introduction](#introduction) -- [Preset](#preset) - - [Max operations per block](#max-operations-per-block) -- [Containers](#containers) - - [New containers](#new-containers) - - [`ExecutionLayerExit`](#executionlayerexit) - - [Extended Containers](#extended-containers) - - [`ExecutionPayload`](#executionpayload) - - [`ExecutionPayloadHeader`](#executionpayloadheader) - - [`BeaconState`](#beaconstate) -- [Beacon chain state transition function](#beacon-chain-state-transition-function) - - [Block processing](#block-processing) - - [Execution payload](#execution-payload) - - [Modified `process_execution_payload`](#modified-process_execution_payload) - - [Operations](#operations) - - [Modified `process_operations`](#modified-process_operations) - - [New `process_execution_layer_exit`](#new-process_execution_layer_exit) -- [Testing](#testing) - - - - -## Introduction - -This is the beacon chain specification of the execution layer triggerable exits feature. - -This mechanism relies on the changes proposed by [EIP-7002](http://eips.ethereum.org/EIPS/eip-7002). - -*Note:* This specification is built upon [Capella](../../capella/beacon-chain.md) and is under active development. - -## Preset - -### Max operations per block - -| Name | Value | -| - | - | -| `MAX_EXECUTION_LAYER_EXITS` | `2**4` (= 16) | - -## Containers - -### New containers - -#### `ExecutionLayerExit` - -```python -class ExecutionLayerExit(Container): - source_address: ExecutionAddress - validator_pubkey: BLSPubkey -``` - -### Extended Containers - -#### `ExecutionPayload` - -```python -class ExecutionPayload(Container): - # Execution block header fields - parent_hash: Hash32 - fee_recipient: ExecutionAddress - state_root: Bytes32 - receipts_root: Bytes32 - logs_bloom: ByteVector[BYTES_PER_LOGS_BLOOM] - prev_randao: Bytes32 - block_number: uint64 - gas_limit: uint64 - gas_used: uint64 - timestamp: uint64 - extra_data: ByteList[MAX_EXTRA_DATA_BYTES] - base_fee_per_gas: uint256 - # Extra payload fields - block_hash: Hash32 - transactions: List[Transaction, MAX_TRANSACTIONS_PER_PAYLOAD] - withdrawals: List[Withdrawal, MAX_WITHDRAWALS_PER_PAYLOAD] - exits: List[ExecutionLayerExit, MAX_EXECUTION_LAYER_EXITS] # [New in EIP7002] -``` - -#### `ExecutionPayloadHeader` - -```python -class ExecutionPayloadHeader(Container): - # Execution block header fields - parent_hash: Hash32 - fee_recipient: ExecutionAddress - state_root: Bytes32 - receipts_root: Bytes32 - logs_bloom: ByteVector[BYTES_PER_LOGS_BLOOM] - prev_randao: Bytes32 - block_number: uint64 - gas_limit: uint64 - gas_used: uint64 - timestamp: uint64 - extra_data: ByteList[MAX_EXTRA_DATA_BYTES] - base_fee_per_gas: uint256 - # Extra payload fields - block_hash: Hash32 - transactions_root: Root - withdrawals_root: Root - exits_root: Root # [New in EIP7002] -``` - -#### `BeaconState` - -```python -class BeaconState(Container): - # Versioning - genesis_time: uint64 - genesis_validators_root: Root - slot: Slot - fork: Fork - # History - latest_block_header: BeaconBlockHeader - block_roots: Vector[Root, SLOTS_PER_HISTORICAL_ROOT] - state_roots: Vector[Root, SLOTS_PER_HISTORICAL_ROOT] - historical_roots: List[Root, HISTORICAL_ROOTS_LIMIT] - # Eth1 - eth1_data: Eth1Data - eth1_data_votes: List[Eth1Data, EPOCHS_PER_ETH1_VOTING_PERIOD * SLOTS_PER_EPOCH] - eth1_deposit_index: uint64 - # Registry - validators: List[Validator, VALIDATOR_REGISTRY_LIMIT] - balances: List[Gwei, VALIDATOR_REGISTRY_LIMIT] - # Randomness - randao_mixes: Vector[Bytes32, EPOCHS_PER_HISTORICAL_VECTOR] - # Slashings - slashings: Vector[Gwei, EPOCHS_PER_SLASHINGS_VECTOR] # Per-epoch sums of slashed effective balances - # Participation - previous_epoch_participation: List[ParticipationFlags, VALIDATOR_REGISTRY_LIMIT] - current_epoch_participation: List[ParticipationFlags, VALIDATOR_REGISTRY_LIMIT] - # Finality - justification_bits: Bitvector[JUSTIFICATION_BITS_LENGTH] # Bit set for every recent justified epoch - previous_justified_checkpoint: Checkpoint - current_justified_checkpoint: Checkpoint - finalized_checkpoint: Checkpoint - # Inactivity - inactivity_scores: List[uint64, VALIDATOR_REGISTRY_LIMIT] - # Sync - current_sync_committee: SyncCommittee - next_sync_committee: SyncCommittee - # Execution - latest_execution_payload_header: ExecutionPayloadHeader # [Modified in EIP7002] - # Withdrawals - next_withdrawal_index: WithdrawalIndex - next_withdrawal_validator_index: ValidatorIndex - # Deep history valid from Capella onwards - historical_summaries: List[HistoricalSummary, HISTORICAL_ROOTS_LIMIT] -``` - -## Beacon chain state transition function - -### Block processing - -#### Execution payload - -##### Modified `process_execution_payload` - -```python -def process_execution_payload(state: BeaconState, body: BeaconBlockBody, execution_engine: ExecutionEngine) -> None: - payload = body.execution_payload - # Verify consistency of the parent hash with respect to the previous execution payload header - assert payload.parent_hash == state.latest_execution_payload_header.block_hash - # Verify prev_randao - assert payload.prev_randao == get_randao_mix(state, get_current_epoch(state)) - # Verify timestamp - assert payload.timestamp == compute_timestamp_at_slot(state, state.slot) - # Verify the execution payload is valid - assert execution_engine.verify_and_notify_new_payload(NewPayloadRequest(execution_payload=payload)) - # Cache execution payload header - state.latest_execution_payload_header = ExecutionPayloadHeader( - parent_hash=payload.parent_hash, - fee_recipient=payload.fee_recipient, - state_root=payload.state_root, - receipts_root=payload.receipts_root, - logs_bloom=payload.logs_bloom, - prev_randao=payload.prev_randao, - block_number=payload.block_number, - gas_limit=payload.gas_limit, - gas_used=payload.gas_used, - timestamp=payload.timestamp, - extra_data=payload.extra_data, - base_fee_per_gas=payload.base_fee_per_gas, - block_hash=payload.block_hash, - transactions_root=hash_tree_root(payload.transactions), - withdrawals_root=hash_tree_root(payload.withdrawals), - exits_root=hash_tree_root(payload.exits), # [New in EIP7002] - ) -``` - -#### Operations - -##### Modified `process_operations` - -*Note*: The function `process_operations` is modified to process `ExecutionLayerExit` operations included in the block. - -```python -def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: - # Verify that outstanding deposits are processed up to the maximum number of deposits - assert len(body.deposits) == min(MAX_DEPOSITS, state.eth1_data.deposit_count - state.eth1_deposit_index) - - def for_ops(operations: Sequence[Any], fn: Callable[[BeaconState, Any], None]) -> None: - for operation in operations: - fn(state, operation) - - for_ops(body.proposer_slashings, process_proposer_slashing) - for_ops(body.attester_slashings, process_attester_slashing) - for_ops(body.attestations, process_attestation) - for_ops(body.deposits, process_deposit) - for_ops(body.voluntary_exits, process_voluntary_exit) - for_ops(body.execution_payload.exits, process_execution_layer_exit) # [New in EIP7002] - for_ops(body.bls_to_execution_changes, process_bls_to_execution_change) -``` - -##### New `process_execution_layer_exit` - -```python -def process_execution_layer_exit(state: BeaconState, execution_layer_exit: ExecutionLayerExit) -> None: - validator_pubkeys = [v.pubkey for v in state.validators] - validator_index = ValidatorIndex(validator_pubkeys.index(execution_layer_exit.validator_pubkey)) - validator = state.validators[validator_index] - - # Verify withdrawal credentials - is_execution_address = validator.withdrawal_credentials[:1] == ETH1_ADDRESS_WITHDRAWAL_PREFIX - is_correct_source_address = validator.withdrawal_credentials[12:] == execution_layer_exit.source_address - if not (is_execution_address and is_correct_source_address): - return - # Verify the validator is active - if not is_active_validator(validator, get_current_epoch(state)): - return - # Verify exit has not been initiated - if validator.exit_epoch != FAR_FUTURE_EPOCH: - return - # Verify the validator has been active long enough - if get_current_epoch(state) < validator.activation_epoch + SHARD_COMMITTEE_PERIOD: - return - - # Initiate exit - initiate_validator_exit(state, validator_index) -``` - -## Testing - -*Note*: The function `initialize_beacon_state_from_eth1` is modified for pure EIP-7002 testing only. -Modifications include: -1. Use `EIP7002_FORK_VERSION` as the previous and current fork version. -2. Utilize the EIP-7002 `BeaconBlockBody` when constructing the initial `latest_block_header`. - -```python -def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, - eth1_timestamp: uint64, - deposits: Sequence[Deposit], - execution_payload_header: ExecutionPayloadHeader=ExecutionPayloadHeader() - ) -> BeaconState: - fork = Fork( - previous_version=EIP7002_FORK_VERSION, # [Modified in EIP7002] for testing only - current_version=EIP7002_FORK_VERSION, # [Modified in EIP7002] - epoch=GENESIS_EPOCH, - ) - state = BeaconState( - genesis_time=eth1_timestamp + GENESIS_DELAY, - fork=fork, - eth1_data=Eth1Data(block_hash=eth1_block_hash, deposit_count=uint64(len(deposits))), - latest_block_header=BeaconBlockHeader(body_root=hash_tree_root(BeaconBlockBody())), - randao_mixes=[eth1_block_hash] * EPOCHS_PER_HISTORICAL_VECTOR, # Seed RANDAO with Eth1 entropy - ) - - # Process deposits - leaves = list(map(lambda deposit: deposit.data, deposits)) - for index, deposit in enumerate(deposits): - deposit_data_list = List[DepositData, 2**DEPOSIT_CONTRACT_TREE_DEPTH](*leaves[:index + 1]) - state.eth1_data.deposit_root = hash_tree_root(deposit_data_list) - process_deposit(state, deposit) - - # Process activations - for index, validator in enumerate(state.validators): - balance = state.balances[index] - validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, MAX_EFFECTIVE_BALANCE) - if validator.effective_balance == MAX_EFFECTIVE_BALANCE: - validator.activation_eligibility_epoch = GENESIS_EPOCH - validator.activation_epoch = GENESIS_EPOCH - - # Set genesis validators root for domain separation and chain versioning - state.genesis_validators_root = hash_tree_root(state.validators) - - # Fill in sync committees - # Note: A duplicate committee is assigned for the current and next committee at genesis - state.current_sync_committee = get_next_sync_committee(state) - state.next_sync_committee = get_next_sync_committee(state) - - # Initialize the execution payload header - state.latest_execution_payload_header = execution_payload_header - - return state -``` diff --git a/specs/_features/eip7002/fork.md b/specs/_features/eip7002/fork.md deleted file mode 100644 index 87008de77..000000000 --- a/specs/_features/eip7002/fork.md +++ /dev/null @@ -1,140 +0,0 @@ -# EIP-7002 -- Fork Logic - -**Notice**: This document is a work-in-progress for researchers and implementers. - -## Table of contents - - - - -- [Introduction](#introduction) -- [Configuration](#configuration) -- [Helper functions](#helper-functions) - - [Misc](#misc) - - [Modified `compute_fork_version`](#modified-compute_fork_version) -- [Fork to EIP-7002](#fork-to-eip-7002) - - [Fork trigger](#fork-trigger) - - [Upgrading the state](#upgrading-the-state) - - - -## Introduction - -This document describes the process of EIP-7002 upgrade. - -## Configuration - -Warning: this configuration is not definitive. - -| Name | Value | -| - | - | -| `EIP7002_FORK_VERSION` | `Version('0x05000000')` | -| `EIP7002_FORK_EPOCH` | `Epoch(18446744073709551615)` **TBD** | - -## Helper functions - -### Misc - -#### Modified `compute_fork_version` - -```python -def compute_fork_version(epoch: Epoch) -> Version: - """ - Return the fork version at the given ``epoch``. - """ - if epoch >= EIP7002_FORK_EPOCH: - return EIP7002_FORK_VERSION - if epoch >= CAPELLA_FORK_EPOCH: - return CAPELLA_FORK_VERSION - if epoch >= BELLATRIX_FORK_EPOCH: - return BELLATRIX_FORK_VERSION - if epoch >= ALTAIR_FORK_EPOCH: - return ALTAIR_FORK_VERSION - return GENESIS_FORK_VERSION -``` - -## Fork to EIP-7002 - -### Fork trigger - -TBD. This fork is defined for testing purposes, the EIP may be combined with other consensus-layer upgrade. -For now, we assume the condition will be triggered at epoch `EIP7002_FORK_EPOCH`. - -Note that for the pure EIP-7002 networks, we don't apply `upgrade_to_eip7002` since it starts with EIP-7002 version logic. - -### Upgrading the state - -If `state.slot % SLOTS_PER_EPOCH == 0` and `compute_epoch_at_slot(state.slot) == EIP7002_FORK_EPOCH`, -an irregular state change is made to upgrade to EIP-7002. - -```python -def upgrade_to_eip7002(pre: capella.BeaconState) -> BeaconState: - epoch = capella.get_current_epoch(pre) - latest_execution_payload_header = ExecutionPayloadHeader( - parent_hash=pre.latest_execution_payload_header.parent_hash, - fee_recipient=pre.latest_execution_payload_header.fee_recipient, - state_root=pre.latest_execution_payload_header.state_root, - receipts_root=pre.latest_execution_payload_header.receipts_root, - logs_bloom=pre.latest_execution_payload_header.logs_bloom, - prev_randao=pre.latest_execution_payload_header.prev_randao, - block_number=pre.latest_execution_payload_header.block_number, - gas_limit=pre.latest_execution_payload_header.gas_limit, - gas_used=pre.latest_execution_payload_header.gas_used, - timestamp=pre.latest_execution_payload_header.timestamp, - extra_data=pre.latest_execution_payload_header.extra_data, - base_fee_per_gas=pre.latest_execution_payload_header.base_fee_per_gas, - block_hash=pre.latest_execution_payload_header.block_hash, - transactions_root=pre.latest_execution_payload_header.transactions_root, - withdrawals_root=pre.latest_execution_payload_header.withdrawals_root, - exits_root=Root(), # [New in EIP-7002] - ) - post = BeaconState( - # Versioning - genesis_time=pre.genesis_time, - genesis_validators_root=pre.genesis_validators_root, - slot=pre.slot, - fork=Fork( - previous_version=pre.fork.current_version, - current_version=EIP7002_FORK_VERSION, # [Modified in EIP-7002] - epoch=epoch, - ), - # History - latest_block_header=pre.latest_block_header, - block_roots=pre.block_roots, - state_roots=pre.state_roots, - historical_roots=pre.historical_roots, - # Eth1 - eth1_data=pre.eth1_data, - eth1_data_votes=pre.eth1_data_votes, - eth1_deposit_index=pre.eth1_deposit_index, - # Registry - validators=pre.validators, - balances=pre.balances, - # Randomness - randao_mixes=pre.randao_mixes, - # Slashings - slashings=pre.slashings, - # Participation - previous_epoch_participation=pre.previous_epoch_participation, - current_epoch_participation=pre.current_epoch_participation, - # Finality - justification_bits=pre.justification_bits, - previous_justified_checkpoint=pre.previous_justified_checkpoint, - current_justified_checkpoint=pre.current_justified_checkpoint, - finalized_checkpoint=pre.finalized_checkpoint, - # Inactivity - inactivity_scores=pre.inactivity_scores, - # Sync - current_sync_committee=pre.current_sync_committee, - next_sync_committee=pre.next_sync_committee, - # Execution-layer - latest_execution_payload_header=latest_execution_payload_header, # [Modified in EIP-7002] - # Withdrawals - next_withdrawal_index=pre.next_withdrawal_index, - next_withdrawal_validator_index=pre.next_withdrawal_validator_index, - # Deep history valid from Capella onwards - historical_summaries=pre.historical_summaries, - ) - - return post -``` diff --git a/specs/electra/beacon-chain.md b/specs/electra/beacon-chain.md index 34b8b4b45..b41042c87 100644 --- a/specs/electra/beacon-chain.md +++ b/specs/electra/beacon-chain.md @@ -16,6 +16,7 @@ - [Containers](#containers) - [New containers](#new-containers) - [`DepositReceipt`](#depositreceipt) + - [`ExecutionLayerExit`](#executionlayerexit) - [Extended Containers](#extended-containers) - [`ExecutionPayload`](#executionpayload) - [`ExecutionPayloadHeader`](#executionpayloadheader) @@ -24,6 +25,7 @@ - [Block processing](#block-processing) - [Modified `process_operations`](#modified-process_operations) - [New `process_deposit_receipt`](#new-process_deposit_receipt) + - [New `process_execution_layer_exit`](#new-process_execution_layer_exit) - [Modified `process_execution_payload`](#modified-process_execution_payload) - [Testing](#testing) @@ -34,6 +36,7 @@ Electra is a consensus-layer upgrade containing a number of features. Including: * [EIP-6110](https://eips.ethereum.org/EIPS/eip-6110): Supply validator deposits on chain +* [EIP-7002](https://eips.ethereum.org/EIPS/eip-7002): Execution layer triggerable exits ## Constants @@ -52,6 +55,7 @@ The following values are (non-configurable) constants used throughout the specif | Name | Value | Description | | - | - | - | | `MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD` | `uint64(2**13)` (= 8,192) | *[New in Electra:EIP6110]* Maximum number of deposit receipts allowed in each payload | +| `MAX_EXECUTION_LAYER_EXITS` | `2**4` (= 16) | *[New in Electra:EIP7002]* | ## Containers @@ -70,6 +74,16 @@ class DepositReceipt(Container): index: uint64 ``` +#### `ExecutionLayerExit` + +*Note*: The container is new in EIP7002. + +```python +class ExecutionLayerExit(Container): + source_address: ExecutionAddress + validator_pubkey: BLSPubkey +``` + ### Extended Containers #### `ExecutionPayload` @@ -96,6 +110,7 @@ class ExecutionPayload(Container): blob_gas_used: uint64 excess_blob_gas: uint64 deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD] # [New in Electra:EIP6110] + exits: List[ExecutionLayerExit, MAX_EXECUTION_LAYER_EXITS] # [New in Electra:EIP7002] ``` #### `ExecutionPayloadHeader` @@ -122,6 +137,7 @@ class ExecutionPayloadHeader(Container): blob_gas_used: uint64 excess_blob_gas: uint64 deposit_receipts_root: Root # [New in Electra:EIP6110] + exits_root: Root # [New in Electra:EIP7002] ``` #### `BeaconState` @@ -163,7 +179,7 @@ class BeaconState(Container): current_sync_committee: SyncCommittee next_sync_committee: SyncCommittee # Execution - latest_execution_payload_header: ExecutionPayloadHeader # [Modified in Electra:EIP6110] + latest_execution_payload_header: ExecutionPayloadHeader # [Modified in Electra:EIP6110:EIP7002] # Withdrawals next_withdrawal_index: WithdrawalIndex next_withdrawal_validator_index: ValidatorIndex @@ -190,7 +206,7 @@ def process_block(state: BeaconState, block: BeaconBlock) -> None: #### Modified `process_operations` -*Note*: The function `process_operations` is modified to process `DepositReceipt` operations included in the payload. +*Note*: The function `process_operations` is modified to process `DepositReceipt` and `ExecutionLayerExit` operations included in the payload. ```python def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: @@ -211,6 +227,7 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: for_ops(body.attestations, process_attestation) for_ops(body.deposits, process_deposit) for_ops(body.voluntary_exits, process_voluntary_exit) + for_ops(body.execution_payload.exits, process_execution_layer_exit) # [New in Electra:EIP7002] for_ops(body.bls_to_execution_changes, process_bls_to_execution_change) # [New in EIP6110] @@ -236,6 +253,35 @@ def process_deposit_receipt(state: BeaconState, deposit_receipt: DepositReceipt) ) ``` +#### New `process_execution_layer_exit` + +*Note*: This function is new in Electra:EIP7002. + +```python +def process_execution_layer_exit(state: BeaconState, execution_layer_exit: ExecutionLayerExit) -> None: + validator_pubkeys = [v.pubkey for v in state.validators] + validator_index = ValidatorIndex(validator_pubkeys.index(execution_layer_exit.validator_pubkey)) + validator = state.validators[validator_index] + + # Verify withdrawal credentials + is_execution_address = validator.withdrawal_credentials[:1] == ETH1_ADDRESS_WITHDRAWAL_PREFIX + is_correct_source_address = validator.withdrawal_credentials[12:] == execution_layer_exit.source_address + if not (is_execution_address and is_correct_source_address): + return + # Verify the validator is active + if not is_active_validator(validator, get_current_epoch(state)): + return + # Verify exit has not been initiated + if validator.exit_epoch != FAR_FUTURE_EPOCH: + return + # Verify the validator has been active long enough + if get_current_epoch(state) < validator.activation_epoch + SHARD_COMMITTEE_PERIOD: + return + + # Initiate exit + initiate_validator_exit(state, validator_index) +``` + #### Modified `process_execution_payload` *Note*: The function `process_execution_payload` is modified to use the new `ExecutionPayloadHeader` type. @@ -281,6 +327,7 @@ def process_execution_payload(state: BeaconState, body: BeaconBlockBody, executi blob_gas_used=payload.blob_gas_used, excess_blob_gas=payload.excess_blob_gas, deposit_receipts_root=hash_tree_root(payload.deposit_receipts), # [New in Electra:EIP6110] + exits_root=hash_tree_root(payload.exits), # [New in Electra:EIP7002] ) ``` diff --git a/specs/electra/fork.md b/specs/electra/fork.md index f93ef03df..ffc4a8d3c 100644 --- a/specs/electra/fork.md +++ b/specs/electra/fork.md @@ -91,6 +91,7 @@ def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: blob_gas_used=uint64(0), excess_blob_gas=uint64(0), deposit_receipts_root=Root(), # [New in Electra:EIP6110] + exits_root=Root(), # [New in Electra:EIP-7002], ) post = BeaconState( # Versioning @@ -132,7 +133,7 @@ def upgrade_to_electra(pre: deneb.BeaconState) -> BeaconState: current_sync_committee=pre.current_sync_committee, next_sync_committee=pre.next_sync_committee, # Execution-layer - latest_execution_payload_header=latest_execution_payload_header, # [Modified in Electra:EIP6110] + latest_execution_payload_header=latest_execution_payload_header, # [Modified in Electra:EIP6110:EIP7002] # Withdrawals next_withdrawal_index=pre.next_withdrawal_index, next_withdrawal_validator_index=pre.next_withdrawal_validator_index, diff --git a/tests/core/pyspec/eth2spec/test/context.py b/tests/core/pyspec/eth2spec/test/context.py index 74fd3b2db..e6fda66bd 100644 --- a/tests/core/pyspec/eth2spec/test/context.py +++ b/tests/core/pyspec/eth2spec/test/context.py @@ -8,7 +8,7 @@ from eth2spec.utils import bls from .exceptions import SkippedTest from .helpers.constants import ( PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, ELECTRA, - EIP7002, EIP7594, + EIP7594, WHISK, MINIMAL, ALL_PHASES, @@ -508,7 +508,6 @@ with_bellatrix_and_later = with_all_phases_from(BELLATRIX) with_capella_and_later = with_all_phases_from(CAPELLA) with_deneb_and_later = with_all_phases_from(DENEB) with_electra_and_later = with_all_phases_from(ELECTRA) -with_eip7002_and_later = with_all_phases_from(EIP7002) with_whisk_and_later = with_all_phases_from(WHISK, all_phases=ALLOWED_TEST_RUNNER_FORKS) with_eip7594_and_later = with_all_phases_from(EIP7594, all_phases=ALLOWED_TEST_RUNNER_FORKS) diff --git a/tests/core/pyspec/eth2spec/test/eip7002/block_processing/test_process_execution_layer_exit.py b/tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_execution_layer_exit.py similarity index 95% rename from tests/core/pyspec/eth2spec/test/eip7002/block_processing/test_process_execution_layer_exit.py rename to tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_execution_layer_exit.py index bd944a1fa..841998c17 100644 --- a/tests/core/pyspec/eth2spec/test/eip7002/block_processing/test_process_execution_layer_exit.py +++ b/tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_execution_layer_exit.py @@ -1,9 +1,9 @@ -from eth2spec.test.context import spec_state_test, with_eip7002_and_later +from eth2spec.test.context import spec_state_test, with_electra_and_later from eth2spec.test.helpers.execution_layer_exits import run_execution_layer_exit_processing from eth2spec.test.helpers.withdrawals import set_eth1_withdrawal_credential_with_balance -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_basic_exit(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -22,7 +22,7 @@ def test_basic_exit(spec, state): yield from run_execution_layer_exit_processing(spec, state, execution_layer_exit) -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_incorrect_source_address(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -42,7 +42,7 @@ def test_incorrect_source_address(spec, state): yield from run_execution_layer_exit_processing(spec, state, execution_layer_exit, success=False) -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_incorrect_withdrawal_credential_prefix(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -66,7 +66,7 @@ def test_incorrect_withdrawal_credential_prefix(spec, state): yield from run_execution_layer_exit_processing(spec, state, execution_layer_exit, success=False) -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_on_exit_initiated_validator(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -87,7 +87,7 @@ def test_on_exit_initiated_validator(spec, state): yield from run_execution_layer_exit_processing(spec, state, execution_layer_exit, success=False) -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_activation_epoch_less_than_shard_committee_period(spec, state): current_epoch = spec.get_current_epoch(state) diff --git a/tests/core/pyspec/eth2spec/test/eip7002/sanity/test_blocks.py b/tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_blocks.py similarity index 98% rename from tests/core/pyspec/eth2spec/test/eip7002/sanity/test_blocks.py rename to tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_blocks.py index 29a03fee0..fabe196ef 100644 --- a/tests/core/pyspec/eth2spec/test/eip7002/sanity/test_blocks.py +++ b/tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_blocks.py @@ -3,7 +3,7 @@ from eth2spec.test.helpers.block import ( ) from eth2spec.test.context import ( spec_state_test, - with_eip7002_and_later, + with_electra_and_later, ) from eth2spec.test.helpers.bls_to_execution_changes import ( get_signed_address_change, @@ -22,7 +22,7 @@ from eth2spec.test.helpers.withdrawals import ( ) -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_basic_el_exit(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -51,7 +51,7 @@ def test_basic_el_exit(spec, state): assert state.validators[validator_index].exit_epoch < spec.FAR_FUTURE_EPOCH -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_basic_btec_and_el_exit_in_same_block(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -94,7 +94,7 @@ def test_basic_btec_and_el_exit_in_same_block(spec, state): assert is_execution_address and is_correct_source_address -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_basic_btec_before_el_exit(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit @@ -141,7 +141,7 @@ def test_basic_btec_before_el_exit(spec, state): assert state.validators[validator_index].exit_epoch < spec.FAR_FUTURE_EPOCH -@with_eip7002_and_later +@with_electra_and_later @spec_state_test def test_cl_exit_and_el_exit_in_same_block(spec, state): # move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit diff --git a/tests/core/pyspec/eth2spec/test/helpers/constants.py b/tests/core/pyspec/eth2spec/test/helpers/constants.py index dc2f125e6..4c6d56494 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/constants.py +++ b/tests/core/pyspec/eth2spec/test/helpers/constants.py @@ -17,7 +17,6 @@ SHARDING = SpecForkName('sharding') CUSTODY_GAME = SpecForkName('custody_game') DAS = SpecForkName('das') ELECTRA = SpecForkName('electra') -EIP7002 = SpecForkName('eip7002') WHISK = SpecForkName('whisk') EIP7594 = SpecForkName('eip7594') @@ -37,7 +36,6 @@ ALL_PHASES = ( DENEB, ELECTRA, # Experimental patches - EIP7002, EIP7594, ) # The forks that have light client specs @@ -58,7 +56,6 @@ PREVIOUS_FORK_OF = { ELECTRA: DENEB, # Experimental patches WHISK: CAPELLA, - EIP7002: CAPELLA, EIP7594: DENEB, } diff --git a/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py b/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py index 0d1269dda..629f424b3 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py +++ b/tests/core/pyspec/eth2spec/test/helpers/execution_payload.py @@ -8,7 +8,6 @@ from eth2spec.test.helpers.forks import ( is_post_capella, is_post_deneb, is_post_electra, - is_post_eip7002, ) @@ -36,7 +35,6 @@ def get_execution_payload_header(spec, execution_payload): payload_header.excess_blob_gas = execution_payload.excess_blob_gas if is_post_electra(spec): payload_header.deposit_receipts_root = spec.hash_tree_root(execution_payload.deposit_receipts) - if is_post_eip7002(spec): payload_header.exits_root = spec.hash_tree_root(execution_payload.exits) return payload_header @@ -109,7 +107,6 @@ def compute_el_header_block_hash(spec, # deposit_receipts_root assert deposit_receipts_trie_root is not None execution_payload_header_rlp.append((Binary(32, 32), deposit_receipts_trie_root)) - if is_post_eip7002(spec): # exits_trie_root execution_payload_header_rlp.append((Binary(32, 32), exits_trie_root)) @@ -184,7 +181,6 @@ def compute_el_block_hash(spec, payload): if is_post_electra(spec): deposit_receipts_encoded = [get_deposit_receipt_rlp(spec, receipt) for receipt in payload.deposit_receipts] deposit_receipts_trie_root = compute_trie_root_from_indexed_data(deposit_receipts_encoded) - if is_post_eip7002(spec): exits_encoded = [get_exit_rlp(exit) for exit in payload.exits] exits_trie_root = compute_trie_root_from_indexed_data(exits_encoded) diff --git a/tests/core/pyspec/eth2spec/test/helpers/forks.py b/tests/core/pyspec/eth2spec/test/helpers/forks.py index 17a4050bf..5ea03c31b 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/forks.py +++ b/tests/core/pyspec/eth2spec/test/helpers/forks.py @@ -1,6 +1,6 @@ from .constants import ( PHASE0, ALTAIR, BELLATRIX, CAPELLA, DENEB, - ELECTRA, EIP7002, WHISK, + ELECTRA, WHISK, PREVIOUS_FORK_OF, ) @@ -41,10 +41,6 @@ def is_post_electra(spec): return is_post_fork(spec.fork, ELECTRA) -def is_post_eip7002(spec): - return is_post_fork(spec.fork, EIP7002) - - def is_post_whisk(spec): return is_post_fork(spec.fork, WHISK) diff --git a/tests/core/pyspec/eth2spec/test/helpers/genesis.py b/tests/core/pyspec/eth2spec/test/helpers/genesis.py index 78f678825..0f9d489c3 100644 --- a/tests/core/pyspec/eth2spec/test/helpers/genesis.py +++ b/tests/core/pyspec/eth2spec/test/helpers/genesis.py @@ -6,7 +6,7 @@ from eth2spec.test.helpers.execution_payload import ( compute_el_header_block_hash, ) from eth2spec.test.helpers.forks import ( - is_post_altair, is_post_bellatrix, is_post_capella, is_post_electra, is_post_eip7002, is_post_whisk, + is_post_altair, is_post_bellatrix, is_post_capella, is_post_electra, is_post_whisk, ) from eth2spec.test.helpers.keys import pubkeys from eth2spec.test.helpers.whisk import compute_whisk_initial_tracker_cached, compute_whisk_initial_k_commitment_cached @@ -57,7 +57,6 @@ def get_sample_genesis_execution_payload_header(spec, withdrawals_trie_root = bytes.fromhex("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421") if is_post_electra(spec): deposit_receipts_trie_root = bytes.fromhex("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421") - if is_post_eip7002(spec): exits_trie_root = bytes.fromhex("56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421") payload_header.block_hash = compute_el_header_block_hash( From 507bab6d8a9cb6b76abf74fceb87a31cced88dcb Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Wed, 6 Mar 2024 14:26:59 +0800 Subject: [PATCH 04/25] update eip7002 operation tests to testgen --- tests/formats/operations/README.md | 1 + tests/generators/operations/main.py | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/formats/operations/README.md b/tests/formats/operations/README.md index 8e9841618..b020b5fd0 100644 --- a/tests/formats/operations/README.md +++ b/tests/formats/operations/README.md @@ -46,6 +46,7 @@ Operations: | `withdrawals` | `ExecutionPayload` | `execution_payload` | `process_withdrawals(state, execution_payload)` (new in Capella) | | `bls_to_execution_change` | `SignedBLSToExecutionChange` | `address_change` | `process_bls_to_execution_change(state, address_change)` (new in Capella) | | `deposit_receipt` | `DepositReceipt` | `deposit_receipt` | `process_deposit_receipt(state, deposit_receipt)` (new in Electra) | +| `exits` | `ExecutionLayerExit` | `execution_layer_exit` | `process_execution_layer_exit(state, execution_layer_exit)` (new in Electra) | Note that `block_header` is not strictly an operation (and is a full `Block`), but processed in the same manner, and hence included here. diff --git a/tests/generators/operations/main.py b/tests/generators/operations/main.py index c31a72285..0413eb2b2 100644 --- a/tests/generators/operations/main.py +++ b/tests/generators/operations/main.py @@ -45,6 +45,7 @@ if __name__ == "__main__": _new_electra_mods = {key: 'eth2spec.test.electra.block_processing.test_process_' + key for key in [ 'deposit_receipt', + 'execution_layer_exit', ]} electra_mods = combine_mods(_new_electra_mods, deneb_mods) From cda10d059b61bc610493509803120e92c1bdf85b Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 27 Mar 2024 16:49:12 +0600 Subject: [PATCH 05/25] Refactor EL withdraw request processing --- specs/_features/eip7251/beacon-chain.md | 29 +++++++++++++++++-------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index c4aad0a6f..19fb7a91d 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -8,6 +8,7 @@ - [Introduction](#introduction) - [Constants](#constants) + - [Misc](#misc) - [Withdrawal prefixes](#withdrawal-prefixes) - [Domains](#domains) - [Presets](#presets) @@ -87,6 +88,12 @@ See [a modest proposal](https://notes.ethereum.org/@mikeneuder/increase-maxeb), The following values are (non-configurable) constants used throughout the specification. +### Misc + +| Name | Value | +| - | - | +| `FULL_EXIT_REQUEST_AMOUNT` | `uint64(2**64 - 1)` | + ### Withdrawal prefixes | Name | Value | @@ -866,7 +873,8 @@ def process_execution_layer_withdraw_request( execution_layer_withdraw_request: ExecutionLayerWithdrawRequest ) -> None: amount = execution_layer_withdraw_request.amount - is_full_exit_request = amount == 0 + is_full_exit_request = amount == FULL_EXIT_REQUEST_AMOUNT + # If partial withdrawal queue is full, only full exits are processed if len(state.pending_partial_withdrawals) >= PENDING_PARTIAL_WITHDRAWALS_LIMIT and not is_full_exit_request: return @@ -888,20 +896,23 @@ def process_execution_layer_withdraw_request( and get_current_epoch(state) >= validator.activation_epoch + SHARD_COMMITTEE_PERIOD ): return - # New condition: only allow partial withdrawals with compounding withdrawal credentials - if not (is_full_exit_request or has_compounding_withdrawal_credential(validator)): - return pending_balance_to_withdraw = sum( item.amount for item in state.pending_partial_withdrawals if item.index == index ) - # only exit validator if it has no pending withdrawals in the queue - if is_full_exit_request and pending_balance_to_withdraw > 0: - return if is_full_exit_request: - initiate_validator_exit(state, index) - elif state.balances[index] > MIN_ACTIVATION_BALANCE + pending_balance_to_withdraw: + # Only exit validator if it has no pending withdrawals in the queue + if pending_balance_to_withdraw == 0: + initiate_validator_exit(state, index) + + return + + + has_excess_balance = state.balances[index] > MIN_ACTIVATION_BALANCE + pending_balance_to_withdraw + + # Only allow partial withdrawals with compounding withdrawal credentials + if has_compounding_withdrawal_credential(validator) and has_excess_balance: to_withdraw = min( state.balances[index] - MIN_ACTIVATION_BALANCE - pending_balance_to_withdraw, amount From 6f5cc4baf5e6b8cb9b753085fb9738c540147b8a Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 27 Mar 2024 17:35:27 +0600 Subject: [PATCH 06/25] Replace MIN_ACTIVATION_BALANCE with MAX_EFFECTIVE_BALANCE --- specs/_features/eip7251/beacon-chain.md | 28 +++++++++---------------- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 19fb7a91d..b7c2ffdb1 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -373,7 +373,7 @@ def get_validator_max_effective_balance(validator: Validator) -> Gwei: if has_compounding_withdrawal_credential(validator): return MAX_EFFECTIVE_BALANCE_EIP7251 else: - return MIN_ACTIVATION_BALANCE + return MAX_EFFECTIVE_BALANCE ``` #### New `get_churn_limit` @@ -411,12 +411,8 @@ def get_consolidation_churn_limit(state: BeaconState) -> Gwei: ```python def get_active_balance(state: BeaconState, validator_index: ValidatorIndex) -> Gwei: - active_balance_ceil = ( - MIN_ACTIVATION_BALANCE - if has_eth1_withdrawal_credential(state.validators[validator_index]) - else MAX_EFFECTIVE_BALANCE_EIP7251 - ) - return min(state.balances[validator_index], active_balance_ceil) + max_effective_balance = get_validator_max_effective_balance(state.validators[validator_index]) + return min(state.balances[validator_index], max_effective_balance) ``` ### Beacon state mutators @@ -649,16 +645,12 @@ def process_effective_balance_updates(state: BeaconState) -> None: HYSTERESIS_INCREMENT = uint64(EFFECTIVE_BALANCE_INCREMENT // HYSTERESIS_QUOTIENT) DOWNWARD_THRESHOLD = HYSTERESIS_INCREMENT * HYSTERESIS_DOWNWARD_MULTIPLIER UPWARD_THRESHOLD = HYSTERESIS_INCREMENT * HYSTERESIS_UPWARD_MULTIPLIER - EFFECTIVE_BALANCE_LIMIT = ( - MAX_EFFECTIVE_BALANCE_EIP7251 if has_compounding_withdrawal_credential(validator) - else MIN_ACTIVATION_BALANCE - ) - + max_effective_balance = get_validator_max_effective_balance(validator) if ( balance + DOWNWARD_THRESHOLD < validator.effective_balance or validator.effective_balance + UPWARD_THRESHOLD < balance ): - validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, EFFECTIVE_BALANCE_LIMIT) + validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, max_effective_balance) # [Modified in EIP7251] ``` ### Block processing @@ -689,8 +681,8 @@ def get_expected_withdrawals(state: BeaconState) -> Tuple[Sequence[Withdrawal], break validator = state.validators[withdrawal.index] - if validator.exit_epoch == FAR_FUTURE_EPOCH and state.balances[withdrawal.index] > MIN_ACTIVATION_BALANCE: - withdrawable_balance = min(state.balances[withdrawal.index] - MIN_ACTIVATION_BALANCE, withdrawal.amount) + if validator.exit_epoch == FAR_FUTURE_EPOCH and state.balances[withdrawal.index] > MAX_EFFECTIVE_BALANCE: + withdrawable_balance = min(state.balances[withdrawal.index] - MAX_EFFECTIVE_BALANCE, withdrawal.amount) withdrawals.append(Withdrawal( index=withdrawal_index, validator_index=withdrawal.index, @@ -909,12 +901,12 @@ def process_execution_layer_withdraw_request( return - has_excess_balance = state.balances[index] > MIN_ACTIVATION_BALANCE + pending_balance_to_withdraw + has_excess_balance = state.balances[index] > MAX_EFFECTIVE_BALANCE + pending_balance_to_withdraw # Only allow partial withdrawals with compounding withdrawal credentials if has_compounding_withdrawal_credential(validator) and has_excess_balance: to_withdraw = min( - state.balances[index] - MIN_ACTIVATION_BALANCE - pending_balance_to_withdraw, + state.balances[index] - MAX_EFFECTIVE_BALANCE - pending_balance_to_withdraw, amount ) exit_queue_epoch = compute_exit_epoch_and_update_churn(state, to_withdraw) @@ -935,7 +927,7 @@ def process_consolidation(state: BeaconState, signed_consolidation: SignedConsol # If the pending consolidations queue is full, no consolidations are allowed in the block assert len(state.pending_consolidations) < PENDING_CONSOLIDATIONS_LIMIT # If there is too little available consolidation churn limit, no consolidations are allowed in the block - assert get_consolidation_churn_limit(state) > MIN_ACTIVATION_BALANCE + assert get_consolidation_churn_limit(state) > MAX_EFFECTIVE_BALANCE consolidation = signed_consolidation.message # Verify that source != target, so a consolidation cannot be used as an exit. assert consolidation.source_index != consolidation.target_index From 31142b0ba18572c888618bd8ef87deb1dd96bc92 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 27 Mar 2024 17:41:00 +0600 Subject: [PATCH 07/25] Require sufficient EB to emit partial withdrawal --- specs/_features/eip7251/beacon-chain.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index b7c2ffdb1..2035180af 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -681,7 +681,9 @@ def get_expected_withdrawals(state: BeaconState) -> Tuple[Sequence[Withdrawal], break validator = state.validators[withdrawal.index] - if validator.exit_epoch == FAR_FUTURE_EPOCH and state.balances[withdrawal.index] > MAX_EFFECTIVE_BALANCE: + has_sufficient_effective_balance = validator.effective_balance == MAX_EFFECTIVE_BALANCE + has_excess_balance = state.balances[withdrawal.index] > MAX_EFFECTIVE_BALANCE + if validator.exit_epoch == FAR_FUTURE_EPOCH and has_sufficient_effective_balance and has_excess_balance: withdrawable_balance = min(state.balances[withdrawal.index] - MAX_EFFECTIVE_BALANCE, withdrawal.amount) withdrawals.append(Withdrawal( index=withdrawal_index, @@ -901,10 +903,11 @@ def process_execution_layer_withdraw_request( return + has_sufficient_effective_balance = validator.effective_balance == MAX_EFFECTIVE_BALANCE has_excess_balance = state.balances[index] > MAX_EFFECTIVE_BALANCE + pending_balance_to_withdraw # Only allow partial withdrawals with compounding withdrawal credentials - if has_compounding_withdrawal_credential(validator) and has_excess_balance: + if has_compounding_withdrawal_credential(validator) and has_sufficient_effective_balance and has_excess_balance: to_withdraw = min( state.balances[index] - MAX_EFFECTIVE_BALANCE - pending_balance_to_withdraw, amount From 46638d31baf38b5d2b8178b7b51343822438b548 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 27 Mar 2024 17:42:10 +0600 Subject: [PATCH 08/25] Remove unused method --- specs/_features/eip7251/beacon-chain.md | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 2035180af..e8c4e8a51 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -46,7 +46,6 @@ - [New `get_active_balance`](#new-get_active_balance) - [Beacon state mutators](#beacon-state-mutators) - [Updated `initiate_validator_exit`](#updated--initiate_validator_exit) - - [New `set_compounding_withdrawal_credentials`](#new-set_compounding_withdrawal_credentials) - [New `switch_to_compounding_validator`](#new-switch_to_compounding_validator) - [New `queue_excess_active_balance`](#new-queue_excess_active_balance) - [New `compute_exit_epoch_and_update_churn`](#new-compute_exit_epoch_and_update_churn) @@ -437,15 +436,6 @@ def initiate_validator_exit(state: BeaconState, index: ValidatorIndex) -> None: validator.withdrawable_epoch = Epoch(validator.exit_epoch + MIN_VALIDATOR_WITHDRAWABILITY_DELAY) ``` -#### New `set_compounding_withdrawal_credentials` - -```python -def set_compounding_withdrawal_credentials(state: BeaconState, index: ValidatorIndex) -> None: - validator = state.validators[index] - if has_eth1_withdrawal_credential(validator): - validator.withdrawal_credentials[:1] = COMPOUNDING_WITHDRAWAL_PREFIX -``` - #### New `switch_to_compounding_validator` ```python From 517f741f29a53ff8068283dc5ac8f694b5d5cc58 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 27 Mar 2024 17:57:54 +0600 Subject: [PATCH 09/25] Abort voluntary exit if validator has pending partial withdrawals --- specs/_features/eip7251/beacon-chain.md | 42 ++++++++++++++++++++++--- 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index e8c4e8a51..3bd461566 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -44,6 +44,7 @@ - [New `get_activation_exit_churn_limit`](#new-get_activation_exit_churn_limit) - [New `get_consolidation_churn_limit`](#new-get_consolidation_churn_limit) - [New `get_active_balance`](#new-get_active_balance) + - [New `get_pending_balance_to_withdraw`](#new-get_pending_balance_to_withdraw) - [Beacon state mutators](#beacon-state-mutators) - [Updated `initiate_validator_exit`](#updated--initiate_validator_exit) - [New `switch_to_compounding_validator`](#new-switch_to_compounding_validator) @@ -72,6 +73,8 @@ - [New `process_execution_layer_withdraw_request`](#new-process_execution_layer_withdraw_request) - [Consolidations](#consolidations) - [New `process_consolidation`](#new-process_consolidation) + - [Voluntary exits](#voluntary-exits) + - [Updated `process_voluntary_exit`](#updated-process_voluntary_exit) @@ -414,6 +417,14 @@ def get_active_balance(state: BeaconState, validator_index: ValidatorIndex) -> G return min(state.balances[validator_index], max_effective_balance) ``` +#### New `get_pending_balance_to_withdraw` + +```python +def get_pending_balance_to_withdraw(state: BeaconState, validator_index: ValidatorIndex) -> Gwei: + return sum( + withdrawal.amount for withdrawal in state.pending_partial_withdrawals if withdrawal.index == validator_index) +``` + ### Beacon state mutators #### Updated `initiate_validator_exit` @@ -762,7 +773,7 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: for_ops(body.attester_slashings, process_attester_slashing) for_ops(body.attestations, process_attestation) for_ops(body.deposits, process_deposit) # [Modified in EIP7251] - for_ops(body.voluntary_exits, process_voluntary_exit) + for_ops(body.voluntary_exits, process_voluntary_exit) # [Modified in EIP7251] for_ops(body.bls_to_execution_changes, process_bls_to_execution_change) for_ops(body.execution_payload.withdraw_requests, process_execution_layer_withdraw_request) # New in EIP7251 for_ops(body.consolidations, process_consolidation) # New in EIP7251 @@ -881,9 +892,7 @@ def process_execution_layer_withdraw_request( ): return - pending_balance_to_withdraw = sum( - item.amount for item in state.pending_partial_withdrawals if item.index == index - ) + pending_balance_to_withdraw = get_pending_balance_to_withdraw(state, index) if is_full_exit_request: # Only exit validator if it has no pending withdrawals in the queue @@ -961,3 +970,28 @@ def process_consolidation(state: BeaconState, signed_consolidation: SignedConsol )) ``` +##### Voluntary exits + +###### Updated `process_voluntary_exit` + +```python +def process_voluntary_exit(state: BeaconState, signed_voluntary_exit: SignedVoluntaryExit) -> None: + voluntary_exit = signed_voluntary_exit.message + validator = state.validators[voluntary_exit.validator_index] + # Verify the validator is active + assert is_active_validator(validator, get_current_epoch(state)) + # Verify exit has not been initiated + assert validator.exit_epoch == FAR_FUTURE_EPOCH + # Exits must specify an epoch when they become valid; they are not valid before then + assert get_current_epoch(state) >= voluntary_exit.epoch + # Verify the validator has been active long enough + assert get_current_epoch(state) >= validator.activation_epoch + SHARD_COMMITTEE_PERIOD + # Verify signature + domain = get_domain(state, DOMAIN_VOLUNTARY_EXIT, voluntary_exit.epoch) + signing_root = compute_signing_root(voluntary_exit, domain) + assert bls.Verify(validator.pubkey, signing_root, signed_voluntary_exit.signature) + # Only exit validator if it has no pending withdrawals in the queue + assert get_pending_balance_to_withdraw(state, voluntary_exit.validator_index) == 0 # [New in EIP7251] + # Initiate exit + initiate_validator_exit(state, voluntary_exit.validator_index) +``` \ No newline at end of file From 915f90e13eddf4ddfcc38b3b1b3d89a91d10b86c Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Wed, 27 Mar 2024 18:05:05 +0600 Subject: [PATCH 10/25] Strictly check withdrawal address upon consolidation --- specs/_features/eip7251/beacon-chain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 3bd461566..366eabe4c 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -950,7 +950,7 @@ def process_consolidation(state: BeaconState, signed_consolidation: SignedConsol assert has_execution_withdrawal_credential(source_validator) assert has_execution_withdrawal_credential(target_validator) # Verify the same withdrawal address - assert source_validator.withdrawal_credentials[1:] == target_validator.withdrawal_credentials[1:] + assert source_validator.withdrawal_credentials[12:] == target_validator.withdrawal_credentials[12:] # Verify consolidation is signed by the source and the target domain = compute_domain(DOMAIN_CONSOLIDATION, genesis_validators_root=state.genesis_validators_root) From 534bcfc116980efe92a032115f883e79d4825393 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Thu, 28 Mar 2024 11:49:44 +0600 Subject: [PATCH 11/25] Use source.effective_balance for consolidaiton churn --- specs/_features/eip7251/beacon-chain.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 366eabe4c..a0bc3bc8d 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -959,8 +959,8 @@ def process_consolidation(state: BeaconState, signed_consolidation: SignedConsol assert bls.FastAggregateVerify(pubkeys, signing_root, signed_consolidation.signature) # Initiate source validator exit and append pending consolidation - active_balance = get_active_balance(state, consolidation.source_index) - source_validator.exit_epoch = compute_consolidation_epoch_and_update_churn(state, active_balance) + source_validator.exit_epoch = compute_consolidation_epoch_and_update_churn( + state, source_validator.effective_balance) source_validator.withdrawable_epoch = Epoch( source_validator.exit_epoch + MIN_VALIDATOR_WITHDRAWABILITY_DELAY ) From 7bbecfb7625ce1411d4cf902a9dc54be0f76165d Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Fri, 29 Mar 2024 15:27:12 +0600 Subject: [PATCH 12/25] Revert "Replace MIN_ACTIVATION_BALANCE with MAX_EFFECTIVE_BALANCE" This reverts commit 6f5cc4baf5e6b8cb9b753085fb9738c540147b8a. --- specs/_features/eip7251/beacon-chain.md | 32 +++++++++++++++---------- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index a0bc3bc8d..db6d7601a 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -375,7 +375,7 @@ def get_validator_max_effective_balance(validator: Validator) -> Gwei: if has_compounding_withdrawal_credential(validator): return MAX_EFFECTIVE_BALANCE_EIP7251 else: - return MAX_EFFECTIVE_BALANCE + return MIN_ACTIVATION_BALANCE ``` #### New `get_churn_limit` @@ -413,8 +413,12 @@ def get_consolidation_churn_limit(state: BeaconState) -> Gwei: ```python def get_active_balance(state: BeaconState, validator_index: ValidatorIndex) -> Gwei: - max_effective_balance = get_validator_max_effective_balance(state.validators[validator_index]) - return min(state.balances[validator_index], max_effective_balance) + active_balance_ceil = ( + MIN_ACTIVATION_BALANCE + if has_eth1_withdrawal_credential(state.validators[validator_index]) + else MAX_EFFECTIVE_BALANCE_EIP7251 + ) + return min(state.balances[validator_index], active_balance_ceil) ``` #### New `get_pending_balance_to_withdraw` @@ -646,12 +650,16 @@ def process_effective_balance_updates(state: BeaconState) -> None: HYSTERESIS_INCREMENT = uint64(EFFECTIVE_BALANCE_INCREMENT // HYSTERESIS_QUOTIENT) DOWNWARD_THRESHOLD = HYSTERESIS_INCREMENT * HYSTERESIS_DOWNWARD_MULTIPLIER UPWARD_THRESHOLD = HYSTERESIS_INCREMENT * HYSTERESIS_UPWARD_MULTIPLIER - max_effective_balance = get_validator_max_effective_balance(validator) + EFFECTIVE_BALANCE_LIMIT = ( + MAX_EFFECTIVE_BALANCE_EIP7251 if has_compounding_withdrawal_credential(validator) + else MIN_ACTIVATION_BALANCE + ) + if ( balance + DOWNWARD_THRESHOLD < validator.effective_balance or validator.effective_balance + UPWARD_THRESHOLD < balance ): - validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, max_effective_balance) # [Modified in EIP7251] + validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, EFFECTIVE_BALANCE_LIMIT) ``` ### Block processing @@ -682,10 +690,10 @@ def get_expected_withdrawals(state: BeaconState) -> Tuple[Sequence[Withdrawal], break validator = state.validators[withdrawal.index] - has_sufficient_effective_balance = validator.effective_balance == MAX_EFFECTIVE_BALANCE - has_excess_balance = state.balances[withdrawal.index] > MAX_EFFECTIVE_BALANCE + has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE + has_excess_balance = state.balances[withdrawal.index] > MIN_ACTIVATION_BALANCE if validator.exit_epoch == FAR_FUTURE_EPOCH and has_sufficient_effective_balance and has_excess_balance: - withdrawable_balance = min(state.balances[withdrawal.index] - MAX_EFFECTIVE_BALANCE, withdrawal.amount) + withdrawable_balance = min(state.balances[withdrawal.index] - MIN_ACTIVATION_BALANCE, withdrawal.amount) withdrawals.append(Withdrawal( index=withdrawal_index, validator_index=withdrawal.index, @@ -902,13 +910,13 @@ def process_execution_layer_withdraw_request( return - has_sufficient_effective_balance = validator.effective_balance == MAX_EFFECTIVE_BALANCE - has_excess_balance = state.balances[index] > MAX_EFFECTIVE_BALANCE + pending_balance_to_withdraw + has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE + has_excess_balance = state.balances[index] > MIN_ACTIVATION_BALANCE + pending_balance_to_withdraw # Only allow partial withdrawals with compounding withdrawal credentials if has_compounding_withdrawal_credential(validator) and has_sufficient_effective_balance and has_excess_balance: to_withdraw = min( - state.balances[index] - MAX_EFFECTIVE_BALANCE - pending_balance_to_withdraw, + state.balances[index] - MIN_ACTIVATION_BALANCE - pending_balance_to_withdraw, amount ) exit_queue_epoch = compute_exit_epoch_and_update_churn(state, to_withdraw) @@ -929,7 +937,7 @@ def process_consolidation(state: BeaconState, signed_consolidation: SignedConsol # If the pending consolidations queue is full, no consolidations are allowed in the block assert len(state.pending_consolidations) < PENDING_CONSOLIDATIONS_LIMIT # If there is too little available consolidation churn limit, no consolidations are allowed in the block - assert get_consolidation_churn_limit(state) > MAX_EFFECTIVE_BALANCE + assert get_consolidation_churn_limit(state) > MIN_ACTIVATION_BALANCE consolidation = signed_consolidation.message # Verify that source != target, so a consolidation cannot be used as an exit. assert consolidation.source_index != consolidation.target_index From 221f273e14aff0356d1b98ac1920dcc7dd523765 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Fri, 29 Mar 2024 22:35:12 +0600 Subject: [PATCH 13/25] Fix lint --- specs/_features/eip7251/beacon-chain.md | 1 - 1 file changed, 1 deletion(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index db6d7601a..845ff1b96 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -909,7 +909,6 @@ def process_execution_layer_withdraw_request( return - has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE has_excess_balance = state.balances[index] > MIN_ACTIVATION_BALANCE + pending_balance_to_withdraw From 4f8fb6f7162e4559a4d051b0cf6996e125911806 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Thu, 4 Apr 2024 14:49:25 +0300 Subject: [PATCH 14/25] Update specs/_features/eip7251/beacon-chain.md Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com> --- specs/_features/eip7251/beacon-chain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 845ff1b96..662d851c4 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -909,7 +909,7 @@ def process_execution_layer_withdraw_request( return - has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE + has_sufficient_effective_balance = validator.effective_balance >= MIN_ACTIVATION_BALANCE has_excess_balance = state.balances[index] > MIN_ACTIVATION_BALANCE + pending_balance_to_withdraw # Only allow partial withdrawals with compounding withdrawal credentials From e64afbc630de523f4ec75776ea3c3180931e6b5b Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Fri, 5 Apr 2024 06:13:45 +0800 Subject: [PATCH 15/25] Apply suggestions from code review Co-authored-by: Mikhail Kalinin --- presets/mainnet/electra.yaml | 2 +- specs/electra/beacon-chain.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/presets/mainnet/electra.yaml b/presets/mainnet/electra.yaml index badb4e95d..d38c3e2e3 100644 --- a/presets/mainnet/electra.yaml +++ b/presets/mainnet/electra.yaml @@ -1,4 +1,4 @@ -# Mainnet preset - ELECTRA +# Mainnet preset - Electra # Execution # --------------------------------------------------------------- diff --git a/specs/electra/beacon-chain.md b/specs/electra/beacon-chain.md index b41042c87..9c9066c3e 100644 --- a/specs/electra/beacon-chain.md +++ b/specs/electra/beacon-chain.md @@ -200,7 +200,7 @@ def process_block(state: BeaconState, block: BeaconBlock) -> None: process_execution_payload(state, block.body, EXECUTION_ENGINE) # [Modified in Electra:EIP6110] process_randao(state, block.body) process_eth1_data(state, block.body) - process_operations(state, block.body) # [Modified in Electra:EIP6110] + process_operations(state, block.body) # [Modified in Electra:EIP6110:EIP7002] process_sync_aggregate(state, block.body.sync_aggregate) ``` From ace9db9aa9a75ff1231a9631af598728d311763b Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Fri, 5 Apr 2024 15:35:06 +0300 Subject: [PATCH 16/25] Set FULL_EXIT_REQUEST_AMOUNT to 0 --- specs/_features/eip7251/beacon-chain.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 662d851c4..852742a64 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -94,7 +94,7 @@ The following values are (non-configurable) constants used throughout the specif | Name | Value | | - | - | -| `FULL_EXIT_REQUEST_AMOUNT` | `uint64(2**64 - 1)` | +| `FULL_EXIT_REQUEST_AMOUNT` | `uint64(0)` | ### Withdrawal prefixes @@ -1001,4 +1001,4 @@ def process_voluntary_exit(state: BeaconState, signed_voluntary_exit: SignedVolu assert get_pending_balance_to_withdraw(state, voluntary_exit.validator_index) == 0 # [New in EIP7251] # Initiate exit initiate_validator_exit(state, voluntary_exit.validator_index) -``` \ No newline at end of file +``` From 6ad0c07c78f5c8da0f783032c067e4e2c6d413c8 Mon Sep 17 00:00:00 2001 From: NC Date: Sat, 6 Apr 2024 22:53:04 +0800 Subject: [PATCH 17/25] Remove extra ` queue_excess_active_balance` call --- specs/_features/eip7251/fork.md | 1 - 1 file changed, 1 deletion(-) diff --git a/specs/_features/eip7251/fork.md b/specs/_features/eip7251/fork.md index 609b4f3f8..02d73deb1 100644 --- a/specs/_features/eip7251/fork.md +++ b/specs/_features/eip7251/fork.md @@ -129,7 +129,6 @@ def upgrade_to_eip7251(pre: deneb.BeaconState) -> BeaconState: ) # Ensure early adopters of compounding credentials go through the activation churn - queue_excess_active_balance(post) for index, validator in enumerate(post.validators): if has_compounding_withdrawal_credential(validator): queue_excess_active_balance(post, index) From 982a983072f82b64289a1dc82eced7320ed92d9f Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Sat, 6 Apr 2024 10:43:35 -0600 Subject: [PATCH 18/25] EIP-7251: format/lint fixes/docs, add validator guide --- specs/_features/eip7251/beacon-chain.md | 31 +++++++---- specs/_features/eip7251/fork.md | 3 +- specs/_features/eip7251/validator.md | 73 +++++++++++++++++++++++++ 3 files changed, 93 insertions(+), 14 deletions(-) create mode 100644 specs/_features/eip7251/validator.md diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 9fbc587c5..5a99ad4d4 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -81,7 +81,7 @@ ## Introduction -See [a modest proposal](https://notes.ethereum.org/@mikeneuder/increase-maxeb), the [diff view](https://github.com/michaelneuder/consensus-specs/pull/3/files) and +See [a modest proposal](https://notes.ethereum.org/@mikeneuder/increase-maxeb), the [diff view](https://github.com/michaelneuder/consensus-specs/pull/3/files) and [security considerations](https://notes.ethereum.org/@fradamt/meb-increase-security). *Note:* This specification is built upon [Deneb](../../deneb/beacon-chain.md). @@ -282,7 +282,7 @@ class BeaconBlockBody(Container): voluntary_exits: List[SignedVoluntaryExit, MAX_VOLUNTARY_EXITS] sync_aggregate: SyncAggregate # Execution - execution_payload: ExecutionPayload + execution_payload: ExecutionPayload bls_to_execution_changes: List[SignedBLSToExecutionChange, MAX_BLS_TO_EXECUTION_CHANGES] blob_kzg_commitments: List[KZGCommitment, MAX_BLOB_COMMITMENTS_PER_BLOCK] consolidations: List[SignedConsolidation, MAX_CONSOLIDATIONS] # [New in EIP-7251] @@ -386,7 +386,7 @@ def get_churn_limit(state: BeaconState) -> Gwei: Return the churn limit for the current epoch. """ churn = max( - MIN_PER_EPOCH_CHURN_LIMIT_EIP7251, + MIN_PER_EPOCH_CHURN_LIMIT_EIP7251, get_total_active_balance(state) // CHURN_LIMIT_QUOTIENT ) return churn - churn % EFFECTIVE_BALANCE_INCREMENT @@ -472,7 +472,6 @@ def queue_excess_active_balance(state: BeaconState, index: ValidatorIndex) -> No #### New `compute_exit_epoch_and_update_churn` - ```python def compute_exit_epoch_and_update_churn(state: BeaconState, exit_balance: Gwei) -> Epoch: earliest_exit_epoch = compute_activation_exit_epoch(get_current_epoch(state)) @@ -570,12 +569,16 @@ def process_epoch(state: BeaconState) -> None: #### Updated `process_registry_updates` +`process_registry_updates` uses the updated definition of `initiate_validator_exit` +and changes how the activation epochs are computed for eligible validators. + ```python def process_registry_updates(state: BeaconState) -> None: # Process activation eligibility and ejections for index, validator in enumerate(state.validators): if is_eligible_for_activation_queue(validator): validator.activation_eligibility_epoch = get_current_epoch(state) + 1 + if ( is_active_validator(validator, get_current_epoch(state)) and validator.effective_balance <= EJECTION_BALANCE @@ -607,7 +610,7 @@ def process_pending_balance_deposits(state: BeaconState) -> None: state.pending_balance_deposits = state.pending_balance_deposits[next_deposit_index:] if len(state.pending_balance_deposits) == 0: - state.deposit_balance_to_consume = 0 + state.deposit_balance_to_consume = Gwei(0) else: state.deposit_balance_to_consume = available_for_processing - processed_amount ``` @@ -638,6 +641,8 @@ def process_pending_consolidations(state: BeaconState) -> None: #### Updated `process_effective_balance_updates` +`process_effective_balance_updates` is updated with a new limit for the maximum effective balance. + ```python def process_effective_balance_updates(state: BeaconState) -> None: # Update effective balances with hysteresis @@ -760,7 +765,7 @@ def process_withdrawals(state: BeaconState, payload: ExecutionPayload) -> None: state.next_withdrawal_validator_index = next_validator_index ``` -#### Operations +#### Operations ##### Updated `process_operations` @@ -779,14 +784,16 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: for_ops(body.deposits, process_deposit) # [Modified in EIP7251] for_ops(body.voluntary_exits, process_voluntary_exit) # [Modified in EIP7251] for_ops(body.bls_to_execution_changes, process_bls_to_execution_change) - for_ops(body.execution_payload.withdraw_requests, process_execution_layer_withdraw_request) # New in EIP7251 - for_ops(body.consolidations, process_consolidation) # New in EIP7251 + for_ops(body.execution_payload.withdraw_requests, process_execution_layer_withdraw_request) # [New in EIP7251] + for_ops(body.consolidations, process_consolidation) # [New in EIP7251] ``` ##### Deposits ###### Updated `apply_deposit` +*NOTE*: `process_deposit` is updated with a new definition of `apply_deposit`. + ```python def apply_deposit(state: BeaconState, pubkey: BLSPubkey, @@ -819,7 +826,7 @@ def apply_deposit(state: BeaconState, def is_valid_deposit_signature(pubkey: BLSPubkey, withdrawal_credentials: Bytes32, amount: uint64, - signature: BLSSignature) -> None: + signature: BLSSignature) -> bool: deposit_message = DepositMessage( pubkey=pubkey, withdrawal_credentials=withdrawal_credentials, @@ -862,7 +869,7 @@ def get_validator_from_deposit(pubkey: BLSPubkey, withdrawal_credentials: Bytes3 ) ``` -##### Withdrawals +##### Withdrawals ###### New `process_execution_layer_withdraw_request` @@ -874,7 +881,7 @@ def process_execution_layer_withdraw_request( amount = execution_layer_withdraw_request.amount is_full_exit_request = amount == FULL_EXIT_REQUEST_AMOUNT - # If partial withdrawal queue is full, only full exits are processed + # If partial withdrawal queue is full, only full exits are processed if len(state.pending_partial_withdrawals) >= PENDING_PARTIAL_WITHDRAWALS_LIMIT and not is_full_exit_request: return @@ -947,7 +954,7 @@ def process_consolidation(state: BeaconState, signed_consolidation: SignedConsol assert source_validator.exit_epoch == FAR_FUTURE_EPOCH assert target_validator.exit_epoch == FAR_FUTURE_EPOCH # Consolidations must specify an epoch when they become valid; they are not valid before then - assert current_epoch >= consolidation.epoch + assert current_epoch >= consolidation.epoch # Verify the source and the target have Execution layer withdrawal credentials assert has_execution_withdrawal_credential(source_validator) diff --git a/specs/_features/eip7251/fork.md b/specs/_features/eip7251/fork.md index 02d73deb1..49e01ea7e 100644 --- a/specs/_features/eip7251/fork.md +++ b/specs/_features/eip7251/fork.md @@ -131,8 +131,7 @@ def upgrade_to_eip7251(pre: deneb.BeaconState) -> BeaconState: # Ensure early adopters of compounding credentials go through the activation churn for index, validator in enumerate(post.validators): if has_compounding_withdrawal_credential(validator): - queue_excess_active_balance(post, index) + queue_excess_active_balance(post, ValidatorIndex(index)) return post ``` - diff --git a/specs/_features/eip7251/validator.md b/specs/_features/eip7251/validator.md new file mode 100644 index 000000000..455699383 --- /dev/null +++ b/specs/_features/eip7251/validator.md @@ -0,0 +1,73 @@ +# EIP-7251 -- Honest Validator + +## Table of contents + + + + + +- [Introduction](#introduction) +- [Prerequisites](#prerequisites) +- [Beacon chain responsibilities](#beacon-chain-responsibilities) + - [Block and sidecar proposal](#block-and-sidecar-proposal) + - [Constructing the `BeaconBlockBody`](#constructing-the-beaconblockbody) + - [ExecutionPayload](#executionpayload) + + + + +## Introduction + +This document represents the changes to be made in the code of an "honest validator". + +## Prerequisites + +This document is an extension of the [Deneb -- Honest Validator](../deneb/validator.md) guide. +All behaviors and definitions defined in this document, and documents it extends, carry over unless explicitly noted or overridden. + +All terminology, constants, functions, and protocol mechanics defined in the updated [Beacon Chain doc of EIP-7251](./beacon-chain.md) are requisite for this document and used throughout. +Please see related Beacon Chain doc before continuing and use them as a reference throughout. + +## Beacon chain responsibilities + +All validator responsibilities remain unchanged other than those noted below. + +### Block and sidecar proposal + +#### Constructing the `BeaconBlockBody` + +##### ExecutionPayload + +`prepare_execution_payload` is updated from the Deneb specs. + +*Note*: In this section, `state` is the state of the slot for the block proposal _without_ the block yet applied. +That is, `state` is the `previous_state` processed through any empty slots up to the assigned slot using `process_slots(previous_state, slot)`. + +*Note*: The only change to `prepare_execution_payload` is the new definition of `get_expected_withdrawals`. + +```python +def prepare_execution_payload(state: BeaconState, + safe_block_hash: Hash32, + finalized_block_hash: Hash32, + suggested_fee_recipient: ExecutionAddress, + execution_engine: ExecutionEngine) -> Optional[PayloadId]: + # Verify consistency of the parent hash with respect to the previous execution payload header + parent_hash = state.latest_execution_payload_header.block_hash + + # Set the forkchoice head and initiate the payload build process + withdrawals, _ = get_expected_withdrawals(state) # [Modified in EIP-7251] + + payload_attributes = PayloadAttributes( + timestamp=compute_timestamp_at_slot(state, state.slot), + prev_randao=get_randao_mix(state, get_current_epoch(state)), + suggested_fee_recipient=suggested_fee_recipient, + withdrawals=withdrawals, + parent_beacon_block_root=hash_tree_root(state.latest_block_header), + ) + return execution_engine.notify_forkchoice_updated( + head_block_hash=parent_hash, + safe_block_hash=safe_block_hash, + finalized_block_hash=finalized_block_hash, + payload_attributes=payload_attributes, + ) +``` From a80a7775896c7cd8d9ae077be383ac23c3e68a4b Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Sat, 6 Apr 2024 11:15:03 -0600 Subject: [PATCH 19/25] add missing extended types for EIP-7251 --- specs/_features/eip7251/beacon-chain.md | 55 +++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 5a99ad4d4..8434e8378 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -30,6 +30,8 @@ - [Extended Containers](#extended-containers) - [`BeaconState`](#beaconstate) - [`BeaconBlockBody`](#beaconblockbody) + - [`ExecutionPayload`](#executionpayload) + - [`ExecutionPayloadHeader`](#executionpayloadheader) - [Helpers](#helpers) - [Predicates](#predicates) - [Updated `is_eligible_for_activation_queue`](#updated-is_eligible_for_activation_queue) @@ -136,6 +138,7 @@ The following values are (non-configurable) constants used throughout the specif | Name | Value | Description | | - | - | - | +| `MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD` | `uint64(16)` | | `MAX_PARTIAL_WITHDRAWALS_PER_PAYLOAD` | `uint64(2**3)` (= 8) | Maximum amount of partial withdrawals allowed in each payload | ### State list lengths @@ -288,6 +291,58 @@ class BeaconBlockBody(Container): consolidations: List[SignedConsolidation, MAX_CONSOLIDATIONS] # [New in EIP-7251] ``` +#### `ExecutionPayload` + +```python +class ExecutionPayload(Container): + # Execution block header fields + parent_hash: Hash32 + fee_recipient: ExecutionAddress # 'beneficiary' in the yellow paper + state_root: Bytes32 + receipts_root: Bytes32 + logs_bloom: ByteVector[BYTES_PER_LOGS_BLOOM] + prev_randao: Bytes32 # 'difficulty' in the yellow paper + block_number: uint64 # 'number' in the yellow paper + gas_limit: uint64 + gas_used: uint64 + timestamp: uint64 + extra_data: ByteList[MAX_EXTRA_DATA_BYTES] + base_fee_per_gas: uint256 + # Extra payload fields + block_hash: Hash32 # Hash of execution block + transactions: List[Transaction, MAX_TRANSACTIONS_PER_PAYLOAD] + withdrawals: List[Withdrawal, MAX_WITHDRAWALS_PER_PAYLOAD] + blob_gas_used: uint64 + excess_blob_gas: uint64 + withdraw_requests: List[ExecutionLayerWithdrawRequest, MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD] # [New in EIP-7251] +``` + +#### `ExecutionPayloadHeader` + +```python +class ExecutionPayloadHeader(Container): + # Execution block header fields + parent_hash: Hash32 + fee_recipient: ExecutionAddress + state_root: Bytes32 + receipts_root: Bytes32 + logs_bloom: ByteVector[BYTES_PER_LOGS_BLOOM] + prev_randao: Bytes32 + block_number: uint64 + gas_limit: uint64 + gas_used: uint64 + timestamp: uint64 + extra_data: ByteList[MAX_EXTRA_DATA_BYTES] + base_fee_per_gas: uint256 + # Extra payload fields + block_hash: Hash32 # Hash of execution block + transactions_root: Root + withdrawals_root: Root + blob_gas_used: uint64 + excess_blob_gas: uint64 + withdraw_requests_root: Root # [New in EIP-7251] +``` + ## Helpers ### Predicates From b5d7bd0a8afb7bb34ad5de297aceef99e8823edf Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Sat, 6 Apr 2024 11:38:33 -0600 Subject: [PATCH 20/25] bugfix: voluntary exit processing in EIP-7251 --- specs/_features/eip7251/beacon-chain.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 8434e8378..75eae939d 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -1051,12 +1051,12 @@ def process_voluntary_exit(state: BeaconState, signed_voluntary_exit: SignedVolu assert get_current_epoch(state) >= voluntary_exit.epoch # Verify the validator has been active long enough assert get_current_epoch(state) >= validator.activation_epoch + SHARD_COMMITTEE_PERIOD - # Verify signature - domain = get_domain(state, DOMAIN_VOLUNTARY_EXIT, voluntary_exit.epoch) - signing_root = compute_signing_root(voluntary_exit, domain) - assert bls.Verify(validator.pubkey, signing_root, signed_voluntary_exit.signature) # Only exit validator if it has no pending withdrawals in the queue assert get_pending_balance_to_withdraw(state, voluntary_exit.validator_index) == 0 # [New in EIP7251] + # Verify signature + domain = compute_domain(DOMAIN_VOLUNTARY_EXIT, CAPELLA_FORK_VERSION, state.genesis_validators_root) + signing_root = compute_signing_root(voluntary_exit, domain) + assert bls.Verify(validator.pubkey, signing_root, signed_voluntary_exit.signature) # Initiate exit initiate_validator_exit(state, voluntary_exit.validator_index) ``` From 61168e6124e1b5c7359ff131ca779e4c1768b68a Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Sat, 6 Apr 2024 13:30:12 -0600 Subject: [PATCH 21/25] spec bugfix: incorrect `process_epoch` definition --- specs/_features/eip7251/beacon-chain.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 75eae939d..c40b0faa1 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -620,6 +620,9 @@ def process_epoch(state: BeaconState) -> None: process_effective_balance_updates(state) # [Modified in EIP7251] process_slashings_reset(state) process_randao_mixes_reset(state) + process_historical_summaries_update(state) + process_participation_flag_updates(state) + process_sync_committee_updates(state) ``` #### Updated `process_registry_updates` From 8cf2fd50f601008f79be79d925f7621262dbd887 Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Sat, 6 Apr 2024 14:21:36 -0600 Subject: [PATCH 22/25] add EIP-7251 `initialize_beacon_state_from_eth1` function --- specs/_features/eip7251/beacon-chain.md | 59 +++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index c40b0faa1..ab627c90a 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -77,6 +77,7 @@ - [New `process_consolidation`](#new-process_consolidation) - [Voluntary exits](#voluntary-exits) - [Updated `process_voluntary_exit`](#updated-process_voluntary_exit) +- [Testing](#testing) @@ -1063,3 +1064,61 @@ def process_voluntary_exit(state: BeaconState, signed_voluntary_exit: SignedVolu # Initiate exit initiate_validator_exit(state, voluntary_exit.validator_index) ``` + +## Testing + +*Note*: The function `initialize_beacon_state_from_eth1` is modified for pure EIP-7251 testing only. + +```python +def initialize_beacon_state_from_eth1(eth1_block_hash: Hash32, + eth1_timestamp: uint64, + deposits: Sequence[Deposit], + execution_payload_header: ExecutionPayloadHeader=ExecutionPayloadHeader() + ) -> BeaconState: + fork = Fork( + previous_version=EIP7251_FORK_VERSION, # [Modified in EIP-7251] for testing only + current_version=EIP7251_FORK_VERSION, # [Modified in EIP-7251] + epoch=GENESIS_EPOCH, + ) + state = BeaconState( + genesis_time=eth1_timestamp + GENESIS_DELAY, + fork=fork, + eth1_data=Eth1Data(block_hash=eth1_block_hash, deposit_count=uint64(len(deposits))), + latest_block_header=BeaconBlockHeader(body_root=hash_tree_root(BeaconBlockBody())), + randao_mixes=[eth1_block_hash] * EPOCHS_PER_HISTORICAL_VECTOR, # Seed RANDAO with Eth1 entropy + ) + + # Process deposits + leaves = list(map(lambda deposit: deposit.data, deposits)) + for index, deposit in enumerate(deposits): + deposit_data_list = List[DepositData, 2**DEPOSIT_CONTRACT_TREE_DEPTH](*leaves[:index + 1]) + state.eth1_data.deposit_root = hash_tree_root(deposit_data_list) + process_deposit(state, deposit) + + # Process deposit balance updates + for deposit in state.pending_balance_deposits: + increase_balance(state, deposit.index, deposit.amount) + state.pending_balance_deposits = [] + + # Process activations + for index, validator in enumerate(state.validators): + balance = state.balances[index] + validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, MAX_EFFECTIVE_BALANCE) + if validator.effective_balance == MAX_EFFECTIVE_BALANCE: + validator.activation_eligibility_epoch = GENESIS_EPOCH + validator.activation_epoch = GENESIS_EPOCH + + # Set genesis validators root for domain separation and chain versioning + state.genesis_validators_root = hash_tree_root(state.validators) + + # Fill in sync committees + # Note: A duplicate committee is assigned for the current and next committee at genesis + state.current_sync_committee = get_next_sync_committee(state) + state.next_sync_committee = get_next_sync_committee(state) + + # Initialize the execution payload header + # If empty, will initialize a chain that has not yet gone through the Merge transition + state.latest_execution_payload_header = execution_payload_header + + return state +``` From 64da0da132f6a677b60b68a27e66aa16ed04a526 Mon Sep 17 00:00:00 2001 From: Mikhail Kalinin Date: Sun, 7 Apr 2024 18:15:01 +0600 Subject: [PATCH 23/25] Fix has_sufficient_effective_balance computation --- specs/_features/eip7251/beacon-chain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/_features/eip7251/beacon-chain.md b/specs/_features/eip7251/beacon-chain.md index 9fbc587c5..7d7e78d4a 100644 --- a/specs/_features/eip7251/beacon-chain.md +++ b/specs/_features/eip7251/beacon-chain.md @@ -686,7 +686,7 @@ def get_expected_withdrawals(state: BeaconState) -> Tuple[Sequence[Withdrawal], break validator = state.validators[withdrawal.index] - has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE + has_sufficient_effective_balance = validator.effective_balance >= MIN_ACTIVATION_BALANCE has_excess_balance = state.balances[withdrawal.index] > MIN_ACTIVATION_BALANCE if validator.exit_epoch == FAR_FUTURE_EPOCH and has_sufficient_effective_balance and has_excess_balance: withdrawable_balance = min(state.balances[withdrawal.index] - MIN_ACTIVATION_BALANCE, withdrawal.amount) From 3cf3e21504a661b8af9ab744f83ffac8b2fd4ec4 Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Mon, 8 Apr 2024 16:28:17 -0600 Subject: [PATCH 24/25] Update beacon-chain.md --- specs/_features/eip7002/beacon-chain.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/specs/_features/eip7002/beacon-chain.md b/specs/_features/eip7002/beacon-chain.md index 39b03e878..58af0d540 100644 --- a/specs/_features/eip7002/beacon-chain.md +++ b/specs/_features/eip7002/beacon-chain.md @@ -222,7 +222,10 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: ```python def process_execution_layer_exit(state: BeaconState, execution_layer_exit: ExecutionLayerExit) -> None: validator_pubkeys = [v.pubkey for v in state.validators] - validator_index = ValidatorIndex(validator_pubkeys.index(execution_layer_exit.validator_pubkey)) + pubkey_to_exit = execution_layer_exit.validator_pubkey + if pubkey_to_exit not in validator_pubkeys: + return + validator_index = ValidatorIndex(validator_pubkeys.index(pubkey_to_exit)) validator = state.validators[validator_index] # Verify withdrawal credentials From 1db1c5432365cd3b480b535d960b3c1c973c970f Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Tue, 9 Apr 2024 10:33:48 +0800 Subject: [PATCH 25/25] add comment --- specs/_features/eip7002/beacon-chain.md | 1 + 1 file changed, 1 insertion(+) diff --git a/specs/_features/eip7002/beacon-chain.md b/specs/_features/eip7002/beacon-chain.md index 58af0d540..712111920 100644 --- a/specs/_features/eip7002/beacon-chain.md +++ b/specs/_features/eip7002/beacon-chain.md @@ -222,6 +222,7 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: ```python def process_execution_layer_exit(state: BeaconState, execution_layer_exit: ExecutionLayerExit) -> None: validator_pubkeys = [v.pubkey for v in state.validators] + # Verify pubkey exists pubkey_to_exit = execution_layer_exit.validator_pubkey if pubkey_to_exit not in validator_pubkeys: return