From b7e0b88cb18a9e726af9ff1e7828c778de899d77 Mon Sep 17 00:00:00 2001 From: Hsiao-Wei Wang Date: Sun, 29 Oct 2023 03:28:57 +0800 Subject: [PATCH] Fix test --- specs/deneb/p2p-interface.md | 6 ++++-- .../test/deneb/unittests/validator/test_validator.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/specs/deneb/p2p-interface.md b/specs/deneb/p2p-interface.md index 9fd61c7ed..5d640ddf5 100644 --- a/specs/deneb/p2p-interface.md +++ b/specs/deneb/p2p-interface.md @@ -101,10 +101,12 @@ class BlobIdentifier(Container): ```python def verify_blob_sidecar_inclusion_proof(blob_sidecar: BlobSidecar) -> bool: - return is_valid_merkle_path( + gindex = get_generalized_index(BeaconBlockBody, 'blob_kzg_commitments', blob_sidecar.index) + return is_valid_merkle_branch( leaf=blob_sidecar.kzg_commitment.hash_tree_root(), branch=blob_sidecar.commitment_inclusion_proof, - gindex=get_generalized_index(BeaconBlockBody, 'blob_kzg_commitments', blob_sidecar.index), + depth=floorlog2(gindex), + index=get_subtree_index(gindex), root=blob_sidecar.signed_block_header.message.body_root, ) ``` diff --git a/tests/core/pyspec/eth2spec/test/deneb/unittests/validator/test_validator.py b/tests/core/pyspec/eth2spec/test/deneb/unittests/validator/test_validator.py index 52374d42f..8adea7d31 100644 --- a/tests/core/pyspec/eth2spec/test/deneb/unittests/validator/test_validator.py +++ b/tests/core/pyspec/eth2spec/test/deneb/unittests/validator/test_validator.py @@ -55,5 +55,5 @@ def test_blob_sidecar_inclusion_proof_incorrect(spec, state): for blob_sidecar in blob_sidecars: block = blob_sidecar.signed_block_header.message - block = block.body_root = hash_tree_root(block.body_root) # mutate body root to break proof + block.body_root = spec.hash(block.body_root) # mutate body root to break proof assert not spec.verify_blob_sidecar_inclusion_proof(blob_sidecar)