From df7c2c538a3bf76c82150a3a395f3145d8d487af Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Wed, 13 May 2020 14:41:37 +0100 Subject: [PATCH] Require deposit amount to fit into uint64 (#9) Ref https://github.com/ethereum/eth2.0-specs/issues/1726 --- deposit_contract.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deposit_contract.sol b/deposit_contract.sol index 0f751969e..81c33a288 100644 --- a/deposit_contract.sol +++ b/deposit_contract.sol @@ -82,6 +82,7 @@ contract DepositContract is IDepositContract { // Check deposit amount uint deposit_amount = msg.value / GWEI; require(deposit_amount >= MIN_DEPOSIT_AMOUNT); + require(deposit_amount < 2**64); // Length checks for safety require(pubkey.length == PUBKEY_LENGTH); @@ -89,7 +90,6 @@ contract DepositContract is IDepositContract { require(signature.length == SIGNATURE_LENGTH); // FIXME: these are not the Vyper code, but should verify they are not needed - // assert(deposit_amount <= 2**64-1); // assert(deposit_count <= 2**64-1); // Emit `DepositEvent` log