From ecefe2d14791675ec9c1e0b62ed16cbf2251a585 Mon Sep 17 00:00:00 2001 From: djrtwo Date: Tue, 20 Jun 2023 15:50:20 -0600 Subject: [PATCH] pr review --- .gitignore | 1 - specs/deneb/p2p-interface.md | 4 ++-- tests/core/pyspec/eth2spec/test/deneb/sanity/test_blocks.py | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index bee57e2c6..2ff10cf09 100644 --- a/.gitignore +++ b/.gitignore @@ -22,7 +22,6 @@ tests/core/pyspec/eth2spec/bellatrix/ tests/core/pyspec/eth2spec/capella/ tests/core/pyspec/eth2spec/deneb/ tests/core/pyspec/eth2spec/eip6110/ -tests/core/pyspec/eth2spec/eip7045/ tests/core/pyspec/eth2spec/whisk/ # coverage reports diff --git a/specs/deneb/p2p-interface.md b/specs/deneb/p2p-interface.md index f073b50f5..f857ffdf1 100644 --- a/specs/deneb/p2p-interface.md +++ b/specs/deneb/p2p-interface.md @@ -25,7 +25,7 @@ The specification of these changes continues in the same format as the network s - [`blob_sidecar_{subnet_id}`](#blob_sidecar_subnet_id) - [`beacon_aggregate_and_proof`](#beacon_aggregate_and_proof) - [Attestation subnets](#attestation-subnets) - - [`beacon_attestation_{subnet_id}](#beacon_attestation_subnet_id) + - [`beacon_attestation_{subnet_id}`](#beacon_attestation_subnet_id) - [Transitioning the gossip](#transitioning-the-gossip) - [The Req/Resp domain](#the-reqresp-domain) - [Messages](#messages) @@ -178,7 +178,7 @@ The following validations are added in its place: ##### Attestation subnets -###### `beacon_attestation_{subnet_id} +###### `beacon_attestation_{subnet_id}` *[Modified in Deneb:EIP7045]* diff --git a/tests/core/pyspec/eth2spec/test/deneb/sanity/test_blocks.py b/tests/core/pyspec/eth2spec/test/deneb/sanity/test_blocks.py index 3b2a767f0..c64efe747 100644 --- a/tests/core/pyspec/eth2spec/test/deneb/sanity/test_blocks.py +++ b/tests/core/pyspec/eth2spec/test/deneb/sanity/test_blocks.py @@ -79,7 +79,7 @@ def test_include_attestation_from_previous_fork_with_new_range(spec, state): # Generate an attestation for slot 0 of this epoch attestation = get_valid_attestation(spec, state, signed=True) - # Transition to second to last slot in `DENEB_FORK_EPOCH + # Transition to second to last slot in `DENEB_FORK_EPOCH` next_epoch_via_block(spec, state) current_epoch = spec.get_current_epoch(state) assert current_epoch == spec.config.DENEB_FORK_EPOCH