Danny Ryan
3f2d5ecda7
Merge pull request #2838 from ethereum/revert-dupe-condition
...
revert removal of aggregate deduplication condition from #2183
2022-02-28 08:19:45 -07:00
Danny Ryan
03f0f6762a
revert removal of aggregate deduplication condition from #2183
2022-02-25 10:25:27 -07:00
Jacek Sieka
9fb2dd16c1
Ignore attestations voting for the wrong finalized checkpoint
...
When nodes are syncing but have not yet reached the canonical `head`,
they cannot determine whether nodes they are connected to serve a valid
history or are making bogus claims in their `Status` advertisement.
Thus, the best course of action that a client can take is to vote for
its "current" best synced head, regardless of whether it's connected to
peers that claim to have other heads or not.
However, in the p2p spec, we penalize such peers with a `REJECT` - this
should be an `IGNORE` instead because this vote is correct per the spec,
albeit "late" according to the validating clients' view of the chain.
2022-02-11 17:12:13 +01:00
Etan Kissling
20c8d0d641
Update reserved libp2p error documentation
...
The spec reserves the libp2p error code range `[3, 127]` for future use
but actually defines error code `3` as `ResourceUnavailable`. This patch
updates the reserved range to `[4, 127]`.
2022-01-28 00:33:38 +01:00
Hsiao-Wei Wang
206126644f
More fixes
2021-08-19 23:34:54 +08:00
Hsiao-Wei Wang
59d8ee34f9
Update some "1.0" "2.0" wording
2021-08-19 23:24:04 +08:00
Danny Ryan
4c1156d504
rename eth1 and eth2 throughout specs and readme where reasonable
2021-08-18 17:13:24 -06:00
Danny Ryan
bca467c926
fmt
2021-05-21 14:36:43 -06:00
Danny Ryan
5bf01c4298
add resourceunavailable error code with more guidance
2021-05-21 14:24:58 -06:00
Danny Ryan
110e6b38ee
remove resourceunavailable for more discussion
2021-05-14 08:07:08 -06:00
Danny Ryan
f52f067b8e
add resourceunavailable error code
2021-05-12 08:36:27 -06:00
Danny Ryan
82b7a7be3b
Apply suggestions from code review
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com >
Co-authored-by: Jacek Sieka <jacek@status.im >
2021-05-12 08:29:42 -06:00
Danny Ryan
488ceed4f9
add notes about repeatedly failing tos erve blocks as being disconncetable
2021-05-11 11:29:37 -06:00
Danny Ryan
5792afca46
Merge branch 'dev' into bbr-ws
2021-05-11 09:51:57 -06:00
Danny Ryan
ed6358a719
Merge pull request #2248 from hukkinj1/dev
...
Fix list indentation
2021-03-30 07:32:35 -06:00
protolambda
07b7774241
misc. phase1 modules refactor updates
2021-03-30 01:46:02 +02:00
Taneli Hukkinen
b23b16c7b7
Fix list indentation
2021-03-29 01:10:36 +03:00
Danny Ryan
dd341adc20
remove faulty de-duplication condition for seen aggregates
2021-03-10 18:55:21 -07:00
Alex Stokes
e1023f55d1
Fix a small typo
2021-03-05 18:05:15 -08:00
Paul Hauner
7d715220bb
Don't propagate blocks with a faulty slot ( #2196 )
2021-02-10 12:39:42 -07:00
Phong Phan
0fd0db1ffc
Fix some typos ( #2195 )
...
* Fix typo for P2P Networking document
* Fix link typo of P2P networking document
* fix typo for light clients beacon chain document
2021-02-06 06:20:35 -07:00
protolambda
65696ca68b
fix typo: same condition, but non-aggregate attestation here
2021-01-16 22:48:22 +01:00
Danny Ryan
2ad8fdb818
add ability for node to randomly request and descore if not serving blocks on WS period
2021-01-14 06:53:04 -07:00
Danny Ryan
56aafbe533
add note about signature check when backfilling beaconblocks
2020-12-09 12:37:56 -07:00
Danny Ryan
17221c8065
more clearly define min epoch range for blocksbyrange requests
2020-12-09 12:27:01 -07:00
Hsiao-Wei Wang
64412be0d7
Minor update ToC
2020-12-07 11:10:19 +08:00
Danny Ryan
7589af8e8d
remove wip notice on phase 0 specs
2020-11-04 09:30:29 -06:00
Danny Ryan
cfc91cdef7
Merge pull request #2121 from AgeManning/gossipsub-mesh
...
Increase gossipsub mesh degree
2020-11-04 06:59:59 -06:00
Age Manning
82cdbba703
Increase mesh degree
2020-11-04 11:27:35 +11:00
Danny Ryan
b356f52c5c
ensure aggregate attestation's slot and target are consistent
2020-10-28 17:54:46 -06:00
Danny Ryan
d3d9bbd479
add note about coming gs v1.1 params
2020-10-07 17:46:20 -06:00
Danny Ryan
45de8198ca
Merge branch 'dev' into v1.0-candidate
2020-10-07 13:42:23 -06:00
Danny Ryan
64b34b5ca6
Merge pull request #2089 from ethereum/fix-message-id
...
fix message-id issues
2020-10-07 12:40:51 -06:00
Danny Ryan
8cda237884
note v5.1 in discv5 p2p spec
2020-10-07 12:13:32 -06:00
Danny Ryan
6287875baf
use domain byte to isolate message-id domains
2020-10-07 11:59:39 -06:00
Danny Ryan
a365fcb03b
fix message-id issues
2020-10-06 16:18:12 -06:00
Danny Ryan
5f9e6599e9
Merge pull request #2060 from protolambda/signing-policy
...
Use gossip signing policy in p2p spec, see libp2p/specs#294
2020-09-30 12:03:21 -06:00
Danny Ryan
157f7e8ef4
upgrade config to mainnet values
2020-09-28 12:56:08 -06:00
protolambda
62d596a910
update signature policy link
2020-09-25 17:59:09 +02:00
Danny Ryan
8c9c943845
Merge pull request #2054 from ethereum/ralexstokes-patch-1
...
Typos in: p2p-interface.md
2020-09-22 17:32:10 -06:00
Danny Ryan
a232efbeb7
revert incorrect type fix
2020-09-22 17:20:55 -06:00
protolambda
8ad0865424
Use gossip signing policy in p2p spec, see libp2p/specs#294
2020-09-15 01:15:16 +02:00
Danny Ryan
59cb56b564
Merge pull request #2044 from blacktemplar/use-raw-sha-as-message-id
...
use raw SHA256 as message-id
2020-09-14 11:25:34 -06:00
Danny Ryan
5a9fe89089
remove extraneous parens
2020-09-14 10:58:48 -06:00
Danny Ryan
89be1f5bc8
favor pythonic notation for array slices
2020-09-14 10:57:35 -06:00
blacktemplar
deb58fd21e
only use first 8 bytes of hash as message id
2020-09-14 10:09:48 +02:00
Alex Stokes
3cb15806be
Update p2p-interface.md
...
Typo fixes
2020-09-11 17:08:37 -07:00
blacktemplar
8f0b15f9f7
remove dot
2020-09-11 06:44:36 +02:00
Danny Ryan
8948f92def
Merge branch 'dev' into more_gossip_validations
2020-09-10 14:33:48 -06:00
Danny Ryan
42bf435c54
rearrange gossip conditions
2020-09-10 14:10:09 -06:00
