Commit Graph

1173 Commits

Author SHA1 Message Date
Danny Ryan
9eb3be5471 Merge branch 'dev' into JustinDrake-patch-1 2019-02-17 21:16:45 -07:00
Cayman
5fbbb4f181 Clarify merkle_root documentation (#646)
This function is used to get the merkle root of some block roots which are themselves hashes, so the leaves do not need to be rehashed.
Unfortunately, it's easy to assume that a merkle_root function would hash its leaves, so it should be clarified.
2019-02-18 12:11:01 +08:00
Cayman
eea413bcc5 Fix typos (#648) 2019-02-17 22:53:59 +00:00
Justin
4baa13050e Update 0_beacon-chain.md 2019-02-16 21:13:46 +00:00
Justin
1d95c1482c Update 0_beacon-chain.md 2019-02-16 21:11:48 +00:00
d-yokoi
f2e547e629 docs: fix typo in 0_beacon-chain.md 2019-02-16 23:12:00 +09:00
d-yokoi
464947dbd4 docs: fix typo in 0_beacon-chain.md (#640) 2019-02-16 09:11:29 +00:00
Paul Hauner
b92cd9be03 Add fix to get_shuffling
Ensures it does not try to shuffle out of range of the `active_validator_indices` list.
2019-02-16 17:55:27 +11:00
Paul Hauner
2e6bf87bdf Fix max list size for get_permutated_index 2019-02-16 17:27:47 +11:00
Danny Ryan
f932534763 Merge pull request #637 from ethereum/hwwhww-patch-2
Fix `slash_validator`
2019-02-15 09:40:24 -07:00
Jonny Rhea
e074bc2c34 Update 0_beacon-chain.md (#635)
replace vote_data with slashable_attestation in verify_slashable_attestation()
2019-02-15 14:48:09 +00:00
Hsiao-Wei Wang
984eb79f68 Fix unix time condition of an acceptable block (#636) 2019-02-15 13:46:47 +00:00
Justin
2207fd17f5 Update 0_beacon-chain.md 2019-02-15 13:37:36 +00:00
Hsiao-Wei Wang
6f856ba009 Comparing in slot 2019-02-15 18:33:22 +08:00
Hsiao-Wei Wang
e0c28a3cd0 Fix slash_validator
Define `validator` before using it.
2019-02-15 18:25:30 +08:00
Paul Hauner
2f327f36d8 Improve asset in get_permutated_index 2019-02-15 12:50:56 +11:00
Paul Hauner
267f840570 Add explicit assert to get_permutated_index
There is an implicit assert in `int_to_bytes4`, however I think it's rather hidden.
2019-02-15 11:57:23 +11:00
Justin
888b06ce4a Update 0_beacon-chain.md 2019-02-15 00:24:46 +00:00
Justin
ab140c2f1c Update 0_beacon-chain.md 2019-02-15 00:23:03 +00:00
Danny Ryan
375659dc6c name changes in validator doc and phase 1 doc 2019-02-14 16:02:01 -07:00
Justin
241ae5ed49 Merge branch 'dev' into name-changes 2019-02-14 20:48:34 +00:00
Danny Ryan
677efe5840 fix off by one attestaton issue due to attesting to post state of block (#627) 2019-02-14 20:16:19 +00:00
Paul Hauner
d7fb7729e6 Add cautionary assert in shuffling function (#622) 2019-02-14 14:14:59 +00:00
vbuterin
6c49270664 Added minimum slashing penalty of ~1 ETH (#624) 2019-02-14 14:00:12 +00:00
Justin
e86fa58167 Merge branch 'dev' into name-changes 2019-02-14 10:27:17 +00:00
vbuterin
eadfa20b99 Bring forward changes to withdrawability from phase 1 (#615)
* Bring forward changes to withdrawability from phase 1

* The `WITHDRAWABLE` flag is removed; instead, a validator's withdrawability is determined through the `withdrawable_epoch` field (renamed and re-purposed from `withdrawal_epoch` which was not used)
* When a validator passes through the withdrawal queue, the `prepare_validator_for_withdrawal` function does not let them withdraw immediately; instead, they have to wait `MIN_VALIDATOR_WITHDRAWAL_EPOCHS`. This extra minimum delay serves no value in phase 0, but is crucial for phase 1 as the period between a validator passing through the queue and the validator being eligible to withdraw is where proof of custody challenges can come in; adding it in phase 0 is only half a line of code so easier to add it now.
* If a validator is penalized, they are no longer subject to the exit queue; instead, their `withdrawable_epoch` is set `LATEST_PENALIZED_EXIT_LENGTH` into the future and this is used to determine when the validator can withdraw
* Changes the eligibility condition for a transfer to use the `withdrawable_epoch`
2019-02-14 10:20:53 +00:00
Justin
f14af7ae67 Merge branch 'dev' into name-changes 2019-02-13 23:53:38 +00:00
Danny Ryan
83b67b6097 Merge pull request #617 from ethereum/hwwhww/fix_compute_commitment
Fix `compute_commitment`
2019-02-13 11:54:03 -07:00
terence tsao
fd5c3ee8b5 Update 0_beacon-chain.md 2019-02-13 08:38:03 -08:00
Hsiao-Wei Wang
f7320ec25b Fix compute_commitment
1. Use `+` to concatenate the merkle roots in `hash` function.
2. Fix `pad_to_power_of_2`: padding with `[b'\x00' * SHARD_BLOCK_SIZE]`,
not `[SHARD_BLOCK_SIZE]`.
2019-02-14 00:30:00 +08:00
Danny Ryan
3d5aa352be Merge pull request #597 from ethereum/reward-clarifications
Reward clarifications/fix
2019-02-13 08:21:30 -07:00
terence tsao
a730295982 Update 0_beacon-chain.md (#614) 2019-02-13 01:40:24 +00:00
vbuterin
cf371c4973 Add support for transfers between withdrawn accounts (#601) 2019-02-12 22:41:38 +00:00
Justin
b6d27edd6e Update 0_beacon-chain.md 2019-02-12 22:38:29 +00:00
Danny Ryan
8213ad64e2 add note about attestations on chain voting for justified 2019-02-12 13:08:17 -08:00
Justin
bd9baeca0c Update 0_beacon-chain.md 2019-02-12 13:37:30 +00:00
Justin
d4f79c8878 Update 0_beacon-chain.md 2019-02-12 12:28:13 +00:00
Justin
de7263c838 Update 0_beacon-chain.md 2019-02-12 12:24:19 +00:00
Justin
8445d06b8f Merge branch 'dev' into name-changes 2019-02-12 11:59:05 +00:00
Jacek Sieka
f871b9a0d1 Use little endian bit order (#575)
Slightly more simple and common to find bit n at position `1 << n`
2019-02-12 11:52:07 +00:00
Hsiao-Wei Wang
41e95cf9ea Refactor get_persistent_committee (#604) 2019-02-12 11:11:45 +00:00
Paul Hauner
de90d4475e Provide definition for undefined index (#608)
The `index` variable is not defined and, IMO, it's difficult to discern.
2019-02-12 11:09:27 +00:00
Paul Hauner
3ea0c27be0 Minor modification to reduce lines of code (#607) 2019-02-12 11:06:26 +00:00
Danny Ryan
98902d12e3 assert/unhandled exception note to state transition (#606) 2019-02-11 21:30:36 +00:00
Justin
2275587149 Add note on leap seconds
Clarify the local time is Unix time and add note on leap seconds.
2019-02-11 13:29:54 +00:00
Danny Ryan
1d77c57374 clarify active validator meaning for rewards/penalties 2019-02-10 18:43:56 -07:00
Danny Ryan
e8f9dce1d3 simply reward logic for justified slot from previous epoch 2019-02-10 18:38:42 -07:00
vbuterin
db4f99d899 Fixed end of code block 2019-02-10 15:47:26 -06:00
Danny Ryan
ab44cbe380 Update specs/core/1_shard-data-chains.md
Co-Authored-By: vbuterin <v@buterin.com>
2019-02-10 15:45:57 -06:00
vbuterin
9bba3362eb Update specs/core/1_shard-data-chains.md 2019-02-10 15:45:47 -06:00