Commit Graph

97 Commits

Author SHA1 Message Date
vbuterin
b310482bce Update specs/altair/beacon-chain.md 2021-05-04 17:19:51 -07:00
vbuterin
9dcdbafba3 Reorganization of config params to put sync committee in one section
This may be marginally "cleaner" than the previous approach, keeping constants with the same topic together.
2021-05-04 17:19:15 -07:00
Hsiao-Wei Wang
9980d2098d Fix lint 2021-05-04 22:21:58 +08:00
Danny Ryan
80df9e6b0b Merge branch 'dev' into altair-pass 2021-05-04 07:41:25 -06:00
Danny Ryan
053179cee9 comments and tests on altair 2021-05-04 07:39:22 -06:00
terence tsao
930ca61690 Fix lint (124 > 120 characters) 2021-05-02 20:47:57 -07:00
terence tsao
780121f9b0 Add backticks to the arguments in functional comments 2021-05-02 20:31:52 -07:00
Danny Ryan
c3dfc2e085 Merge pull request #2362 from ethereum/sync-cleanup
Minor altair cleanups
2021-04-28 08:42:23 -06:00
Danny Ryan
e89fae86a6 Apply suggestions from code review
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-04-28 06:52:16 -06:00
Danny Ryan
9f74f1f9e5 minor sync committee cleanups 2021-04-27 15:06:45 -06:00
Danny Ryan
2628721f96 Merge pull request #2323 from ethereum/prepare_state
Simplify Altair "genesis"
2021-04-27 12:32:13 -06:00
Danny Ryan
c090d6aa21 Merge pull request #2352 from ralexstokes/add-altair-metadata-updates
Add `syncnets` data to Altair `MetaData`
2021-04-27 12:20:03 -06:00
Danny Ryan
ae429a38a0 add Modified comment 2021-04-27 12:11:15 -06:00
Alex Stokes
9bb3444c89 Add syncnets data to Altair MetaData. 2021-04-27 09:34:24 -07:00
ericsson
93378afcd0 Fix typing problem: upgrade_to_altair should use phase0.get_current_epoch 2021-04-23 18:21:29 +03:00
Alex Stokes
ebd16e1b79 add helper in p2p document to executable spec 2021-04-22 11:05:06 -07:00
Alex Stokes
3c07303c5c Update specs/altair/p2p-interface.md
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-04-22 10:34:16 -07:00
Alex Stokes
99b2cc2f3e Clarify usage of field in data 2021-04-22 10:34:16 -07:00
Alex Stokes
f992a9ae65 Remove duplicate validation 2021-04-22 10:34:16 -07:00
Alex Stokes
360a1dd598 Respect subcommittees in gossip validations for Altair 2021-04-22 10:34:15 -07:00
Diederik Loerakker
9d0bfec2d6 Merge pull request #2345 from ralexstokes/use-markdown-parser-for-literate-pyspec
Use markdown parser for literate pyspec
2021-04-22 18:05:06 +02:00
Alex Stokes
a9e3ecabbd demo spec comment feature 2021-04-21 18:49:51 -07:00
Alex Stokes
b870f92801 Update validator.md 2021-04-21 17:08:38 -07:00
Hsiao-Wei Wang
93f6a541ad PR feedback from @djrtwo 2021-04-21 16:42:54 +08:00
Hsiao-Wei Wang
2063c96c80 Merge branch 'dev' into prepare_state 2021-04-21 16:34:29 +08:00
Hsiao-Wei Wang
66e1a2858f Use ALTAIR_FORK_EPOCH instead of ALTAIR_FORK_SLOT 2021-04-21 00:24:44 +08:00
Hsiao-Wei Wang
baf4b73c18 Fix ToC 2021-04-20 23:38:48 +08:00
Hsiao-Wei Wang
666f847354 Update specs and test format note. 2021-04-20 23:37:53 +08:00
Hsiao-Wei Wang
57ac8c3f28 Fix doc 2021-04-16 11:34:50 +08:00
Hsiao-Wei Wang
b65566f184 Fix ToC 2021-04-15 15:41:12 +08:00
Hsiao-Wei Wang
8708ec4bb0 Update doc 2021-04-12 22:02:04 +08:00
Hsiao-Wei Wang
a8160f1634 Try to initialize state with pure Altair spec in tests 2021-04-10 00:53:37 +08:00
Adrian Sutton
08f9f81c1f Update note about changes to slash_validator. 2021-04-07 11:44:24 +10:00
Danny Ryan
05581e759c Merge pull request #2309 from terencechain/fix-spelling
Fix spelling
2021-04-05 18:48:40 -06:00
terence tsao
b2f42bf4d7 broadast -> broadcast 2021-04-05 17:05:59 -07:00
Alex Stokes
746d6453bc Clean up unnecessary function arguments
Some of the inputs to some functions in the Altair validator guide
were required in earlier iterations of the aggregation scheme but are
no longer required in the current version. This commit cleans up these
functions.
2021-04-05 16:56:13 -07:00
Danny Ryan
52e4ce3bcf Merge pull request #2276 from barnabemonnot/altair_incentives
Modify incentives to preserve invariant
2021-04-05 12:23:17 -06:00
Alex Stokes
bf7c61ff30 Merge pull request #2299 from ralexstokes/update-altair-p2p
Fix language with sync committee selection proofs
2021-04-05 11:03:36 -07:00
Hsiao-Wei Wang
8d60614728 Merge branch 'dev' into altair_incentives 2021-04-06 00:01:11 +08:00
Meredith Baxter
4a1126d916 Fix table formatting 2021-04-05 11:34:06 -04:00
Alex Stokes
9aaf548c37 Fix language with sync committee selection proofs 2021-04-02 18:37:30 -07:00
Justin
48fb9c39c2 Update beacon-chain.md 2021-04-02 15:05:54 +01:00
Justin
88d8f80957 Fix two bugs (and some cleanups)
Fix two bugs:

1) The participant reward (previously known as "inclusion reward") should not be proportional to `effective_balance` because a sync committee member is already chosen with probability proportional to the effective balance. Credit to @vbuterin.
2) The participant reward (previously known as "inclusion reward") was too large by a factor of `len(participant_indices)`, not taking into account the `for` loop.

Fixing these two bugs actually makes the code significantly simpler and cleaner :)

@barnabemonnot: Could you check the logic? :) If confirmed happy to update the tests.
2021-04-02 14:52:32 +01:00
Danny Ryan
acfbd9375e Merge pull request #2293 from ralexstokes/reorder-aggregation-conditions
Reorder Altair gossip validation conditions
2021-04-01 11:25:10 -06:00
Danny Ryan
b81c64fa15 Merge pull request #2287 from mbaxter/altair/change-altair-fork-default
Set tmp ALTAIR_FORK_SLOT to max value
2021-04-01 06:39:14 -06:00
Danny Ryan
b3f72075cb Merge pull request #2294 from michaelsproul/sync-committee-balance
Simplify balance calc in `process_sync_committee`
2021-04-01 06:36:41 -06:00
Adrian Sutton
45c764618a Fix missed rename from aggregate_and_proof to contribution_and_proof 2021-04-01 15:18:31 +10:00
Danny Ryan
28216cbcda fix lint
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2021-03-31 13:22:45 -06:00
Michael Sproul
e8b758f9a6 Simplify balance calc in process_sync_committee 2021-03-31 17:21:51 +11:00
Alex Stokes
b151adbd4e Reorder Altair gossip validation conditions
Validate the `selection_proof` selects the incoming validator as an
aggregator before doing other checks like committee inclusion and
(relatively) expensive signature checks.
2021-03-30 16:18:14 -07:00