Commit Graph

3628 Commits

Author SHA1 Message Date
Danny Ryan
8948f92def Merge branch 'dev' into more_gossip_validations 2020-09-10 14:33:48 -06:00
Danny Ryan
42bf435c54 rearrange gossip conditions 2020-09-10 14:10:09 -06:00
Danny Ryan
54f1abc943 Merge pull request #2036 from ethereum/typing_clean
Non-substantive typing clean-up
2020-09-10 14:07:32 -06:00
Hsiao-Wei Wang
6e900f4fcc Add more typings, no substantive change 2020-09-03 19:27:16 +08:00
Hsiao-Wei Wang
eed2df37f4 Make linter happy 2020-09-03 17:27:20 +08:00
vbuterin
b35f8fff74 Add a constant for slash penalty multiplier
Make the multipler on slashed penalties (if portion `p` of validators are slashed each one loses `k*p` an explicit constant).
2020-09-02 12:26:27 +08:00
lsankar4033
a156f3821f Add two more attestation gossip validations 2020-08-26 16:18:38 -07:00
lsankar4033
a4acd38981 fix typo 2020-08-26 16:11:42 -07:00
tintinweb
c3ff87461f fix typo 2020-08-21 12:10:10 +02:00
Danny Ryan
e56b7cb4c0 Merge pull request #2022 from ethereum/state-for-block
clarify what 'state' is for block proposals in validator guide
2020-08-20 17:39:57 -06:00
Danny Ryan
e323260a4a fix some confusing language in validtor guide 2020-08-20 17:03:49 -06:00
Danny Ryan
444cd0249a minot typo fix
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2020-08-20 16:53:09 -06:00
Danny Ryan
9742b3a157 clarify what 'state' is for block proposals in validator guide 2020-08-19 09:58:02 -06:00
Hsiao-Wei Wang
adf8698778 Update the docs and remove unused code 2020-08-18 00:58:08 +08:00
Hsiao-Wei Wang
643611aa6d Merge pull request #2010 from ethereum/fix-shard-count
Fix active shard count issues
2020-08-12 03:05:16 +08:00
Danny Ryan
2a41c516d3 Merge pull request #2001 from lsankar4033/attestation-epoch-consistency
Add self-consistency check to attestation gossip validation
2020-08-11 12:59:19 -06:00
vbuterin
1f767ca8b9 Remove AttestationCustodyBitWrapper
Seems like this class is extraneous ever since we added Dankrad's 0.001 bit custody game.
2020-08-11 12:35:31 +08:00
Danny Ryan
8b39d41145 PR feedback 2020-08-10 13:06:20 -06:00
terence tsao
77b933035c Update apply_shard_transition comments 2020-08-10 07:15:54 -07:00
terence tsao
d22e02f20a Update specs/phase1/beacon-chain.md
Co-authored-by: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-08-10 06:26:52 -07:00
terence tsao
729e21cbcf apply_shard_transition: copy shard state 2020-08-08 09:29:04 -07:00
Danny Ryan
c3ae85387c add larger validator set test for regression test for active_shard_count issue 2020-08-05 13:26:21 -06:00
Danny Ryan
56dbc17793 fix active shard count bugs 2020-08-05 12:44:31 -06:00
Danny Ryan
bf6d5ce3b6 port #2005 and rearrange conditions 2020-08-03 09:42:52 -06:00
Hsiao-Wei Wang
e3bbf3c702 Merge branch 'dev' into shard-fork-choice-fix 2020-07-29 23:55:30 +08:00
Hsiao-Wei Wang
bd5346b624 Merge pull request #1989 from ethereum/enable-bls-citest
Enable Milagro BLS in CI
2020-07-29 23:54:53 +08:00
lsankar4033
3a0dd2b253 Add self-consistency check to attestation gossip validation 2020-07-28 17:51:32 -07:00
Hsiao-Wei Wang
b58633ce5d Quick fix the phase 1 configurations and tests (#1990)
* Quick fix the configurations

* Remove the unused `CUSTODY_RESPONSE_DEADLINE`
2020-07-29 02:06:25 +08:00
Danny Ryan
f6da7323fe Merge pull request #1999 from ethereum/genesis-comments
add clarifying comment for genesis skip conditions
2020-07-28 12:31:54 -04:00
Hsiao-Wei Wang
f6fd151872 Merge branch 'dev' into shard-fork-choice-fix 2020-07-29 00:15:41 +08:00
Hsiao-Wei Wang
b1eb157539 Merge branch 'dev' into hwwhww/phase-1-fork-slot 2020-07-28 23:59:19 +08:00
Danny Ryan
b529d47a3b pr feedback 2020-07-28 11:48:45 -04:00
Hsiao-Wei Wang
a8370f7448 Apply refactoring suggestions from Danny 2020-07-28 21:51:00 +08:00
Danny Ryan
235fb7e2a5 add clarifying comment for genesis skip conditions 2020-07-28 06:48:16 -04:00
Danny Ryan
049e087da0 Merge pull request #1996 from status-im/epoch-check
process_attestation: Validate epoch before using it
2020-07-24 08:04:06 -06:00
Jacek Sieka
6f7652d330 process_attestation: Validate epoch before using it
`data.target.epoch` is used to count the active validator set.

Because `get_committee_count_per_slot` is extremely inefficient the way
the spec is written, clients cache it, or the underlying active
validator set.

Performing the checks in the given order leads to a (very unlikely)
security issue where the a cold and above all, distant value may get
used which may be costly - reordering the checks brings the value into a
more reasonable range before using it.
2020-07-24 07:26:37 +02:00
Danny Ryan
607041225f split config vs constants in deposit-contract spec 2020-07-23 15:05:25 -06:00
Danny Ryan
4c3f866a0f add links for network and chain id 2020-07-23 12:25:44 -06:00
Hsiao-Wei Wang
e7f070d525 Use hash_tree_root to generate ShardBlockHeader.body_root
Include the mix-in length to the proof.
2020-07-24 02:09:25 +08:00
Danny Ryan
9193a23f8e add chain id and netowrk id to config 2020-07-23 12:05:22 -06:00
Diederik Loerakker
247da83e62 Merge pull request #1985 from ethereum/non-viable-gossip
add that current block is in the same chain as finalized ancestor
2020-07-23 19:18:53 +02:00
Danny Ryan
3cf6832198 Apply suggestions from code review
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-07-23 10:46:31 -06:00
Danny Ryan
b3e49ff0d3 add finalized ancestor checks to attestation gossip 2020-07-23 10:39:04 -06:00
Danny Ryan
fb13f67cca add that current block is in the same chain as finalized ancestor 2020-07-23 10:13:42 -06:00
Danny Ryan
289564aec0 pr feedback 2020-07-23 10:03:43 -06:00
Danny Ryan
a64b8eba6e remove 'ssz' format from req/resp. now only ssz_snappy 2020-07-23 09:37:16 -06:00
Hsiao-Wei Wang
cd8bb3d85a Update v-guide: Shard head root 2020-07-22 23:39:18 +08:00
Hsiao-Wei Wang
33e56b5742 Apply Terence's suggestion: refactor on_shard_block interface 2020-07-22 22:48:52 +08:00
Danny Ryan
435f70208b Merge pull request #1958 from ethereum/gossip-params
Match gossip v1.1 D_low, extend gossip_history param, add FAQ section
2020-07-21 18:18:25 -06:00
Danny Ryan
50cd0b2b31 Update specs/phase0/p2p-interface.md
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-07-21 17:49:39 -06:00