Commit Graph

1690 Commits

Author SHA1 Message Date
Danny Ryan
b88ab250fa Merge branch 'dev' into committee-roots 2019-06-28 12:07:50 -06:00
Danny Ryan
9993a28796 lint 2019-06-28 11:26:05 -06:00
Danny Ryan
b40e2284a0 use active index root for generate seed mix in 2019-06-28 11:20:24 -06:00
Danny Ryan
5a8f3e495a set committees root for next epoch rather tahn ACTIVaTION_EXIT_DELAY in the future 2019-06-28 11:10:17 -06:00
Danny Ryan
dcb0244a4f get_attesting_indices set instead of sorted (#1225) 2019-06-28 16:19:59 +01:00
vbuterin
c764202a57 Slashing penalty calculation change (#1217)
If the exit queue is very long, then a validator may take many months to exit. With the code as currently written, however, self-slashing is a potentially lucrative route to get one's money out faster, because one can exit in 36 days.

This PR changes it so that slashing can only extend your withdrawal time, not contract it. Also, instead of the slashed balances used to calculate one's slashing penalty being those in `[withdrawal - 54 days ... withdrawal - 18 days]`, we now run the penalization algorithm once every 36 days that a validator is slashed but not withdrawn, so that it covers the 36-day period where the validator was actually slashed.  It also moves the minimum slashing penalty to the `slash_validator` function so that it is only applied once.

We also simplify the `slashed_balances` logic to be per-epoch.
2019-06-28 14:35:26 +01:00
Carl Beekhuizen
0ba933e088 Merge pull request #1209 from ethereum/early_secret_test
Resolves issue in early_secret_reveal() testing
2019-06-28 11:58:40 +02:00
Danny Ryan
140c69f2ec Merge branch 'dev' into checkpoints 2019-06-27 21:02:48 -06:00
Danny Ryan
990cc55db7 fix committee typing error 2019-06-27 16:32:10 -06:00
Justin Drake
853f5fc3f0 Apply Danny's suggestions 2019-06-27 19:05:27 +01:00
Carl Beekhuizen
543729cad4 Merge pull request #1198 from ethereum/fork-choice-epoch
modify fork choice to utilize epochs properly
2019-06-27 19:14:19 +02:00
Justin Drake
bcfe383e25 WIP 2019-06-27 08:44:44 +01:00
Diederik Loerakker
d587c4fe61 Critical fix: introduce back total-value check (#1220)
This was dropped in a376b6607f, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f8 for older dust-creation problem work around, which was dropped in the above.

The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
2019-06-26 20:21:17 +01:00
Justin Drake
8c34aa8c5f Initial draft 2019-06-26 13:20:04 +01:00
Danny Ryan
0827fbd7d5 Merge branch 'fork-choice-epoch' into checkpoints 2019-06-25 15:00:04 -06:00
Danny Ryan
c64289677f fix gethead tests 2019-06-25 14:47:46 -06:00
Danny Ryan
228195d89d get head tests 2019-06-25 11:48:55 -06:00
Alex Stokes
4986311d5b Update 0_beacon-chain.md
fix typo w/ refactor
2019-06-25 10:24:14 -06:00
Carl Beekhuizen
f29b693a9c Merge dev -> early_spec_test 2019-06-25 17:11:04 +02:00
Danny Ryan
df2a9e1b54 Merge pull request #1180 from ethereum/list-rework
pyspec-SSZ: lists-rework (enable static generalized indices) + fully python class based now.
2019-06-25 07:38:50 -06:00
JSON
20602bc92b phase 0 doc standardization b4 spec freeze (#1212) 2019-06-25 14:32:56 +01:00
Alex Stokes
37b1872634 Remove duplicate custom type definitions (#1214)
Seems to be an accidental duplication of the type defs
2019-06-25 14:30:59 +01:00
Danny Ryan
b8c0985e60 merge in fork choice. tests pass 2019-06-24 22:12:55 -06:00
Danny Ryan
bacd4b1e89 Merge branch 'fork-choice-epoch' into checkpoints 2019-06-24 21:26:28 -06:00
Danny Ryan
d9b97578c0 lint 2019-06-24 21:23:24 -06:00
Danny Ryan
751738f411 enhance fork choice testing 2019-06-24 21:01:15 -06:00
protolambda
054a157953 get rid of TypingList, add MutableSequence 2019-06-25 02:58:10 +02:00
Diederik Loerakker
45dbf5a107 Remove old Deltas reference
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-06-25 02:41:02 +02:00
Danny Ryan
0e362d36b1 pr feedback 2019-06-24 17:18:22 -06:00
Danny Ryan
d54be2b45f Merge branch 'dev' into fork-choice-epoch 2019-06-24 16:52:31 -06:00
Alex Stokes
82167ff0a3 Clarify comment on phase 0 transfers
The comment seems to imply conjunction over each case, but the code implies disjunction; at the very least it is ambiguous.

This PR makes the comment less ambiguous.
2019-06-24 15:40:37 -07:00
protolambda
9fb5806764 be explicit about input for balance sum 2019-06-25 00:24:13 +02:00
protolambda
8b88c3f43c Merge remote-tracking branch 'origin' into list-rework 2019-06-24 23:58:00 +02:00
protolambda
5989e5cd23 use Bool as base name, make Bit an alias 2019-06-24 23:56:26 +02:00
protolambda
82ae180490 clean up list limit constants 2019-06-24 23:38:36 +02:00
Justin
bb0a492fea Cleanups 2019-06-23 11:18:24 +02:00
Justin
1e2bb08a74 Cosmetic fix for consistency 2019-06-23 11:09:09 +02:00
protolambda
1408a1ee0d undo tuple wrapping 2019-06-23 00:17:54 +02:00
Justin Drake
2342c787c9 Cleanup 2019-06-22 22:54:07 +02:00
Justin Drake
98692bf9d6 Fix ToC 2019-06-22 22:52:37 +02:00
Justin Drake
e6e90c7736 Minor reorg 2019-06-22 22:51:04 +02:00
Justin Drake
181a2a876a Cleanups 2019-06-22 22:49:53 +02:00
Danny Ryan
8a732fbbcf pass on checkpoints working in testing 2019-06-22 12:00:26 -06:00
protolambda
f95e7315b4 fix get_active_validator_indices typing usage 2019-06-22 18:34:33 +02:00
protolambda
00aae07d46 type annotation clean up 2019-06-22 18:12:42 +02:00
Diederik Loerakker
b007d5aa92 Add note on default zero-values, and be explicit with state-root (#1208)
* Add note on default zero-values, and be explicit with state-root
2019-06-22 17:38:30 +02:00
protolambda
16093eb8ce Merge branch 'dev' into list-rework 2019-06-22 17:11:59 +02:00
Diederik Loerakker
c86108de00 Merge pull request #1207 from ethereum/fix_make_lint
Fix `make lint`
2019-06-22 17:07:00 +02:00
Carl Beekhuizen
a5b22e13b8 Resolves make masker sign mask 2019-06-22 16:56:16 +02:00
Justin Drake
1e1a3e5311 Avoid substraction in comparison 2019-06-22 07:34:02 +02:00