Commit Graph

470 Commits

Author SHA1 Message Date
Hsiao-Wei Wang
15a6c48a46 Merge pull request #2518 from ethereum/fix-store-justified-checkpoint
Fix fork choice store checkpoints inconsistency issue
2021-08-23 23:41:11 +08:00
Hsiao-Wei Wang
206126644f More fixes 2021-08-19 23:34:54 +08:00
Hsiao-Wei Wang
59d8ee34f9 Update some "1.0" "2.0" wording 2021-08-19 23:24:04 +08:00
Danny Ryan
4c1156d504 rename eth1 and eth2 throughout specs and readme where reasonable 2021-08-18 17:13:24 -06:00
Hsiao-Wei Wang
6ffc735642 Merge branch 'dev' into fix-store-justified-checkpoint 2021-08-17 21:28:42 +08:00
Hsiao-Wei Wang
43a1617ffa Ensure that the given PKs are valid PKs + fix typos 2021-08-04 21:25:37 +08:00
Hsiao-Wei Wang
63ca480ea3 Add condition check in on_tick to ensure that store.justified_checkpoint is a descendant of store.finalized_checkpoint 2021-07-14 20:02:28 +08:00
Danny Ryan
bca467c926 fmt 2021-05-21 14:36:43 -06:00
Danny Ryan
5bf01c4298 add resourceunavailable error code with more guidance 2021-05-21 14:24:58 -06:00
protolambda
ff021da551 change line formatting, new refence as config var implicitly takes more space 2021-05-19 17:21:30 +02:00
protolambda
291168e1e3 clarify config/preset separation, address review comments by @djrtwo 2021-05-19 17:15:34 +02:00
protolambda
2c7a68406f update config section markdown table header 2021-05-18 09:55:25 +02:00
protolambda
e4593d2d0c update with configs<>presets separation 2021-05-18 09:55:20 +02:00
protolambda
b9ffd8f640 Phase0 constant/config/preset separation 2021-05-18 09:20:41 +02:00
Danny Ryan
110e6b38ee remove resourceunavailable for more discussion 2021-05-14 08:07:08 -06:00
Danny Ryan
f52f067b8e add resourceunavailable error code 2021-05-12 08:36:27 -06:00
Danny Ryan
82b7a7be3b Apply suggestions from code review
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Jacek Sieka <jacek@status.im>
2021-05-12 08:29:42 -06:00
Danny Ryan
488ceed4f9 add notes about repeatedly failing tos erve blocks as being disconncetable 2021-05-11 11:29:37 -06:00
Danny Ryan
5792afca46 Merge branch 'dev' into bbr-ws 2021-05-11 09:51:57 -06:00
Danny Ryan
c7166a37af change eth1data block_hash type to Hash32 in phase 0 2021-04-15 06:47:11 -05:00
terence tsao
b2f42bf4d7 broadast -> broadcast 2021-04-05 17:05:59 -07:00
Danny Ryan
ed6358a719 Merge pull request #2248 from hukkinj1/dev
Fix list indentation
2021-03-30 07:32:35 -06:00
protolambda
07b7774241 misc. phase1 modules refactor updates 2021-03-30 01:46:02 +02:00
Taneli Hukkinen
b23b16c7b7 Fix list indentation 2021-03-29 01:10:36 +03:00
Alex Vlasov
020895e35d Typing problems fixes (#2271)
* Typing problem fixed: `process_block_header` passes `Bytes32()` to `state_root` of `BeaconBlockHeader`, which type is `Root`

* Typing problem fixed in `initialize_beacon_state_from_eth1`: `len` returns an `int` value, while `deposit_count=uint64` of `Eth1Data` has type `uint64`

* Typing problem fixed in `process_rewards_and_penalties`: `numerator` of type `int` passed to `weight` parameter of `get_flag_index_deltas`, which has type `uint64`

* Typing problem fixed in `process_attestation`; `False` passes as `crosslink_success` parameter of `PendingAttestation`, which has type `boolean`. `False` is an instance of `(python.)bool` and is not an instance of `(ssz.)boolean`

* Typing problem fixed: `shard_data_roots` of `ShardTransition` has type `List[Bytes32]`, but its elements are used as if they were `Root` values, e.g. in `process_chunk_challenge` method: passed to `data_root` of `CustodyChunkChallengeRecord` which has type `Root`

* Typing problem fixed in `process_custody_final_updates`: `index` has type `int`, while `validator_indices_in_records` has type `Set[ValidatorIndex]`, so tesing whether `index in validator_indices_in_records` can be risky, depending on implementation details. `ValidatorIndex(index) in validator_indices_in_records` is a safer variant.

* Typing problem fixed: `slashed` parameter of `pack_compact_validator` has type `(python.)bool`, however in `committee_to_compact_committee` a value of `(ssz.)boolean` is passed as a value of the parameter

* Typing problem fixed: `inactivity_scores` is a `List[uint64,...]`, while it is intialized/appended with values of `(python.)int` type

* fixed according to @protolambda suggestions

* changed types of _WEIGHT constants and appropriate variables/parameters, according to @protolambda suggestions

* revert code formatting back

* Introduced ZERO_ROOT according to @protolambda 's suggestion

* Reverted back to , according to @protolambda comments
2021-03-25 22:03:21 +01:00
Danny Ryan
bb85ef5a57 pr cleanup 2021-03-22 10:53:26 -06:00
protolambda
493dd17cc4 reduce justification and finalization Altair diff 2021-03-21 04:22:45 +01:00
Alex Stokes
c661ddf12c hoist container definitions to preamble 2021-03-17 09:35:39 -06:00
Danny Ryan
b8bf7f0f80 Merge pull request #2236 from ethereum/justin_altair_cleanups
Altair cosmetic cleanups plus a couple substantive changes
2021-03-15 08:57:35 -06:00
Justin Drake
e7ebd08d69 Altair cosmetic cleanups plus a couple substantive changes 2021-03-15 11:08:41 +00:00
Danny Ryan
dd341adc20 remove faulty de-duplication condition for seen aggregates 2021-03-10 18:55:21 -07:00
Alex Stokes
e1023f55d1 Fix a small typo 2021-03-05 18:05:15 -08:00
Danny Ryan
63e014791c Merge branch 'dev' into dev-merge 2021-02-24 16:23:04 -07:00
Danny Ryan
396d399129 Apply suggestions from code review form @hwwhww
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-02-24 08:53:54 -06:00
Hsiao-Wei Wang
b789b10397 Minor update ToC 2021-02-23 16:31:19 -07:00
Danny Ryan
1f7e9fabf2 minor 0x01 PR feedback 2021-02-23 16:16:46 -07:00
Danny Ryan
a0ae048395 copy edits 2021-02-23 16:16:46 -07:00
Justin
5992e8ff05 Update deposit-contract.md 2021-02-23 16:16:46 -07:00
Justin
809fc7afaf Update validator.md 2021-02-23 16:16:45 -07:00
Justin
1f8ca7179f Update validator.md 2021-02-23 16:16:45 -07:00
Justin
80613a99bd Update validator.md 2021-02-23 16:16:45 -07:00
Justin
0f94fa51b8 Update validator.md 2021-02-23 16:16:45 -07:00
Justin
e93f1e1fa8 Copy-edit deposit-contract.md 2021-02-23 16:16:45 -07:00
Justin
47ebf438b3 Cleaner section title
"Withdrawal prefixes" matches `[BLS]/[ETH1_ADDRESS]_WITHDRAWAL_PREFIX`
2021-02-23 16:16:45 -07:00
Justin
128efdd34d Fix table for withdrawal credentials prefixes
Minor cosmetic fixes (misformated table, section title).
2021-02-23 16:16:45 -07:00
Danny Ryan
7af50cc827 add eth1 withdrawal credentials to spec 2021-02-23 16:16:35 -07:00
Danny Ryan
8ec082fcf9 Merge pull request #2149 from ethereum/0x01-creds
Eth1 withdrawal credentials (0x01)
2021-02-16 13:06:34 -06:00
Danny Ryan
7050cb0add minor 0x01 PR feedback 2021-02-16 11:55:01 -07:00
Paul Hauner
7d715220bb Don't propagate blocks with a faulty slot (#2196) 2021-02-10 12:39:42 -07:00
Phong Phan
0fd0db1ffc Fix some typos (#2195)
* Fix typo for P2P Networking document

* Fix link typo of P2P networking document

* fix typo for light clients beacon chain document
2021-02-06 06:20:35 -07:00