github/consensus-specs
1
1
Fork 0
mirror of https://github.com/ethereum/consensus-specs.git synced 2026-02-03 14:44:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,159 Commits 87 Branches 114 Tags
ee712ecdde94bf00a0df44e412bd4ede2637e967
Commit Graph

2296 Commits

Author SHA1 Message Date
Justin Drake
ee712ecdde Make HW happy :) 2019-06-27 11:21:45 +01:00
protolambda
a0c2f5c6b5 fix genesis testing code, add missing constant temporarily, fix py Generator/map/list problems 2019-06-27 01:57:30 +02:00
protolambda
a62d0261ca merge with dev, fixed now 2019-06-27 01:31:10 +02:00
Diederik Loerakker
d587c4fe61 Critical fix: introduce back total-value check (#1220) 
This was dropped in a376b6607f, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f8 for older dust-creation problem work around, which was dropped in the above.

The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
 2019-06-26 20:21:17 +01:00
Justin Drake
ccda508254 Fix deposit root, add min_genesis_time, per-block processing 2019-06-26 15:34:54 +01:00
Alex Stokes
4986311d5b Update 0_beacon-chain.md 
fix typo w/ refactor
 2019-06-25 10:24:14 -06:00
Danny Ryan
df2a9e1b54 Merge pull request #1180 from ethereum/list-rework 
pyspec-SSZ: lists-rework (enable static generalized indices) + fully python class based now.
 2019-06-25 07:38:50 -06:00
JSON
20602bc92b phase 0 doc standardization b4 spec freeze (#1212) 2019-06-25 14:32:56 +01:00
Alex Stokes
37b1872634 Remove duplicate custom type definitions (#1214) 
Seems to be an accidental duplication of the type defs
 2019-06-25 14:30:59 +01:00
protolambda
054a157953 get rid of TypingList, add MutableSequence 2019-06-25 02:58:10 +02:00
Diederik Loerakker
45dbf5a107 Remove old Deltas reference 
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
 2019-06-25 02:41:02 +02:00
Alex Stokes
82167ff0a3 Clarify comment on phase 0 transfers 
The comment seems to imply conjunction over each case, but the code implies disjunction; at the very least it is ambiguous.

This PR makes the comment less ambiguous.
 2019-06-24 15:40:37 -07:00
protolambda
9fb5806764 be explicit about input for balance sum 2019-06-25 00:24:13 +02:00
protolambda
8b88c3f43c Merge remote-tracking branch 'origin' into list-rework 2019-06-24 23:58:00 +02:00
protolambda
5989e5cd23 use Bool as base name, make Bit an alias 2019-06-24 23:56:26 +02:00
protolambda
82ae180490 clean up list limit constants 2019-06-24 23:38:36 +02:00
protolambda
1408a1ee0d undo tuple wrapping 2019-06-23 00:17:54 +02:00
Justin Drake
a3f8f50bee Initialise deposit root properly 2019-06-22 23:34:09 +02:00
protolambda
f95e7315b4 fix get_active_validator_indices typing usage 2019-06-22 18:34:33 +02:00
protolambda
00aae07d46 type annotation clean up 2019-06-22 18:12:42 +02:00
Diederik Loerakker
b007d5aa92 Add note on default zero-values, and be explicit with state-root (#1208) 
* Add note on default zero-values, and be explicit with state-root
 2019-06-22 17:38:30 +02:00
protolambda
16093eb8ce Merge branch 'dev' into list-rework 2019-06-22 17:11:59 +02:00
Diederik Loerakker
c86108de00 Merge pull request #1207 from ethereum/fix_make_lint 
Fix `make lint`
 2019-06-22 17:07:00 +02:00
Justin Drake
1e1a3e5311 Avoid substraction in comparison 2019-06-22 07:34:02 +02:00
Justin Drake
613380bff4 Shorter in-line comments 2019-06-22 07:29:25 +02:00
Hsiao-Wei Wang
183fa3c776 Make linter happy 2019-06-21 23:09:11 -06:00
Hsiao-Wei Wang
6aef6c5634 Clean up 2019-06-21 22:26:15 -06:00
Hsiao-Wei Wang
b51011568a Merge branch 'dev' into test_genesis 2019-06-21 22:13:46 -06:00
Hsiao-Wei Wang
5f09212777 yield for is_genesis_trigger 2019-06-21 22:09:09 -06:00
Hsiao-Wei Wang
47b29c8456 Loose condition of effective genesis deposit 2019-06-21 21:49:13 -06:00
Hsiao-Wei Wang
8828dad786 minor updates 2019-06-21 17:07:44 -06:00
Hsiao-Wei Wang
ac34221f55 Fix is_genesis_trigger and add test case 2019-06-21 16:30:31 -06:00
Hsiao-Wei Wang
b36ffd5c41 default value of deposit_index 2019-06-21 16:10:19 -06:00
Hsiao-Wei Wang
7a16db144c Add test_genesis 2019-06-21 15:59:18 -06:00
protolambda
0b0e9a51d7 Merge branch 'dev' into list-rework 2019-06-21 23:44:01 +02:00
Hsiao-Wei Wang
f55499c0ba Fix Gwei value table (#1203) 2019-06-21 14:30:22 -06:00
protolambda
80c40f5e09 merge dev, resolve minor merge conflicts 2019-06-21 21:22:23 +02:00
Danny Ryan
acbccbc2a8 minor typo 2019-06-21 11:18:24 -06:00
Justin Drake
b46e047baa Minor simplification from #1198 2019-06-21 12:57:30 +01:00
Carl Beekhuizen
0e59c6676a Stop yielding from fork-choie tests 2019-06-21 13:00:42 +02:00
Carl Beekhuizen
f90469ea25 Move block timing assertion 1st 2019-06-21 12:19:08 +02:00
Carl Beekhuizen
e88a96c45e Apply suggestions from @drjtwo's code review 
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
 2019-06-21 12:13:22 +02:00
Hsiao-Wei Wang
e99c864ed1 Deltas = NewType('Deltas', TypingList[Gwei]) 2019-06-20 17:17:12 -06:00
protolambda
3d8466fd6e make Bit check not use "is", and remove duplicate line 2019-06-20 23:04:19 +02:00
protolambda
2d67717079 fix linting issues + make spec builder remove comments in container re-initialization part 2019-06-20 21:42:55 +02:00
Carl Beekhuizen
c26fffc154 Moves copy into SSZ container 2019-06-20 20:55:28 +02:00
Carl Beekhuizen
5f8edd6b55 Genesis block store uses genesis time 
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
 2019-06-20 20:50:17 +02:00
protolambda
f157745248 resolve some remaining list-rework rebase details 2019-06-20 20:42:19 +02:00
protolambda
4e747fb887 fixes for class based ssz typing 2019-06-20 20:25:22 +02:00
protolambda
5048b9e87a temporary fix for phase-1 spec typing 2019-06-20 20:20:45 +02:00