From 19b7b9b315ee69f791320cf3b23391c877bf5738 Mon Sep 17 00:00:00 2001 From: donosonaumczuk Date: Tue, 4 Jun 2024 11:34:16 -0300 Subject: [PATCH 1/4] fix: Fresh V2 script moved tx after unpausing hub --- script/DeployFreshLensV2.s.sol | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/script/DeployFreshLensV2.s.sol b/script/DeployFreshLensV2.s.sol index 21adc9d..b2ba4e0 100644 --- a/script/DeployFreshLensV2.s.sol +++ b/script/DeployFreshLensV2.s.sol @@ -404,19 +404,6 @@ contract DeployFreshLensV2 is Script, ForkManagement, ArrayHelpers { publicActProxy = new PublicActProxy({lensHub: address(hub)}); _logDeployedAddress(address(publicActProxy), 'PublicActProxy'); - - if (isTestnet) { - // Add PublicActProxy as a delegatedExecutor of anonymousProfileId - hub.changeDelegatedExecutorsConfig( - anonymousProfileId, - _toAddressArray(address(publicActProxy)), - _toBoolArray(true) - ); - console.log('PublicActProxy added as DelegatedExecutor of AnonymousProfileId: %s', address(publicActProxy)); - } else { - console.log('Skipping governance actions for mainnet'); - console.log('Add PublicActProxy as DelegatedExecutor of AnonymousProfileId manually!'); - } } // TODO: Use from test/ContractAddresses? @@ -549,6 +536,22 @@ contract DeployFreshLensV2 is Script, ForkManagement, ArrayHelpers { vm.startBroadcast(deployer.ownerPk); { + if (isTestnet) { + // Add PublicActProxy as a delegatedExecutor of anonymousProfileId + hub.changeDelegatedExecutorsConfig( + anonymousProfileId, + _toAddressArray(address(publicActProxy)), + _toBoolArray(true) + ); + console.log( + 'PublicActProxy added as DelegatedExecutor of AnonymousProfileId: %s', + address(publicActProxy) + ); + } else { + console.log('Skipping governance actions for mainnet'); + console.log('Add PublicActProxy as DelegatedExecutor of AnonymousProfileId manually!'); + } + // Deploy governance and proxy-admin controllable-by-contract contracts, and transfer ownership. governanceContract = new Governance(address(hub), governance.owner); _logDeployedAddress(address(governanceContract), 'GovernanceContract'); From a615c33516e3ddd5879e4fbecb656f0274166363 Mon Sep 17 00:00:00 2001 From: donosonaumczuk Date: Tue, 4 Jun 2024 11:34:44 -0300 Subject: [PATCH 2/4] misc: Remove --verify from run.sh --- script/run.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/script/run.sh b/script/run.sh index 59c1035..2789554 100644 --- a/script/run.sh +++ b/script/run.sh @@ -86,7 +86,9 @@ if [[ "$CONFIRMATION" == "y" || "$CONFIRMATION" == "Y" ]] catapulta script script/$SCRIPT_NAME.s.sol --chain $NETWORK --sig $CALLDATA --legacy --skip test --ffi --slow --skip-git exit 0 else - forge script script/$SCRIPT_NAME.s.sol:$SCRIPT_NAME --sig $CALLDATA --rpc-url $NETWORK -vv --skip test --ffi --slow --broadcast --verify + forge script script/$SCRIPT_NAME.s.sol:$SCRIPT_NAME --sig $CALLDATA --rpc-url $NETWORK -vv --skip test --ffi --slow --broadcast + # `--verify` temporarily removed because of Foundry issues. You can add it back or verify manually later. + # forge script script/$SCRIPT_NAME.s.sol:$SCRIPT_NAME --sig $CALLDATA --rpc-url $NETWORK -vv --skip test --ffi --slow --broadcast --verify fi else From 215c47af96d306c92aeef6e1a8cff17d3e8f916d Mon Sep 17 00:00:00 2001 From: donosonaumczuk Date: Tue, 4 Jun 2024 11:35:20 -0300 Subject: [PATCH 3/4] misc: Local network RPC added to .toml file --- foundry.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/foundry.toml b/foundry.toml index b78f5ee..8ba3bc3 100644 --- a/foundry.toml +++ b/foundry.toml @@ -45,6 +45,7 @@ via_ir = true polygon = "${POLYGON_RPC_URL}" mumbai = "${MUMBAI_RPC_URL}" amoy = "${AMOY_RPC_URL}" +local = "${LOCAL_RPC_URL}" [fuzz] runs = 50 From a73551b33a96ef1697e7e6c118490af46c86b3ef Mon Sep 17 00:00:00 2001 From: donosonaumczuk Date: Tue, 4 Jun 2024 11:36:23 -0300 Subject: [PATCH 4/4] misc: Local network added to addresses.json --- addresses.json | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/addresses.json b/addresses.json index a5d8be6..cdc776e 100644 --- a/addresses.json +++ b/addresses.json @@ -248,6 +248,30 @@ "ProfileCreationProxy": "0x8de25afc4B37e0AdBb58caf3dF06fAf419455404", "Treasury": "0x648Ddb72d51B5f1849586f6Fd2a95E70754A126A" }, + "local": { + "testnet": true, + "chainId": 31337, + "network": "local", + "LensProfilesGuardianTimelock": 300, + "LensHandlesGuardianTimelock": 300, + "Currencies": [], + "Modules": { + "v1": { + "collect": [], + "follow": [], + "reference": [] + }, + "v2": { + "follow": [], + "act": [], + "collect": [], + "reference": [] + } + }, + "TreasuryFee": 500, + "ProfileRoyaltyFee": 500, + "HandleRoyaltyFee": 500 + }, "example": { "testnet": true, "chainId": 69,