From d8a6f714012ce02d4c51feb75835ddcbd8127167 Mon Sep 17 00:00:00 2001
From: Ben Sparks <52714090+BenSparksCode@users.noreply.github.com>
Date: Thu, 3 Nov 2022 15:01:59 +0200
Subject: [PATCH] fix: Rename revert tests

---
 test/foundry/CollectingTest.t.sol | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/test/foundry/CollectingTest.t.sol b/test/foundry/CollectingTest.t.sol
index 761542d..13ae6d7 100644
--- a/test/foundry/CollectingTest.t.sol
+++ b/test/foundry/CollectingTest.t.sol
@@ -65,14 +65,25 @@ contract CollectingTest_Generic is CollectingTest_Base {
 
     // NEGATIVES
 
-    function testFailCollectIfNotExecutor() public {
+    function testCollectFailsIfNotExecutor() public {
         vm.expectRevert(Errors.ExecutorInvalid.selector);
         _mockCollect();
     }
 
-    function testFailCollectIfNonexistantPub() public {}
+    function testCollectFailsIfNonexistantPub() public {
+        mockCollectData.pubId = 2;
+        // Check that the publication doesn't exist.
+        assertEq(_getPub(mockCollectData.profileId, mockCollectData.pubId).profileIdPointed, 0);
 
-    function testFailCollectIfZeroPub() public {}
+        vm.startPrank(profileOwner);
+        vm.expectRevert(Errors.PublicationDoesNotExist.selector);
+        _mockCollect();
+        vm.stopPrank();
+    }
+
+    function testCollectFailsIfZeroPub() public {
+        // mockCollectData.
+    }
 
     // SCENARIOS
 
@@ -137,22 +148,22 @@ contract CollectingTest_WithSig is CollectingTest_Base {
 
     // NEGATIVES
 
-    function testFailCollectWithSigIfNotExecutor() public {
+    function testCollectFailsWithSigIfNotExecutor() public {
         vm.expectRevert(Errors.ExecutorInvalid.selector);
         _mockCollectWithSig({delegatedSigner: otherSigner, signerPrivKey: otherSignerKey});
     }
 
-    function testFailCollectWithSigIfNonexistantPub() public {}
+    function testCollectFailsWithSigIfNonexistantPub() public {}
 
-    function testFailCollectWithSigIfZeroPub() public {}
+    function testCollectFailsWithSigIfZeroPub() public {}
 
-    function testFailCollectWithSigOnDeadlineMismatch() public {}
+    function testCollectFailsWithSigOnDeadlineMismatch() public {}
 
-    function testFailCollectWithSigOnInvalidDeadline() public {}
+    function testCollectFailsWithSigOnInvalidDeadline() public {}
 
-    function testFailCollectWithSigOnInvalidNonce() public {}
+    function testCollectFailsWithSigOnInvalidNonce() public {}
 
-    function testFailCollectWithSigIfCancelledViaEmptyPermitForAll() public {}
+    function testCollectFailsWithSigIfCancelledViaEmptyPermitForAll() public {}
 
     // SCENARIOS