Commit Graph

136 Commits

Author SHA1 Message Date
Peter Michael
707144b70e Merge branch 'main' into feat/collect-modules-toggle-follower-only 2022-04-01 13:42:41 -04:00
Zer0dot
2799970d6d Merge pull request #80 from aave/refactor/general-optimizations 2022-04-01 13:11:02 -04:00
Alan
174df22b5e Merge pull request #85 from aave/feat/follower-only-owner-bypass
Publication owner bypasses FollowValidationModuleBase's follow validation
2022-04-01 15:28:56 +01:00
Peter Michael
03a17e55e3 misc: Rearranged variable ordering. 2022-04-01 10:20:33 -04:00
Peter Michael
4a6df79c53 Merge branch 'main' into feat/collect-modules-toggle-follower-only 2022-03-31 19:05:15 -04:00
Peter Michael
3b9f2be9ae feat: Updated modules to return correct data and added tests. Also includes a refactor of the FollowerOnlyCollectModule into the FreeCollectModule with a similar toggle. 2022-03-31 18:54:36 -04:00
Peter Michael
7c0ff8520c refactor: Slight gas optimization. 2022-03-31 14:37:45 -04:00
Peter Michael
90d6c69049 refactor: Increment the publication count before comment creation, and manually prevent self-referencing comments. 2022-03-31 12:19:46 -04:00
donosonaumczuk
58555ba7af FollowValidationModuleBase short circuit improvement using isFollowing 2022-03-31 13:06:04 +01:00
donosonaumczuk
3e033d26ed Follow module base contract isFollowing implementation added 2022-03-31 13:05:29 +01:00
donosonaumczuk
c1befa2fe4 IFollowModule validateFollow replaced with isFollowing that returns boolean instead of reverting 2022-03-31 13:03:38 +01:00
Peter Michael
98464b568d misc: Renamed EmptyCollectModule to more accurate FollowerOnlyCollectModule. 2022-03-30 17:14:41 -04:00
Peter Michael
835e26a253 misc: Capitalized comments. 2022-03-30 17:05:40 -04:00
Zer0dot
dbe0a8540e Merge pull request #84 from aave/refactor/83-redundant-snapshot-logic 2022-03-30 16:51:19 -04:00
Peter Michael
1e9901de23 misc: Renamed LensPeripheryDataProvider to more accurate shortened LensPeriphery, including the name used in the domain separator. 2022-03-30 16:49:47 -04:00
Peter Michael
dd82346393 misc: Added return types and cleaned up comments. 2022-03-30 14:15:10 -04:00
Peter Michael
2c30269f1a misc: Clarified comments for boolean return values. 2022-03-30 10:47:47 -04:00
Peter Michael
ecd851baf5 misc: Removed redundant bracket scopes from single-line "if" statements. 2022-03-30 10:42:10 -04:00
miguelmtzinf
6a95e0ec1f fix: Remove unneeded unchecked blocks 2022-03-30 13:40:03 +02:00
donosonaumczuk
008e682a99 FollowValidationModuleBase's _checkFollowValidity now bypasses publication owner 2022-03-29 17:27:42 +01:00
Lasse Herskind
4a7c66a113 refactor: Add _getSnapshotValueByBlockNumber helper 2022-03-29 13:35:36 +01:00
donosonaumczuk
b9a5f42942 Small re-arrange to save more gas 2022-03-28 19:17:04 +01:00
donosonaumczuk
5416f98267 Profile NFT tokenURI custom font now support hyphens and underscores 2022-03-28 11:28:58 +01:00
Peter Michael
7d8878dc71 refactor: Added unchecked blocks in module initializations with impossible overflow cases. 2022-03-25 15:37:48 -04:00
Peter Michael
2dee8e4cb1 misc: Removed unused constant typehash. 2022-03-24 16:55:36 -04:00
Peter Michael
96493ee950 Merge branch 'main' into refactor/general-optimizations 2022-03-24 15:35:15 -04:00
Peter Michael
04a506dc5d misc: Added missing comments. 2022-03-24 15:28:00 -04:00
Peter Michael
4a734da09b misc: Corrected incorrect comment. 2022-03-24 15:18:25 -04:00
Peter Michael
eee3a71eb4 misc: Added zero address construction check. 2022-03-24 15:18:03 -04:00
Peter Michael
d5042ddb92 misc: Added zero address check on follow & collect NFT construction. 2022-03-24 14:37:24 -04:00
Peter Michael
bc4288db81 refactor: Cached multiple-use boolean value. 2022-03-24 11:19:54 -04:00
Peter Michael
a698476590 refactor: Where possible, cached array length in for loops. 2022-03-24 11:04:19 -04:00
Peter Michael
589155643c refactor: Wrapped increments in unchecked blocks. 2022-03-24 10:22:37 -04:00
Peter Michael
37ab8cea46 refactor: Wrapped for loop iterators in unchecked blocks, also formatted with prettier. 2022-03-24 10:07:52 -04:00
Peter Michael
56d6b2830f refactor: Optimized post-increments to use pre-increments where possible. 2022-03-23 18:46:13 -04:00
Peter Michael
42dd95f3eb refactor: Changed parameter data location to calldata in _validateRecoveredAddress(). 2022-03-23 18:43:14 -04:00
Peter Michael
7ae0396b76 refactor: Changed data locations of URI parameters in follow NFT and profile image URI setters to calldata. 2022-03-23 18:39:50 -04:00
Peter Michael
1768a5465b refactor: Short-circuited setState caller check. 2022-03-23 17:30:45 -04:00
Peter Michael
2f4bd779a4 refactor: Inlined single-use modifier. 2022-03-23 17:29:54 -04:00
Peter Michael
de1a366dee feat: (WIP) Added hyphens and underscores as valid handle characters. 2022-03-23 16:27:37 -04:00
donosonaumczuk
c12ef6a0b5 Merge branch 'main' into fix/zero-treasury-transfers 2022-03-23 14:50:27 -03:00
Peter Michael
54fd98e2e0 refactor: Governance power and delegated supply checks are now unchecked. 2022-03-23 13:26:05 -04:00
Zer0dot
55cbb4f666 Merge pull request #76 from aave/fix/follow-collect-initializable 2022-03-22 16:45:53 -04:00
Zer0dot
3d97e00ed7 Merge pull request #74 from aave/fix/minimum-amounts-allowed 2022-03-22 16:22:50 -04:00
Peter Michael
25f83751ff fix: Prevent treasury transfers if the treasury amount is zero. 2022-03-22 13:43:04 -04:00
Peter Michael
ea054fa174 fix: Prevent follow & collect NFT implementation initialization. 2022-03-22 11:32:45 -04:00
Peter Michael
89c8131022 fix: Prevent profile transfers when the hub is paused. 2022-03-22 11:22:34 -04:00
Peter Michael
a17ae78cd9 fix: Allow non-zero amounts in fee modules instead of BPS_MAX minimum. 2022-03-21 18:58:25 -04:00
Zer0dot
694b576288 Merge pull request #69 from aave/fix/follow-deleted-profiles 2022-03-21 14:39:25 -04:00
Zer0dot
e87ae33dc7 Merge pull request #68 from aave/refactor/optimize-state-check 2022-03-18 16:41:18 -04:00