Commit Graph

170 Commits

Author SHA1 Message Date
Peter Michael
e6caa36cfb feat: Initial basic implementation of current collect tracking events in limited collect modules. 2022-04-07 15:27:26 -04:00
Zer0dot
e5f9238914 Merge pull request #98 from aave/feat/small-refactors-additions 2022-04-07 11:08:23 -04:00
Zer0dot
b9819d1982 misc: Updated inheritance to be consistent.
Co-authored-by: Alan <adonoso@itba.edu.ar>
2022-04-07 10:38:27 -04:00
Peter Michael
5a052dd39b misc: Updated typehash constant to compute keccak hash instead of raw byte string. 2022-04-07 10:36:03 -04:00
Peter Michael
7ac139e53c misc: Fixed typo. 2022-04-07 10:34:09 -04:00
donosonaumczuk
95249f8617 misc: Unnecessary extra address variable removed 2022-04-07 14:02:04 +01:00
donosonaumczuk
9e911ddb34 misc: Gas optimized by removing default-valued variable init 2022-04-07 14:00:33 +01:00
donosonaumczuk
beb15e60d3 misc: Implemented interfaces placed after inherited contracts 2022-04-07 13:55:17 +01:00
Peter Michael
ea55d24fdf misc: Added natspec. 2022-04-06 17:12:24 -04:00
Peter Michael
4c1ab01306 misc: Organized imports and inheritance and removed unneeded inheritance. 2022-04-06 17:01:46 -04:00
Peter Michael
aaa7f79394 misc: Added missing natspec. 2022-04-06 16:56:26 -04:00
Peter Michael
9903c7a919 refactor: Refactored to reduce complexity and return empty bytes earlier on reference module initialization calling function. 2022-04-06 16:47:23 -04:00
Peter Michael
fe4c3b4460 refactor: Refactored follow module initialization. 2022-04-06 16:11:46 -04:00
Peter Michael
0f07ef7435 misc: Removed unnecessary space. 2022-04-06 16:11:23 -04:00
Peter Michael
d4bd4eb6cb refactor: Refactored getPubType getter. 2022-04-06 16:10:58 -04:00
Peter Michael
79d2105ae1 misc: Combined two "if" statements, added comment. 2022-04-06 11:54:12 -04:00
donosonaumczuk
c8aa854930 Small comment fix 2022-04-06 12:32:21 +01:00
Peter Michael
bf6e734c6a misc: Slight comment update. 2022-04-06 12:32:21 +01:00
donosonaumczuk
784c9cf593 Remove unused import 2022-04-05 16:38:47 +01:00
donosonaumczuk
ecb816affc ProfileFollowModule implementation added 2022-04-05 16:36:24 +01:00
Zer0dot
bc0be7650d Merge pull request #88 from aave/feat/return-ids 2022-04-04 17:55:56 -04:00
Peter Michael
e66acc5476 misc: Added missing "unchecked" blocks. 2022-04-04 17:11:32 -04:00
Peter Michael
9d4edf2870 refactor: Placed unchecked blocks around signature functions and ++ increments, also slightly rearranged follow & collect NFT mint functions to remove one LoC. 2022-04-04 17:07:05 -04:00
donosonaumczuk
9ef55d2165 Small gas improvement 2022-04-04 18:00:41 +01:00
donosonaumczuk
a8aefc137c Natspec improvement + Tiny refactor to avoid passing whole mapping 2022-04-04 11:51:12 +01:00
donosonaumczuk
7cb5d8433f Up to date with main branch - Conflicts solved 2022-04-04 11:02:31 +01:00
Peter Michael
1bb385603c feat: Updated LensPeriphery function names to be more explicit, added tests and moved all LensPeriphery tests to the misc test file. 2022-04-01 18:41:07 -04:00
Peter Michael
6e96132bf1 Merge branch 'main' into feat/peripheral-profile-metadata 2022-04-01 14:32:58 -04:00
Peter Michael
c696e1b73d misc: Updated comment. 2022-04-01 14:02:34 -04:00
Peter Michael
707144b70e Merge branch 'main' into feat/collect-modules-toggle-follower-only 2022-04-01 13:42:41 -04:00
Zer0dot
2799970d6d Merge pull request #80 from aave/refactor/general-optimizations 2022-04-01 13:11:02 -04:00
Alan
174df22b5e Merge pull request #85 from aave/feat/follower-only-owner-bypass
Publication owner bypasses FollowValidationModuleBase's follow validation
2022-04-01 15:28:56 +01:00
Peter Michael
03a17e55e3 misc: Rearranged variable ordering. 2022-04-01 10:20:33 -04:00
Peter Michael
4a6df79c53 Merge branch 'main' into feat/collect-modules-toggle-follower-only 2022-03-31 19:05:15 -04:00
Peter Michael
3b9f2be9ae feat: Updated modules to return correct data and added tests. Also includes a refactor of the FollowerOnlyCollectModule into the FreeCollectModule with a similar toggle. 2022-03-31 18:54:36 -04:00
donosonaumczuk
84a8b87b7d LensHub now returns IDs for profile creation, collect, mirror, comment and follow 2022-03-31 20:29:57 +01:00
donosonaumczuk
76151b3662 InteractionLogic lib now returns IDs for collect and follow 2022-03-31 20:28:56 +01:00
donosonaumczuk
88d4320b14 FollowNFT now returns token ID 2022-03-31 20:27:39 +01:00
donosonaumczuk
00b0a99ef3 CollectNFT now returns token ID 2022-03-31 20:27:09 +01:00
Peter Michael
7c0ff8520c refactor: Slight gas optimization. 2022-03-31 14:37:45 -04:00
Peter Michael
90d6c69049 refactor: Increment the publication count before comment creation, and manually prevent self-referencing comments. 2022-03-31 12:19:46 -04:00
donosonaumczuk
58555ba7af FollowValidationModuleBase short circuit improvement using isFollowing 2022-03-31 13:06:04 +01:00
donosonaumczuk
3e033d26ed Follow module base contract isFollowing implementation added 2022-03-31 13:05:29 +01:00
donosonaumczuk
c1befa2fe4 IFollowModule validateFollow replaced with isFollowing that returns boolean instead of reverting 2022-03-31 13:03:38 +01:00
Peter Michael
98464b568d misc: Renamed EmptyCollectModule to more accurate FollowerOnlyCollectModule. 2022-03-30 17:14:41 -04:00
Peter Michael
835e26a253 misc: Capitalized comments. 2022-03-30 17:05:40 -04:00
Zer0dot
dbe0a8540e Merge pull request #84 from aave/refactor/83-redundant-snapshot-logic 2022-03-30 16:51:19 -04:00
Peter Michael
1e9901de23 misc: Renamed LensPeripheryDataProvider to more accurate shortened LensPeriphery, including the name used in the domain separator. 2022-03-30 16:49:47 -04:00
Peter Michael
dd82346393 misc: Added return types and cleaned up comments. 2022-03-30 14:15:10 -04:00
Peter Michael
2c30269f1a misc: Clarified comments for boolean return values. 2022-03-30 10:47:47 -04:00