github/crewAI
1
1
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-09 14:37:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid in-place mutation of cached add_image results

Browse Source 
Address Bugbot feedback: remove format reminder logic for add_image tool
to avoid in-place mutation of cached results. The cached dict was being
modified when format reminders were appended, causing reminders to
accumulate across cache hits.

Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-12-02 10:48:41 +00:00
parent 5110817709
commit 8437e1cdea
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/crewai/src/crewai/tools/tool_usage.py
View File

@@ -320,25 +320,15 @@ class ToolUsage:
# For add_image tool, preserve the raw dict result for multimodal handling # For add_image tool, preserve the raw dict result for multimodal handling
# The result is a dict like {"role": "user", "content": [...]} that should # The result is a dict like {"role": "user", "content": [...]} that should
# not be stringified # not be stringified. We skip format reminders for add_image to avoid
# in-place mutation of cached results.
add_image_tool = self._i18n.tools("add_image") add_image_tool = self._i18n.tools("add_image")
is_add_image_tool = ( is_add_image_tool = (
isinstance(add_image_tool, dict) isinstance(add_image_tool, dict)
and tool.name.casefold().strip() and tool.name.casefold().strip()
== add_image_tool.get("name", "").casefold().strip() == add_image_tool.get("name", "").casefold().strip()
) )
if is_add_image_tool: if not is_add_image_tool:
# For add_image, only apply format reminder if needed (skip stringification)
if self._should_remember_format():
# Append format reminder to the text content if present
format_reminder = self._i18n.slice("tools").format(
tools=self.tools_description, tool_names=self.tools_names
)
if isinstance(result, dict) and "content" in result:
# Add format reminder as a text item in the content list
if isinstance(result["content"], list):
result["content"].append({"type": "text", "text": format_reminder})
else:
result = self._format_result(result=result, skip_counter=True) result = self._format_result(result=result, skip_counter=True)
data = { data = {