Add extend_remember_period, closes #340.

This commit is contained in:
José Valim
2010-07-23 16:31:42 +02:00
parent 5aeb8cf1cf
commit 058d433f28
6 changed files with 114 additions and 7 deletions

View File

@@ -3,7 +3,6 @@ require 'test_helper'
class RememberMeTest < ActionController::IntegrationTest
def create_user_and_remember(add_to_token='')
Devise.remember_for = 1
user = create_user
user.remember_me!
raw_cookie = User.serialize_into_cookie(user).tap { |a| a.last << add_to_token }
@@ -17,6 +16,16 @@ class RememberMeTest < ActionController::IntegrationTest
request.cookie_jar['raw_cookie']
end
def signed_cookie(key)
controller.send(:cookies).signed[key]
end
def cookie_expires(key)
cookie = response.headers["Set-Cookie"].split("\n").grep(/^#{key}/).first
cookie.split(";").map(&:strip).grep(/^expires=/)
Time.parse($')
end
test 'do not remember the user if he has not checked remember me option' do
user = sign_in_as_user
assert_nil request.cookies["remember_user_cookie"]
@@ -47,6 +56,34 @@ class RememberMeTest < ActionController::IntegrationTest
assert warden.user(:user) == user
end
test 'if both extend_remember_period and remember_across_browsers are true, sends the same token with a new expire date' do
swap Devise, :remember_across_browsers => true, :extend_remember_period => true, :remember_for => 1.year do
user = create_user_and_remember
token = user.remember_token
user.remember_created_at = old = 10.minutes.ago
user.save!
get users_path
assert (cookie_expires("remember_user_token") - 1.year) > (old + 5.minutes)
assert_equal token, signed_cookie("remember_user_token").last
end
end
test 'if both extend_remember_period and remember_across_browsers are false, sends a new token with old expire date' do
swap Devise, :remember_across_browsers => false, :extend_remember_period => false, :remember_for => 1.year do
user = create_user_and_remember
token = user.remember_token
user.remember_created_at = old = 10.minutes.ago
user.save!
get users_path
assert (cookie_expires("remember_user_token") - 1.year) < (old + 5.minutes)
assert_not_equal token, signed_cookie("remember_user_token").last
end
end
test 'do not remember other scopes' do
user = create_user_and_remember
get root_path