github/devise
1
1
Fork 0
mirror of https://github.com/heartcombo/devise.git synced 2026-01-08 22:37:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5508 from Edouard-chin/ec-omniauth-allowed-methods

Browse Source 
Use Omniauth.allowed_methods' as routing verbs for the auth path:
This commit is contained in:
Rafael Mendonça França
2023-06-09 19:50:07 -04:00
committed by GitHub
parent 8bb41ad98e 4f82235630
commit 1b0ef1d2fe
2 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/integration/omniauthable_test.rb
View File

@@ -126,6 +126,28 @@ class OmniauthableIntegrationTest < Devise::IntegrationTest
end
end
test "authorization path via GET when Omniauth allowed_request_methods includes GET" do
original_allowed = OmniAuth.config.allowed_request_methods
OmniAuth.config.allowed_request_methods = [:get, :post]
get "/users/auth/facebook"
assert_response(:redirect)
ensure
OmniAuth.config.allowed_request_methods = original_allowed
end
test "authorization path via GET when Omniauth allowed_request_methods doesn't include GET" do
original_allowed = OmniAuth.config.allowed_request_methods
OmniAuth.config.allowed_request_methods = [:post]
assert_raises(ActionController::RoutingError) do
get "/users/auth/facebook"
end
ensure
OmniAuth.config.allowed_request_methods = original_allowed
end
test "generates a link to authenticate with provider" do
visit "/users/sign_in"
assert_select "form[action=?][method=post]", "/users/auth/facebook" do