github/devise
1
1
Fork 0
mirror of https://github.com/heartcombo/devise.git synced 2026-01-10 07:18:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

updated email_regexp and added test cases (#4001)

Browse Source 
Add a more permissive default e-mail regex.
This commit is contained in:
kimgb
2016-04-27 00:13:07 +10:00
committed by Ulisses Almeida
parent 209b97d86b
commit 830d3e86ee
4 changed files with 10 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/devise_test.rb Normal file → Executable file
View File

@@ -37,8 +37,7 @@ class DeviseTest < ActiveSupport::TestCase
test 'setup block warns about defaults changing' do
Devise.app_set_configs = Set.new
ActiveSupport::Deprecation.expects(:warn).with() { |value| value =~ /email_regexp/ }
ActiveSupport::Deprecation.expects(:warn).with() { |value| value =~ /reconfirmable/ }
ActiveSupport::Deprecation.expects(:warn).with() { |value| value =~ /sign_out_via/ }
ActiveSupport::Deprecation.expects(:warn).with() { |value| value =~ /skip_session_storage/ }
@@ -52,7 +51,6 @@ class DeviseTest < ActiveSupport::TestCase
ActiveSupport::Deprecation.expects(:warn).never
swap Devise,
email_regexp: /@/,
reconfirmable: false,
sign_out_via: :get,
skip_session_storage: [],
@@ -121,8 +119,8 @@ class DeviseTest < ActiveSupport::TestCase
end
test 'Devise.email_regexp should match valid email addresses' do
valid_emails = ["test@example.com", "jo@jo.co", "f4$_m@you.com", "testing.example@example.com.ua"]
non_valid_emails = ["rex", "test@go,com", "test user@example.com", "test_user@example server.com", "test_user@example.com."]
valid_emails = ["test@example.com", "jo@jo.co", "f4$_m@you.com", "testing.example@example.com.ua", "test@tt", "test@valid---domain.com"]
non_valid_emails = ["rex", "test user@example.com", "test_user@example server.com"]
valid_emails.each do |email|
assert_match Devise.email_regexp, email