github/devise
1
1
Fork 0
mirror of https://github.com/heartcombo/devise.git synced 2026-01-08 22:37:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5573 from heartcombo/ca/failure-app-respect-redirect

Browse Source 
Respect redirect status code when recalling the action
This commit is contained in:
Carlos Antonio da Silva
2023-03-30 17:29:35 -03:00
committed by GitHub
parent 367ea42762 89a08357d6
commit 8dbe5b2fe8
3 changed files with 57 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
test/failure_app_test.rb
View File

@@ -371,6 +371,59 @@ class FailureTest < ActiveSupport::TestCase
end
end
end
# TODO: remove conditional/else when supporting only responders 3.1+
if ActionController::Responder.respond_to?(:error_status=)
test 'respects the configured responder `error_status` for the status code' do
swap Devise.responder, error_status: :unprocessable_entity do
env = {
"warden.options" => { recall: "devise/sessions#new", attempted_path: "/users/sign_in" },
"devise.mapping" => Devise.mappings[:user],
"warden" => stub_everything
}
call_failure(env)
assert_equal 422, @response.first
assert_includes @response.third.body, 'Invalid Email or password.'
end
end
test 'respects the configured responder `redirect_status` if the recall app returns a redirect status code' do
swap Devise.responder, redirect_status: :see_other do
env = {
"warden.options" => { recall: "devise/registrations#cancel", attempted_path: "/users/cancel" },
"devise.mapping" => Devise.mappings[:user],
"warden" => stub_everything
}
call_failure(env)
assert_equal 303, @response.first
end
end
else
test 'uses default hardcoded responder `error_status` for the status code since responders version does not support configuring it' do
env = {
"warden.options" => { recall: "devise/sessions#new", attempted_path: "/users/sign_in" },
"devise.mapping" => Devise.mappings[:user],
"warden" => stub_everything
}
call_failure(env)
assert_equal 200, @response.first
assert_includes @response.third.body, 'Invalid Email or password.'
end
test 'users default hardcoded responder `redirect_status` for the status code since responders version does not support configuring it' do
env = {
"warden.options" => { recall: "devise/registrations#cancel", attempted_path: "/users/cancel" },
"devise.mapping" => Devise.mappings[:user],
"warden" => stub_everything
}
call_failure(env)
assert_equal 302, @response.first
end
end
end
context "Lazy loading" do