mirror of
https://github.com/heartcombo/devise.git
synced 2026-01-09 14:58:05 -05:00
Replace [data-turbo-cache=false] with [data-turbo-temporary]
The default `_error_messages.html.erb` partial uses a deprecated Turbo attribute `data-turbo-cache=false`, which was deprecated on Feb 15 2023 in [this pull request](https://github.com/hotwired/turbo/pull/871). Use more up-to-date attribute name called [data-turbo-temporary](https://github.com/hotwired/turbo/pull/871) to avoid deprecation issues and reduce developer confusion as `data-turbo-temporary` is the only attributed mentioned in [Turbo Drive's documentation](https://turbo.hotwired.dev/handbook/building#preparing-the-page-to-be-cached) Closes #5664 Closes #5662 Signed-off-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
This commit is contained in:
@@ -20,6 +20,9 @@
|
|||||||
[#5645](https://github.com/heartcombo/devise/pull/5645)
|
[#5645](https://github.com/heartcombo/devise/pull/5645)
|
||||||
* Change password instructions button label on devise view from `Send me reset password instructions` to `Send me password reset instructions` [#5515](https://github.com/heartcombo/devise/pull/5515)
|
* Change password instructions button label on devise view from `Send me reset password instructions` to `Send me password reset instructions` [#5515](https://github.com/heartcombo/devise/pull/5515)
|
||||||
* Change `<br>` tags separating form elements to wrapping them in `<p>` tags [#5494](https://github.com/heartcombo/devise/pull/5494)
|
* Change `<br>` tags separating form elements to wrapping them in `<p>` tags [#5494](https://github.com/heartcombo/devise/pull/5494)
|
||||||
|
* Replace `[data-turbo-cache=false]` with `[data-turbo-temporary]` on `devise/shared/error_messages` partial. This has been [deprecated by Turbo since v7.3.0 (released on Mar 1, 2023)](https://github.com/hotwired/turbo/releases/tag/v7.3.0).
|
||||||
|
|
||||||
|
If you are using an older version of Turbo and the default devise template, you'll need to copy it over to your app and change that back to `[data-turbo-cache=false]`.
|
||||||
|
|
||||||
* enhancements
|
* enhancements
|
||||||
* Add Rails 8 support.
|
* Add Rails 8 support.
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
<% if resource.errors.any? %>
|
<% if resource.errors.any? %>
|
||||||
<div id="error_explanation" data-turbo-cache="false">
|
<div id="error_explanation" data-turbo-temporary>
|
||||||
<h2>
|
<h2>
|
||||||
<%= I18n.t("errors.messages.not_saved",
|
<%= I18n.t("errors.messages.not_saved",
|
||||||
count: resource.errors.count,
|
count: resource.errors.count,
|
||||||
|
|||||||
Reference in New Issue
Block a user