José Valim
c4d5a3fdaa
No need to assert for a message we won't receive
2013-07-26 10:00:09 +02:00
José Valim
11a77055f1
Merge pull request #2525 from jetthoughts/timeoutable-without-rememberable
...
Fixed checking for rememberable in timeoutable
2013-07-26 00:58:09 -07:00
Michael Nikitochkin
fffbeb5cc7
Fixed bug when user has field remember_created_at but the module rememberable is not enabled for the user
2013-07-26 10:20:29 +03:00
Siarhei Hanchuk
b7bc8dec12
Added method after_confrimation
2013-07-23 14:19:58 +03:00
José Valim
da0323e591
Merge pull request #2419 from plataformatec/issue-2418
...
set error to the field specified in unlock_keys config
2013-07-08 23:52:19 -07:00
José Valim
061e9d7404
Merge pull request #2475 from tkhr/enable_skipping_reconfirmation_notification_but_regenerate_confirmation_token_2
...
Enable to skip sending reconfirmation email when reconfirmable is on and skip_confirmation_notification! is invoked
2013-07-08 23:51:42 -07:00
Takehiro Adachi
df2995ce19
Enable to skip sending reconfirmation email when skip_confirmation_notification! is invoked
...
We could always generate a confirmation token but not sending a
confirmation email by invoking the skip_confirmation_notification!
method when creating the account.
But there were no way to do that when we were turning on reconfirmable
and updating email.
2013-06-20 08:21:54 +09:00
José Valim
72cf2481b5
Rename ParamFilter to ParameterFilter for consistency
2013-06-19 09:17:54 +02:00
Steve Slotnick
b194882b23
Renaming get_or_create_*_token to ensure_*_token to match API in token authenticatable
2013-06-12 15:10:14 -07:00
Steve Slotnick
b5909f9b93
changing name from *_token! to get_or_create_*_token
2013-06-11 14:14:17 -07:00
Steve Slotnick
3c9cfa50c0
Adding publicly available methods on Recoverable and Confirmable to retrieve tokens
2013-06-10 19:17:19 -07:00
Kramer Campbell
17e85aa79d
Avoid sending confirmations to blank emails.
...
At times, validations may be skipped and no email address may be
provided. Such an instance comes when testing uniqueness validations of
specific attributes in a Devise model with confirmable, especially when
using Shoulda matchers.
2013-05-22 19:48:06 -07:00
Vasiliy Ermolovich
dd7c3ee91f
set error to the field specified in unlock_keys config
...
closes #2418
2013-05-14 17:41:47 +03:00
Carlos Antonio da Silva
eb0ad1c21a
Merge branch 'master' into rails4
2013-05-07 13:01:34 -03:00
José Valim
e499fadf52
Use persisted? in order to check if the record was destoryed or not
2013-05-07 08:55:30 -06:00
José Valim
5ad122b928
Fix build for mongoid
2013-05-07 08:47:18 -06:00
José Valim
03f2a6a5e4
Merge pull request #2392 from michiel3/master
...
Add destroy_with_password method
2013-05-07 07:11:47 -07:00
Carlos Antonio da Silva
69f79ad446
Let Devise play with both Rails 3.2 and Rails 4 for now
2013-05-05 19:55:06 -03:00
Victor Cruz Dueñas
d6d61fc5be
Adding tests for case_insensitive_keys and strip_whitespace_keys to param filter
2013-05-05 01:02:48 +02:00
Michiel Prins
60e933df73
Add destroy_with_password method
2013-04-29 15:06:13 +02:00
Carlos Antonio da Silva
b8c5d76c5a
Merge pull request #2380 from vipulnsward/fix_warnings
...
fix some warnings
2013-04-19 15:53:43 -07:00
Vipul A M
b871bd5036
fix some warning
2013-04-19 19:08:20 +05:30
Vipul A M
2e6457006e
Remove unused variables and fix typos
2013-04-18 10:24:38 +05:30
Carlos Antonio da Silva
d89dad5728
Bundle update for both Rails 3.1 and 3.2, update mocha, fix failing tests
2013-04-13 11:08:27 -03:00
Drew Ulmer
af4a582300
Remove mass-assignment role-based tests, no longer supported in Rails 4
...
Mass-assignment security roles are removed in Rails 4 so there's no need
to test :as => :role behavior.
2013-03-31 15:21:49 -05:00
Carlos Antonio da Silva
3c885e043d
Fix changed error messages from confirmation validation
2013-02-25 22:12:06 -03:00
Carlos Antonio da Silva
f8792c8cf0
Update to Rails 3-2-stable and fix failing tests
2013-02-25 22:06:10 -03:00
Greg Gates
72cfaad618
Add #skip_confirmation_notification to Confirmable
2013-02-22 12:43:01 -05:00
Vasiliy Ermolovich
395a69b4ef
allow_unconfirmed_access_for set to nil means unconfirmed access for unlimited time
...
closes #2275
2013-02-13 21:17:38 +03:00
Carlos Antonio da Silva
0285565322
Actually fix this test by forcing to_s on the id
2013-01-28 21:40:11 -02:00
Carlos Antonio da Silva
acc3adb2c1
Use #next instead of calculating id + 1
...
The id attribute is not Integer in Mongo, so it fails with something like:
NoMethodError: undefined method `+' for "5106fc06ee6da1ee44000002":Moped::BSON::ObjectId'`
With #next, it will work with both Integer and String ids, for both AR
and Mongo, returning a different id to test for filtered conditions.
2013-01-28 20:46:21 -02:00
Rafael Mendonça França
bfa65dde70
Use the Ruby 1.8 hash syntax.
...
Yes we still support Ruby 1.8 😢
2013-01-28 13:21:44 -02:00
José Valim
5190f52857
Require string conversion for all values
2013-01-26 11:42:42 -07:00
José Valim
33fb89340a
Revert "update_with_password doesn't change encrypted password when it is invalid"
...
This reverts commit 10235f9d72 .
2013-01-11 19:12:53 +01:00
Drew Ulmer
c768366240
Add failing tests for Issue #2204
...
For a point release upgrade, Devise should not throw an exception when trying
to downcase or strip globally configured keys. This would be a breaking
change in functionality and this test demonstrates the issue.
2013-01-09 11:41:20 -06:00
José Valim
4c83743263
unconfirmed_email now uses the proper e-mail on salutation, related to #2060
2012-12-13 09:02:59 +01:00
Carlos Antonio da Silva
ac3a25bf2e
Remove nothing raised assertion
...
Let the test raise if that is the case, no need for assert that nothing
was raised.
Hopefully fix the build ✨
2012-12-04 17:49:26 -02:00
Carlos Antonio da Silva
2261005ed5
Refactor a bit to avoid two model attributes lookup
...
Tidy up tests a bit.
2012-12-04 17:37:12 -02:00
Drew Ulmer
0c6f2adf14
Add failing test for #2129
2012-12-01 21:06:11 -06:00
Drew Ulmer
77ec1b08cd
Move test models into their own file so they can be used elsewhere
2012-12-01 21:06:03 -06:00
Durran Jordan
d821275588
Fix spec failures for Mongoid 3.
...
This has no actual changes to Devise itself, just fixes the failing
tests when running against Mongoid 3 instead of Mongoid 2.
Mocha has been locked at 0.10.0 since 0.12.0 raises an error when trying
to set an expectation on a frozen object.
Tests were updated to work with both AR and Mongoid, some cases the XML
serialization was slightly different but both were outputting correct
and valid XML, and the id/_id field mismatch is now handled.
An active field was missing from the test models for Mongoid, and the
invalid :null => true options in field were removed.
2012-11-10 20:02:58 +01:00
Vasiliy Ermolovich
10235f9d72
update_with_password doesn't change encrypted password when it is invalid
...
closes #2130
2012-11-06 21:05:17 +03:00
Drew Ulmer
00e8841e93
Unit test for Lockable#unauthenticated_message not leaking account existence
...
This is another failing test for #1994 , a unit test for Lockable. Lockable's
#uanauthenticated_message should not return :locked if paranoid mode is on
and instead should return the generic :invalid response.
2012-10-25 16:51:02 -05:00
José Valim
bdf0bc7b1e
Revert "Revert "New password default minimum length is now 8""
...
This reverts commit b1f490a2f8 .
Actually, the implementation was good!
2012-07-24 23:41:17 +02:00
José Valim
b1f490a2f8
Revert "New password default minimum length is now 8"
...
This reverts commit 2950434ed3 .
It is backwards incompatible, we need a better migration plan.
2012-07-24 22:41:13 +02:00
José Valim
6e79c5c242
Ensure a new token is generated if the previous one expired
2012-07-23 16:05:51 +02:00
Nils Landt
dcada8fe75
Refactor according to line notes from josevalim
...
- rename reset_password_within to confirm_within
- confirmation_period_valid? is back and memoized
- fix hash syntax to hashrocket
2012-07-22 14:02:27 +02:00
Nils Landt
1d6ee13aae
Refactor according to rodrigoflores
...
- Favor using update_attribute instead of constructor parameters in user
factory for tests
- Test for accurate error message when confirmation token is expired
- Don't check twice whether the confirmation period is expired
2012-07-16 11:20:01 +02:00
Nils Landt
6e48fcee76
Fix tests for email token expiration
...
The tests work now, but are a bit wonky because User.create does things
I don't understand.
2012-07-11 18:30:36 +02:00
Nils Landt
42a0c30139
Refactored according to line notes by rodrigoflores
2012-07-11 15:49:41 +02:00