Carlos Antonio da Silva
400eaf7fbe
Remove not used constant
...
It's only been almost ~10 years since we removed it's usage. :D
dff7891b97
2023-03-01 22:50:56 -03:00
Carlos Antonio da Silva
df8b79a53f
Fix added tests for sign_in_after_reset_password per resource class
...
We can't just "swap" those model properties, as that sets instance vars
on the classes that get reverted to their "previous" value, which ends
up leaving the instance vars set as `nil`. However, our logic for those
model/class properties actually checks for `defined?` as a way to
override them, and delegates up to `Devise` global config if they are
not defined, so leaving instance vars back with `nil` values isn't
enough, we need to actually remove them.
This introduces a new test helper specifically for overriding those
model configs so that we can do proper cleanup.
2023-03-01 22:50:03 -03:00
Peter Goldstein
90f46bac37
Monkeypatch webrat for Nokogiri compatibility
...
This is an attempt to address the Webrat / Nokogiri compatibility issue
[discussed here]. It monkeypatches Webrat to explicitly add the old
default arguments to the invocation of to_xpath.
Move monkey patch to its own file under test/support/webrat.
I really need to get rid of webrat.
Closes #5475
[discussed here] https://github.com/sparklemotion/nokogiri/issues/2469
2023-03-01 22:06:40 -03:00
Carlos Antonio da Silva
f08e0ad24a
Integrate with Hotwire/Turbo by configuring error and response statuses
...
Treat `:turbo_stream` request format as a navigational format, much like
HTML, so Devise/responders can work properly.
Allow configuring the `error_status` and `redirect_status` using the
latest responders features, via a new custom Devise responder, so we can
customize the both responses to match Hotwire/Turbo behavior, for
example with `422 Unprocessable Entity` and `303 See Other`,
respectively. The defaults aren't changing in Devise itself (yet), so it
still responds on errors cases with `200 OK`, and redirects on non-GET
requests with `302 Found`, but new apps are generated with the new
statuses and existing apps can opt-in. Please note that these defaults
might change in a future release of Devise.
PRs/Issues references:
https://github.com/heartcombo/devise/pull/5545
https://github.com/heartcombo/devise/pull/5529
https://github.com/heartcombo/devise/pull/5516
https://github.com/heartcombo/devise/pull/5499
https://github.com/heartcombo/devise/pull/5487
https://github.com/heartcombo/devise/pull/5467
https://github.com/heartcombo/devise/pull/5440
https://github.com/heartcombo/devise/pull/5410
https://github.com/heartcombo/devise/pull/5340
https://github.com/heartcombo/devise/issues/5542
https://github.com/heartcombo/devise/issues/5530
https://github.com/heartcombo/devise/issues/5519
https://github.com/heartcombo/devise/issues/5513
https://github.com/heartcombo/devise/issues/5478
https://github.com/heartcombo/devise/issues/5468
https://github.com/heartcombo/devise/issues/5463
https://github.com/heartcombo/devise/issues/5458
https://github.com/heartcombo/devise/issues/5448
https://github.com/heartcombo/devise/issues/5446
https://github.com/heartcombo/devise/issues/5439
2023-01-31 11:02:01 -03:00
mune
eed641d2be
Add spaces around method arguments when setting default values
...
Closes #5288
2020-08-31 18:15:45 -03:00
Carlos Antonio da Silva
15135f7dc6
User assert_includes/refute_includes minitest helpers
2020-08-27 18:38:26 -03:00
Carlos Antonio da Silva
34d9053819
Remove unnecessary monkey-patch of test helpers with Rails 5+
...
This is warning on Ruby 2.7, and seems unnecessary since Rails 5+
adopted kwargs approach. We still need to handle the difference for
Rails < 5 for now, while we support it (which I would like to remove
soon.)
2020-06-07 20:00:17 -03:00
Felipe Renan
101e50f9df
Fix webrat warnings
...
Forwarding methods to private methods is deprecated and produces a
warning after Ruby 2.4.
see: https://bugs.ruby-lang.org/issues/12782
To fix this issue I'm mocking patching webrat making RailsAdatper#response
method public since Webrat::Session is delegating functions to it.
2019-02-04 14:50:14 -02:00
Leonardo Tegon
c000b58c56
Add Rails 6 to CI ( #5009 )
2019-01-22 12:43:31 -02:00
Leonardo Tegon
5664b19703
Ensure Devise isn't performing model validations
2018-03-14 15:21:07 -03:00
Pat Allan
f39c6fd927
Add the frozen_string_literal pragma comment to all Ruby files. ( #4725 )
2017-12-21 15:36:29 -02:00
Ashley Foster
31801fc9a0
Fix missing validations on Signup ( #4674 )
...
* Fix missing validations on Signup
This commit fixes issue
https://github.com/plataformatec/devise/issues/4673
This removes `validate: false` from saving a record when `Trackable` is
in use.
* Add test case
* Add mongoid model
2017-11-28 12:58:41 -02:00
Lucas Mazza
a2498074f1
Replace custom Array assertion with assert_equal.
2016-05-03 14:18:35 -03:00
Lucas Mazza
536279b05b
Replace homemade assert_not matcher in favor of refute.
2016-05-03 13:57:10 -03:00
Yogesh Khater
9696d83e7d
Upgrade Mongoid to 5.0
2016-04-19 17:18:40 +05:30
Thomas Walpole
2024fca4df
Rails 5 compatability. Remove rails < 4.1 and Ruby < 2.1
2015-12-11 09:47:30 -08:00
Ed Saunders
d98e98fe77
Add a test for when a recoverable resource has a non-AR email field
2015-12-08 16:01:39 +00:00
Nicolas Viennot
c22e7133b6
Removes the bang in confirm! and reset_password!
...
Closes #3412 and #3570 .
2015-04-19 11:47:44 -04:00
Lucas Mazza
48f03d8cc4
Ensure that the I18n backend is always initialized when we store custom translations.
...
Depending on the test order, there might a moment when a test reloads the I18n
backend and another tries to store a translation, but since the backend wasn't
re-initialized the custom translations would be overriden when i18n loads the
translations from the en.yml file.
2014-09-11 15:19:41 -03:00
alexsoble
67d8dd1e94
Replace 'Sign in' with 'Log in' in views, update tests
2014-08-06 13:32:02 -04:00
Michael Crismali
f37b10ef87
Switched all instances of 'not blank?' to 'present?'
2014-04-17 20:34:28 -05:00
Anshul Sharma
dc1b399a8b
Updated ruby 1.9 hash syntax
2014-02-25 22:12:55 +05:30
Vasiliy Ermolovich
72a0d9e350
Merge pull request #2822 from plataformatec/rails-4.1
...
Fix specs on Rails 4.1
2014-01-04 10:14:57 -08:00
Vasiliy Ermolovich
1b1be514c8
make webrat compatible with rails 4.1
2014-01-04 18:53:40 +03:00
Lucas Mazza
dd95f3f3f7
Support custom port for MongoDB config
2014-01-03 11:23:34 -02:00
Benoit Bénézech
d5514bf916
Add options for FailureApp's i18n_message. Similar #1633
2013-10-24 16:49:13 +02:00
José Valim
7e96bac6a4
Get rid of deprecated code
2013-08-05 11:24:04 +02:00
José Valim
72cf2481b5
Rename ParamFilter to ParameterFilter for consistency
2013-06-19 09:17:54 +02:00
Carlos Antonio da Silva
2261005ed5
Refactor a bit to avoid two model attributes lookup
...
Tidy up tests a bit.
2012-12-04 17:37:12 -02:00
Drew Ulmer
77ec1b08cd
Move test models into their own file so they can be used elsewhere
2012-12-01 21:06:03 -06:00
Nils Landt
1d6ee13aae
Refactor according to rodrigoflores
...
- Favor using update_attribute instead of constructor parameters in user
factory for tests
- Test for accurate error message when confirmation token is expired
- Don't check twice whether the confirmation period is expired
2012-07-16 11:20:01 +02:00
Nils Landt
6e48fcee76
Fix tests for email token expiration
...
The tests work now, but are a bit wonky because User.create does things
I don't understand.
2012-07-11 18:30:36 +02:00
Nils Landt
87f2fa9767
Add options to expire confirmation tokens
...
With this patch, functionality is added to expire the confirmation
tokens that are being sent by email.
For example, if a token is valid for 3 days only, it cannot be used for
confirmation on the 4th day.
2012-07-09 14:43:12 +02:00
Carlos Galdino
c179cef365
Change the minimum password length to 8
2012-07-06 11:46:46 -03:00
Chris Oliver
37c55eb192
Added tests for flexible routing constraints
2012-06-15 13:06:29 -05:00
Carlos Antonio da Silva
b6e30427a3
Pass the block argument straight to the assertion methods in test helpers
2012-05-15 17:19:21 -03:00
Rodrigo Flores
fffc3b1e0e
Moved a method to support
2012-03-03 14:41:22 -03:00
Lucas Mazza
64c05f2ce9
Fix the assert_same_content assertion helper
...
and a broken confirmable test.
2012-02-22 16:49:09 -02:00
Rodrigo Flores
bc11e9f300
One exception to rule them all
2012-02-22 13:55:05 -02:00
Rodrigo Flores
faf8b01ecc
Fixing some tests and adding an assert message
2012-02-22 13:55:05 -02:00
Rodrigo Flores
d7337c5b26
Added a missing test and asserting same content for 1.8 compatibility
2012-02-22 13:55:05 -02:00
José Valim
7c11564613
Remove Rails 3.0 only code.
2012-01-02 20:43:39 +01:00
José Valim
d952dea32b
Remove the code that was dynamically adding columns to active record
2011-12-11 20:07:50 +01:00
José Valim
9a6ac7ab69
Add confirmable to admin.
2011-12-11 20:07:50 +01:00
José Valim
6d681c5b8a
Merge remote-tracking branch 'heimidal/updates' into reconfirm
...
Conflicts:
lib/devise/models/confirmable.rb
test/support/helpers.rb
2011-12-04 20:58:41 +01:00
José Valim
dc8aa9ef83
Move param filtering to its own object and make all finder methods pass through it, closes #1413 .
2011-11-10 10:14:02 -02:00
Vasiliy Ermolovich
f00d9c5eff
generate migrations with new .change method for rails >= 3.1. closes #1345
2011-11-06 15:47:34 +03:00
Brian Rose
a1407565c8
Selectively add reconfirmable field in tests when necessary.
2011-08-30 22:19:18 -06:00
Brian Rose
a7c5a2e65d
Fix up implementation of reconfirmable.
2011-08-30 22:19:17 -06:00
SixArm
2a5669967f
Change test email addresses to ues RFC 2606 reserved domain example.com
2011-04-18 15:59:13 +08:00
