mirror of
https://github.com/heartcombo/devise.git
synced 2026-01-09 14:58:05 -05:00
232c855c54
Rails main / 7.1.0.alpha introduced a change to improve typography by default, by converting all apostrophes to be single quotation marks. https://github.com/rails/rails/pull/45463 The change caused all our text based matching to fail, this updates the tests to ensure compatibility. Model tests were changed to test against the error type & information rather than the translated string, which I think is an improvement overall that should make them a little less brittle. I thought of using [of_kind?] but that isn't available on all Rails versions we currently support, while `added?` is. The drawback is that `added?` require full details like the `:confirmation` example which requires the related attribute that is being confirmed, but that's a small price to pay. Integration tests were changed to match on a regexp that accepts both quotes. I could've used a simple `.` to match anything there, but thought I'd just keep it specific for clarity on what it is really expected to match there. Plus, since it's integration testing against a rendered response body, it's better to match the actual text rather than resort on other ways. (like using I18n directly, etc.) [of_kind?] https://api.rubyonrails.org/classes/ActiveModel/Errors.html#method-i-of_kind-3F
125 lines
4.1 KiB
Ruby
125 lines
4.1 KiB
Ruby
# encoding: UTF-8
|
|
# frozen_string_literal: true
|
|
|
|
require 'test_helper'
|
|
|
|
class ValidatableTest < ActiveSupport::TestCase
|
|
test 'should require email to be set' do
|
|
user = new_user(email: nil)
|
|
assert user.invalid?
|
|
assert user.errors[:email]
|
|
assert user.errors.added?(:email, :blank)
|
|
end
|
|
|
|
test 'should require uniqueness of email if email has changed, allowing blank' do
|
|
existing_user = create_user
|
|
|
|
user = new_user(email: '')
|
|
assert user.invalid?
|
|
assert_no_match(/taken/, user.errors[:email].join)
|
|
|
|
user.email = existing_user.email
|
|
assert user.invalid?
|
|
assert_match(/taken/, user.errors[:email].join)
|
|
|
|
user.save(validate: false)
|
|
assert user.valid?
|
|
end
|
|
|
|
test 'should require correct email format if email has changed, allowing blank' do
|
|
user = new_user(email: '')
|
|
assert user.invalid?
|
|
assert_not_equal 'is invalid', user.errors[:email].join
|
|
|
|
%w{invalid_email_format 123 $$$ () ☃}.each do |email|
|
|
user.email = email
|
|
assert user.invalid?, "should be invalid with email #{email}"
|
|
assert_equal 'is invalid', user.errors[:email].join
|
|
end
|
|
|
|
user.save(validate: false)
|
|
assert user.valid?
|
|
end
|
|
|
|
test 'should accept valid emails' do
|
|
%w(a.b.c@example.com test_mail@gmail.com any@any.net email@test.br 123@mail.test 1☃3@mail.test).each do |email|
|
|
user = new_user(email: email)
|
|
assert user.valid?, "should be valid with email #{email}"
|
|
assert_blank user.errors[:email]
|
|
end
|
|
end
|
|
|
|
test 'should require password to be set when creating a new record' do
|
|
user = new_user(password: '', password_confirmation: '')
|
|
assert user.invalid?
|
|
assert user.errors.added?(:password, :blank)
|
|
end
|
|
|
|
test 'should require confirmation to be set when creating a new record' do
|
|
user = new_user(password: 'new_password', password_confirmation: 'blabla')
|
|
assert user.invalid?
|
|
|
|
assert user.errors.added?(:password_confirmation, :confirmation, attribute: "Password")
|
|
end
|
|
|
|
test 'should require password when updating/resetting password' do
|
|
user = create_user
|
|
|
|
user.password = ''
|
|
user.password_confirmation = ''
|
|
|
|
assert user.invalid?
|
|
assert user.errors.added?(:password, :blank)
|
|
end
|
|
|
|
test 'should require confirmation when updating/resetting password' do
|
|
user = create_user
|
|
user.password_confirmation = 'another_password'
|
|
assert user.invalid?
|
|
|
|
assert user.errors.added?(:password_confirmation, :confirmation, attribute: "Password")
|
|
end
|
|
|
|
test 'should require a password with minimum of 7 characters' do
|
|
user = new_user(password: '12345', password_confirmation: '12345')
|
|
assert user.invalid?
|
|
assert_equal 'is too short (minimum is 7 characters)', user.errors[:password].join
|
|
end
|
|
|
|
test 'should require a password with maximum of 72 characters long' do
|
|
user = new_user(password: 'x'*73, password_confirmation: 'x'*73)
|
|
assert user.invalid?
|
|
assert_equal 'is too long (maximum is 72 characters)', user.errors[:password].join
|
|
end
|
|
|
|
test 'should not require password length when it\'s not changed' do
|
|
user = create_user.reload
|
|
user.password = user.password_confirmation = nil
|
|
assert user.valid?
|
|
|
|
user.password_confirmation = 'confirmation'
|
|
assert user.invalid?
|
|
assert_not (user.errors[:password].join =~ /is too long/)
|
|
end
|
|
|
|
test 'should complain about length even if password is not required' do
|
|
user = new_user(password: 'x'*73, password_confirmation: 'x'*73)
|
|
user.stubs(:password_required?).returns(false)
|
|
assert user.invalid?
|
|
assert_equal 'is too long (maximum is 72 characters)', user.errors[:password].join
|
|
end
|
|
|
|
test 'should not be included in objects with invalid API' do
|
|
exception = assert_raise RuntimeError do
|
|
Class.new.send :include, Devise::Models::Validatable
|
|
end
|
|
|
|
expected_message = /Could not use :validatable module since .* does not respond to the following methods: validates_presence_of.*/
|
|
assert_match expected_message, exception.message
|
|
end
|
|
|
|
test 'required_fields should be an empty array' do
|
|
assert_equal [], Devise::Models::Validatable.required_fields(User)
|
|
end
|
|
end
|