github/directus
1
0
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-02-13 05:45:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes _offset=0 in deep filters (#18382)

Browse Source
This commit is contained in:
Brainslug
2023-05-02 12:34:50 +02:00
committed by GitHub
parent 8b8858da9a
commit 06ff0c2ef9
3 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
api/src/utils/sanitize-query.test.ts
View File

@@ -166,12 +166,20 @@ describe('offset', () => {
expect(sanitizedQuery.offset).toBe(1);
});
test('should ignore zero', () => {
test('should accept zero #18370', () => {
const offset = 0;
const sanitizedQuery = sanitizeQuery({ offset });
expect(sanitizedQuery.offset).toBeUndefined();
expect(sanitizedQuery.offset).toBe(0);
});
test('should accept string zero #18370', () => {
const offset = '0';
const sanitizedQuery = sanitizeQuery({ offset });
expect(sanitizedQuery.offset).toBe(0);
});
});

2
api/src/utils/sanitize-query.ts
View File

@@ -35,7 +35,7 @@ export function sanitizeQuery(rawQuery: Record<string, any>, accountability?: Ac
query.filter = sanitizeFilter(rawQuery['filter'], accountability || null);
}
if (rawQuery['offset']) {
if (rawQuery['offset'] !== undefined) {
query.offset = sanitizeOffset(rawQuery['offset']);
}