From 29797dfb975010d193808d1988ba1f407aa88cfc Mon Sep 17 00:00:00 2001 From: rijkvanzanten Date: Mon, 26 Apr 2021 14:56:02 -0400 Subject: [PATCH] Pass trx to items service in roles delete Fixes #5244 --- api/src/services/roles.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/api/src/services/roles.ts b/api/src/services/roles.ts index 01f8bc142e..48676758f6 100644 --- a/api/src/services/roles.ts +++ b/api/src/services/roles.ts @@ -28,6 +28,12 @@ export class RolesService extends ItemsService { if (otherAdminRolesCount === 0) throw new UnprocessableEntityException(`You can't delete the last admin role.`); await this.knex.transaction(async (trx) => { + const itemsService = new ItemsService('directus_roles', { + knex: trx, + accountability: this.accountability, + schema: this.schema, + }); + const permissionsService = new PermissionsService({ knex: trx, accountability: this.accountability, @@ -66,7 +72,7 @@ export class RolesService extends ItemsService { } ); - await super.deleteMany(keys); + await itemsService.deleteMany(keys); }); return keys;