The Great TypeScript Modernization Program Season 3 Episode 6: The Big One (#18014)

* Step 1

* Step 2

* False sense of confidence

* Couple more before dinner

* Update schema package

* Update format-title

* Upgrade specs file

* Close

* Replace ts-node-dev with tsx, and various others

* Replace lodash with lodash-es

* Add lodash-es types

* Update knex import

* More fun is had

* FSE

* Consolidate repos

* Various tweaks and fixes

* Fix specs

* Remove dependency on knex-schema-inspector

* Fix wrong imports of inspector

* Move shared exceptions to new package

* Move constants to separate module

* Move types to new types package

* Use directus/types

* I believe this is no longer needed

* [WIP] Start moving utils to esm

* ESMify Shared

* Move shared utils to  @directus/utils

* Use @directus/utils instead of @directus/shared/utils

* It runs!

* Use correct schemaoverview type

* Fix imports

* Fix the thing

* Start on new update-checker lib

* Use new update-check package

* Swap out directus/shared in app

* Pushing through the last bits now

* Dangerously make extensions SDK ESM

* Use @directus/types in tests

* Copy util function to test

* Fix linter config

* Add missing import

* Hot takes

* Fix build

* Curse these default exports

* No tests in constants

* Add tests

* Remove tests from types

* Add tests for exceptions

* Fix test

* Fix app tests

* Fix import in test

* Fix various tests

* Fix specs export

* Some more tests

* Remove broken integration tests

These were broken beyond repair.. They were also written before we really knew what we we're doing with tests, so I think it's better to say goodbye and start over with these

* Regenerate lockfile

* Fix imports from merge

* I create my own problems

* Make sharp play nice

* Add vitest config

* Install missing blackbox dep

* Consts shouldn't be in types

tsk tsk tsk tsk

* Fix type/const usage in extensions-sdk

* cursed.default

* Reduce circular deps

* Fix circular dep in items service

* vvv

* Trigger testing for all vendors

* Add workaround for rollup

* Prepend the file protocol for the ESM loader to be compatible with Windows
"WARN: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'"

* Fix postgres

* Schema package updates

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

* Resolve cjs/mjs extensions

* Clean-up eslint config

* fixed extension concatination

* using string interpolation for consistency

* Revert MySQL optimisation

* Revert testing for all vendors

* Replace tsx with esbuild-kit/esm-loader

Is a bit faster and we can rely on the built-in `watch` and `inspect`
functionalities of Node.js

Note: The possibility to watch other files (.env in our case) might be
added in the future, see https://github.com/nodejs/node/issues/45467

* Use exact version for esbuild-kit/esm-loader

* Fix import

---------

Co-authored-by: ian <licitdev@gmail.com>
Co-authored-by: Brainslug <tim@brainslug.nl>
Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>

api/src/storage/get-storage-driver.ts

@@ -1,4 +1,3 @@
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
 import type { Driver } from '@directus/storage';
 
 export const _aliasMap: Record<string, string> = {

api/src/storage/index.test.ts

@@ -1,6 +1,4 @@
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
 import { StorageManager } from '@directus/storage';
-
 import { afterEach, beforeEach, expect, test, vi } from 'vitest';
 import { validateEnv } from '../utils/validate-env.js';
 import { getStorage, _cache } from './index.js';

api/src/storage/index.ts

@@ -1,8 +1,6 @@
-import { validateEnv } from '../utils/validate-env';
-import { registerDrivers } from './register-drivers';
-import { registerLocations } from './register-locations';
-
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
+import { validateEnv } from '../utils/validate-env.js';
+import { registerDrivers } from './register-drivers.js';
+import { registerLocations } from './register-locations.js';
 import type { StorageManager } from '@directus/storage';
 
 export const _cache: { storage: any | null } = {

api/src/storage/register-drivers.test.ts

@@ -3,8 +3,6 @@ import { afterEach, beforeEach, expect, test, vi } from 'vitest';
 import { getEnv } from '../env.js';
 import { getStorageDriver } from './get-storage-driver.js';
 import { registerDrivers } from './register-drivers.js';
-
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
 import type { Driver, StorageManager } from '@directus/storage';
 
 vi.mock('./get-storage-driver.js');

api/src/storage/register-drivers.ts

@@ -1,7 +1,5 @@
-import { getEnv } from '../env';
-import { getStorageDriver } from './get-storage-driver';
-
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
+import { getEnv } from '../env.js';
+import { getStorageDriver } from './get-storage-driver.js';
 import type { StorageManager } from '@directus/storage';
 
 export const registerDrivers = async (storage: StorageManager) => {

api/src/storage/register-locations.test.ts

@@ -1,5 +1,4 @@
-import { toArray } from '@directus/shared/utils';
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
+import { toArray } from '@directus/utils';
 import type { StorageManager } from '@directus/storage';
 import { randNumber, randWord } from '@ngneat/falso';
 import { afterEach, beforeEach, expect, test, vi } from 'vitest';
@@ -8,7 +7,7 @@ import { getConfigFromEnv } from '../utils/get-config-from-env.js';
 import { registerLocations } from './register-locations.js';
 
 vi.mock('../env.js');
-vi.mock('@directus/shared/utils');
+vi.mock('@directus/utils');
 vi.mock('../utils/get-config-from-env.js');
 
 let sample: {

api/src/storage/register-locations.ts

@@ -1,9 +1,7 @@
-// @ts-expect-error https://github.com/microsoft/TypeScript/issues/49721
 import type { StorageManager } from '@directus/storage';
-
-import { toArray } from '@directus/shared/utils';
-import { getEnv } from '../env';
-import { getConfigFromEnv } from '../utils/get-config-from-env';
+import { toArray } from '@directus/utils';
+import { getEnv } from '../env.js';
+import { getConfigFromEnv } from '../utils/get-config-from-env.js';
 
 export const registerLocations = async (storage: StorageManager) => {
 	const env = getEnv();