From 2adbb3bfd27639b3af4453d4ffcdd3be59736dea Mon Sep 17 00:00:00 2001 From: Aiden Foxx Date: Sat, 29 Oct 2022 21:59:50 +0200 Subject: [PATCH] Convert some trace logs to warnings in OAuth flows (#16213) * Less trace, more warn in OpenID provider * Less trace, more warn in OAuth provider --- api/src/auth/drivers/oauth2.ts | 4 ++-- api/src/auth/drivers/openid.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api/src/auth/drivers/oauth2.ts b/api/src/auth/drivers/oauth2.ts index 10d1698710..d6a384932b 100644 --- a/api/src/auth/drivers/oauth2.ts +++ b/api/src/auth/drivers/oauth2.ts @@ -104,7 +104,7 @@ export class OAuth2AuthDriver extends LocalAuthDriver { async getUserID(payload: Record): Promise { if (!payload.code || !payload.codeVerifier) { - logger.trace('[OAuth2] No code or codeVerifier in payload'); + logger.warn('[OAuth2] No code or codeVerifier in payload'); throw new InvalidCredentialsException(); } @@ -150,7 +150,7 @@ export class OAuth2AuthDriver extends LocalAuthDriver { // Is public registration allowed? if (!allowPublicRegistration) { - logger.trace(`[OAuth2] User doesn't exist, and public registration not allowed for provider "${provider}"`); + logger.warn(`[OAuth2] User doesn't exist, and public registration not allowed for provider "${provider}"`); throw new InvalidCredentialsException(); } diff --git a/api/src/auth/drivers/openid.ts b/api/src/auth/drivers/openid.ts index c256303043..86dcb55687 100644 --- a/api/src/auth/drivers/openid.ts +++ b/api/src/auth/drivers/openid.ts @@ -117,7 +117,7 @@ export class OpenIDAuthDriver extends LocalAuthDriver { async getUserID(payload: Record): Promise { if (!payload.code || !payload.codeVerifier) { - logger.trace('[OpenID] No code or codeVerifier in payload'); + logger.warn('[OpenID] No code or codeVerifier in payload'); throw new InvalidCredentialsException(); } @@ -173,7 +173,7 @@ export class OpenIDAuthDriver extends LocalAuthDriver { // Is public registration allowed? if (!allowPublicRegistration || !isEmailVerified) { - logger.trace(`[OpenID] User doesn't exist, and public registration not allowed for provider "${provider}"`); + logger.warn(`[OpenID] User doesn't exist, and public registration not allowed for provider "${provider}"`); throw new InvalidCredentialsException(); }