Prevent thumbnail duplication (#18316)

api/src/utils/transformations.test.ts

@@ -0,0 +1,134 @@
+import { expect, test, describe } from 'vitest';
+import { maybeExtractFormat, resolvePreset } from './transformations.js';
+import type { File } from '../types/files.js';
+import type { Transformation, TransformationParams } from '../types/assets.js';
+
+const inputFile: File = {
+	id: '43a15f67-84a7-4e07-880d-e46a9f33c542',
+	storage: 'local',
+	filename_disk: 'test',
+	filename_download: 'test',
+	title: null,
+	type: null,
+	folder: null,
+	uploaded_by: null,
+	uploaded_on: new Date(),
+	charset: null,
+	filesize: 123,
+	width: null,
+	height: null,
+	duration: null,
+	embed: null,
+	description: null,
+	location: null,
+	tags: null,
+	metadata: null,
+};
+
+describe('resolvePreset', () => {
+	test('Prevent input mutation #18301', () => {
+		const inputData: TransformationParams = {
+			key: 'system-small-cover',
+			format: 'jpg',
+			transforms: [
+				[
+					'resize',
+					{
+						width: 64,
+						height: 64,
+						fit: 'cover',
+					},
+				],
+			],
+		};
+
+		resolvePreset(inputData, inputFile);
+
+		expect(inputData.transforms).toStrictEqual([
+			[
+				'resize',
+				{
+					width: 64,
+					height: 64,
+					fit: 'cover',
+				},
+			],
+		]);
+	});
+
+	test('Add toFormat transformation', () => {
+		const inputData: TransformationParams = {
+			key: 'system-small-cover',
+			format: 'jpg',
+			quality: 80,
+			transforms: [
+				[
+					'resize',
+					{
+						width: 64,
+						height: 64,
+						fit: 'cover',
+					},
+				],
+			],
+		};
+
+		const output = resolvePreset(inputData, inputFile);
+
+		expect(output).toStrictEqual([
+			[
+				'resize',
+				{
+					width: 64,
+					height: 64,
+					fit: 'cover',
+				},
+			],
+			['toFormat', 'jpg', { quality: 80 }],
+		]);
+	});
+
+	test('Add resize transformation', () => {
+		const inputData: TransformationParams = {
+			key: 'system-small-cover',
+			width: 64,
+			height: 64,
+			fit: 'cover',
+		};
+
+		const output = resolvePreset(inputData, inputFile);
+
+		expect(output).toStrictEqual([
+			[
+				'resize',
+				{
+					width: 64,
+					height: 64,
+					fit: 'cover',
+					withoutEnlargement: undefined,
+				},
+			],
+		]);
+	});
+});
+
+describe('maybeExtractFormat', () => {
+	test('get last format', () => {
+		const inputTransformations: Transformation[] = [
+			['toFormat', 'jpg', { quality: 80 }],
+			['toFormat', 'webp', { quality: 80 }],
+		];
+
+		const output = maybeExtractFormat(inputTransformations);
+
+		expect(output).toBe('webp');
+	});
+
+	test('get undefined', () => {
+		const inputTransformations: Transformation[] = [];
+
+		const output = maybeExtractFormat(inputTransformations);
+
+		expect(output).toBe(undefined);
+	});
+});

api/src/utils/transformations.ts

@@ -1,7 +1,7 @@
 import type { File, Transformation, TransformationParams } from '../types/index.js';
 
 export function resolvePreset(input: TransformationParams, file: File): Transformation[] {
-	const transforms = input.transforms ?? [];
+	const transforms = input.transforms ? [...input.transforms] : [];
 
 	if (input.format || input.quality)
 		transforms.push([