From 211898776ea315c5da86428cd675f5f97c7735e4 Mon Sep 17 00:00:00 2001 From: Nicola Krumschmidt Date: Mon, 28 Dec 2020 00:34:46 +0100 Subject: [PATCH 1/2] Reset Length and Required if Field Type changes --- .../modules/settings/routes/data-model/field-detail/store.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/src/modules/settings/routes/data-model/field-detail/store.ts b/app/src/modules/settings/routes/data-model/field-detail/store.ts index dd1e87dacb..37514bffbf 100644 --- a/app/src/modules/settings/routes/data-model/field-detail/store.ts +++ b/app/src/modules/settings/routes/data-model/field-detail/store.ts @@ -873,6 +873,8 @@ function initLocalStore(collection: string, field: string, type: typeof localTyp state.fieldData.meta.display_options = null; state.fieldData.meta.special = null; state.fieldData.schema.default_value = undefined; + state.fieldData.schema.max_length = undefined; + state.fieldData.schema.is_nullable = true; switch (state.fieldData.type) { case 'uuid': From 97211d5d69c689cf81f334e15a885f0ea5c59d95 Mon Sep 17 00:00:00 2001 From: Nicola Krumschmidt Date: Mon, 28 Dec 2020 00:38:01 +0100 Subject: [PATCH 2/2] Clean up field type watcher in local store --- .../modules/settings/routes/data-model/field-detail/store.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/modules/settings/routes/data-model/field-detail/store.ts b/app/src/modules/settings/routes/data-model/field-detail/store.ts index 37514bffbf..46f7f5e989 100644 --- a/app/src/modules/settings/routes/data-model/field-detail/store.ts +++ b/app/src/modules/settings/routes/data-model/field-detail/store.ts @@ -888,11 +888,9 @@ function initLocalStore(collection: string, field: string, type: typeof localTyp break; case 'boolean': state.fieldData.meta.special = ['boolean']; - state.fieldData.schema.is_nullable = false; state.fieldData.schema.default_value = false; + state.fieldData.schema.is_nullable = false; break; - default: - state.fieldData.schema.default_value = undefined; } } );