From 3ff71cc34aafadd78028a1440c22a9fc89ec8332 Mon Sep 17 00:00:00 2001
From: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Date: Fri, 28 Apr 2023 21:07:51 +0200
Subject: [PATCH] Silence prefer builtins and circular dependency warnings when
 building extensions (#18366)

* Silence prefer builtins warning

* Silence circular dependency warning if only external files are involved

* Add changeset
---
 .changeset/chilly-pugs-pay.md                     | 5 +++++
 packages/extensions-sdk/src/cli/commands/build.ts | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/chilly-pugs-pay.md

diff --git a/.changeset/chilly-pugs-pay.md b/.changeset/chilly-pugs-pay.md
new file mode 100644
index 0000000000..4688a2126a
--- /dev/null
+++ b/.changeset/chilly-pugs-pay.md
@@ -0,0 +1,5 @@
+---
+'@directus/extensions-sdk': patch
+---
+
+Silenced prefer builtins and circular dependency warnings when building extensions
diff --git a/packages/extensions-sdk/src/cli/commands/build.ts b/packages/extensions-sdk/src/cli/commands/build.ts
index 54457327d6..aec8bbbd81 100644
--- a/packages/extensions-sdk/src/cli/commands/build.ts
+++ b/packages/extensions-sdk/src/cli/commands/build.ts
@@ -591,7 +591,7 @@ function getRollupOptions({
 			languages.includes('typescript') ? esbuild({ include: /\.tsx?$/, sourceMap: sourcemap }) : null,
 			mode === 'browser' ? styles() : null,
 			...plugins,
-			nodeResolve({ browser: mode === 'browser' }),
+			nodeResolve({ browser: mode === 'browser', preferBuiltins: mode === 'node' }),
 			commonjs({ esmExternals: mode === 'browser', sourceMap: sourcemap }),
 			json(),
 			replace({
@@ -602,6 +602,11 @@ function getRollupOptions({
 			}),
 			minify ? terser() : null,
 		],
+		onwarn(warning, warn) {
+			if (warning.code === 'CIRCULAR_DEPENDENCY' && warning.ids?.every((id) => /\bnode_modules\b/.test(id))) return;
+
+			warn(warning);
+		},
 	};
 }