From efce49930a290941ecde3d4aedd74badab345fd6 Mon Sep 17 00:00:00 2001
From: Jakob-em <26389546+Jakob-em@users.noreply.github.com>
Date: Tue, 29 Dec 2020 21:48:09 +0100
Subject: [PATCH 1/3] Add missing tooltips

- create bookmark
- delete filter
- change operator
- table sort icons
---
 app/src/components/v-table/table-header/table-header.vue   | 7 ++++++-
 app/src/lang/translations/en-US.yaml                       | 4 ++++
 app/src/modules/collections/routes/collection.vue          | 7 ++++++-
 .../components/filter-sidebar-detail/field-filter.vue      | 4 ++--
 4 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/app/src/components/v-table/table-header/table-header.vue b/app/src/components/v-table/table-header/table-header.vue
index 5be55f01cf..0602645a20 100644
--- a/app/src/components/v-table/table-header/table-header.vue
+++ b/app/src/components/v-table/table-header/table-header.vue
@@ -32,7 +32,7 @@
 							{{ header.text }}
 						</slot>
 					</span>
-					<v-icon v-if="header.sortable" name="sort" class="sort-icon" small />
+					<v-icon v-if="header.sortable" name="sort" class="sort-icon" small v-tooltip.top="$t(getTooltipForSortIcon(header))"/>
 				</div>
 				<span
 					class="resize-handle"
@@ -121,6 +121,7 @@ export default defineComponent({
 			onResizeHandleMouseDown,
 			toggleManualSort,
 			toggleSelectAll,
+			getTooltipForSortIcon,
 		};
 
 		function getClassesForHeader(header: Header) {
@@ -145,6 +146,10 @@ export default defineComponent({
 			return classes;
 		}
 
+		function getTooltipForSortIcon(header: Header) {
+			return props.sort.by === header.value && props.sort.desc === false ? 'sort_direction.desc' : 'sort_direction.asc';
+		}
+
 		function changeSort(header: Header) {
 			if (header.sortable === false) return;
 			if (dragging.value === true) return;
diff --git a/app/src/lang/translations/en-US.yaml b/app/src/lang/translations/en-US.yaml
index 18b4aea16f..a899bfc14d 100644
--- a/app/src/lang/translations/en-US.yaml
+++ b/app/src/lang/translations/en-US.yaml
@@ -427,6 +427,8 @@ circle: Circle
 empty_item: Empty Item
 log_in_with: 'Log In with {provider}'
 advanced_filter: Advanced Filter
+delete_advanced_filter: Delete Filter
+change_advanced_filter_operator: Change Operator
 operators:
   eq: Equals
   neq: Doesn't equal
@@ -768,6 +770,8 @@ sign_out: Sign Out
 sign_out_confirm: Are you sure you want to sign out?
 something_went_wrong: Something went wrong.
 sort_direction: Sort Direction
+sort_direction.asc: Sort Ascending
+sort_direction.desc: Sort Descending
 template: Template
 translation: Translation
 value: Value
diff --git a/app/src/modules/collections/routes/collection.vue b/app/src/modules/collections/routes/collection.vue
index ccc515324d..c25b6b5471 100644
--- a/app/src/modules/collections/routes/collection.vue
+++ b/app/src/modules/collections/routes/collection.vue
@@ -22,7 +22,12 @@
 					:saving="creatingBookmark"
 				>
 					<template #activator="{ on }">
-						<v-icon class="toggle" name="bookmark_outline" @click="on" />
+						<v-icon
+							class="toggle"
+							@click="on"
+							name="bookmark_outline"
+							v-tooltip.right="$t('create_bookmark')"
+						/>
 					</template>
 				</bookmark-add>
 
diff --git a/app/src/views/private/components/filter-sidebar-detail/field-filter.vue b/app/src/views/private/components/filter-sidebar-detail/field-filter.vue
index e9cfe24683..1cd1f0d0fb 100644
--- a/app/src/views/private/components/filter-sidebar-detail/field-filter.vue
+++ b/app/src/views/private/components/filter-sidebar-detail/field-filter.vue
@@ -7,7 +7,7 @@
 			</div>
 			<v-menu show-arrow :disabled="disabled">
 				<template #activator="{ toggle }">
-					<div class="operator" @click="toggle">
+					<div class="operator" @click="toggle" v-tooltip.top="$t('change_advanced_filter_operator')">
 						<span>{{ $t(`operators.${activeOperator}`) }}</span>
 						<v-icon name="expand_more" />
 					</div>
@@ -25,7 +25,7 @@
 				</v-list>
 			</v-menu>
 			<div class="spacer" />
-			<v-icon class="remove" name="close" @click="$emit('remove')" />
+			<v-icon class="remove" name="close" @click="$emit('remove')" v-tooltip.left="$t('delete_advanced_filter')" />
 		</div>
 		<div class="field">
 			<filter-input v-model="value" :type="parsedField.type" :operator="activeOperator" :disabled="disabled" />

From 146452f98cab86222c0ed6bbe842dd7b845e6160 Mon Sep 17 00:00:00 2001
From: Rijk van Zanten <rijkvanzanten@me.com>
Date: Wed, 30 Dec 2020 13:10:44 -0500
Subject: [PATCH 2/3] Update app/src/lang/translations/en-US.yaml

---
 app/src/lang/translations/en-US.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/src/lang/translations/en-US.yaml b/app/src/lang/translations/en-US.yaml
index a899bfc14d..5b28365678 100644
--- a/app/src/lang/translations/en-US.yaml
+++ b/app/src/lang/translations/en-US.yaml
@@ -770,8 +770,9 @@ sign_out: Sign Out
 sign_out_confirm: Are you sure you want to sign out?
 something_went_wrong: Something went wrong.
 sort_direction: Sort Direction
-sort_direction.asc: Sort Ascending
-sort_direction.desc: Sort Descending
+sort_direction:
+  asc: Sort Ascending
+  desc: Sort Descending
 template: Template
 translation: Translation
 value: Value

From c53aef4a454967e8f03ad80acf38cd5f95241e61 Mon Sep 17 00:00:00 2001
From: rijkvanzanten <rijkvanzanten@me.com>
Date: Wed, 30 Dec 2020 13:18:09 -0500
Subject: [PATCH 3/3] Update translation

---
 .../v-table/table-header/table-header.vue     | 24 ++++++++-----------
 app/src/lang/translations/en-US.yaml          |  5 ++--
 2 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/app/src/components/v-table/table-header/table-header.vue b/app/src/components/v-table/table-header/table-header.vue
index 0602645a20..8987312d0c 100644
--- a/app/src/components/v-table/table-header/table-header.vue
+++ b/app/src/components/v-table/table-header/table-header.vue
@@ -12,27 +12,23 @@
 			</th>
 
 			<th v-if="showSelect" class="select cell" scope="col">
-				<v-checkbox
-					:inputValue="allItemsSelected"
-					:indeterminate="someItemsSelected"
-					@change="toggleSelectAll"
-				/>
+				<v-checkbox :inputValue="allItemsSelected" :indeterminate="someItemsSelected" @change="toggleSelectAll" />
 			</th>
 
-			<th
-				v-for="header in headers"
-				:key="header.value"
-				:class="getClassesForHeader(header)"
-				class="cell"
-				scope="col"
-			>
+			<th v-for="header in headers" :key="header.value" :class="getClassesForHeader(header)" class="cell" scope="col">
 				<div class="content" @click="changeSort(header)">
 					<span v-show="header.width > 90 || header.width === null">
 						<slot :name="`header.${header.value}`" :header="header">
 							{{ header.text }}
 						</slot>
 					</span>
-					<v-icon v-if="header.sortable" name="sort" class="sort-icon" small v-tooltip.top="$t(getTooltipForSortIcon(header))"/>
+					<v-icon
+						v-if="header.sortable"
+						name="sort"
+						class="sort-icon"
+						small
+						v-tooltip.top="$t(getTooltipForSortIcon(header))"
+					/>
 				</div>
 				<span
 					class="resize-handle"
@@ -147,7 +143,7 @@ export default defineComponent({
 		}
 
 		function getTooltipForSortIcon(header: Header) {
-			return props.sort.by === header.value && props.sort.desc === false ? 'sort_direction.desc' : 'sort_direction.asc';
+			return props.sort.by === header.value && props.sort.desc === false ? 'sort_desc' : 'sort_asc';
 		}
 
 		function changeSort(header: Header) {
diff --git a/app/src/lang/translations/en-US.yaml b/app/src/lang/translations/en-US.yaml
index 5b28365678..59ffd57a42 100644
--- a/app/src/lang/translations/en-US.yaml
+++ b/app/src/lang/translations/en-US.yaml
@@ -770,9 +770,8 @@ sign_out: Sign Out
 sign_out_confirm: Are you sure you want to sign out?
 something_went_wrong: Something went wrong.
 sort_direction: Sort Direction
-sort_direction:
-  asc: Sort Ascending
-  desc: Sort Descending
+sort_asc: Sort Ascending
+sort_desc: Sort Descending
 template: Template
 translation: Translation
 value: Value