github/directus
1
1
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-04-25 03:00:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

App: encode primary key (#5143)

Browse Source 
* app: encode primary key
Since primary keys could be manually entered strings,
we should encode those in order to prevent accessing
inexistent routes.
E.g.
Document with primary key: 'clients/John Doe'

* fixup! app: encode primary key Since primary keys could be manually entered strings, we should encode those in order to prevent accessing inexistent routes. E.g. Document with primary key: 'clients/John Doe'

Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
This commit is contained in:
José Varela
2021-04-19 16:35:01 +01:00
committed by GitHub
parent 7fbba272ad
commit acc145006c
10 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/composables/use-item/use-item.ts
View File

@@ -43,7 +43,7 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
return endpoint.value;
}
return `${endpoint.value}/${primaryKey.value}`;
return `${endpoint.value}/${encodeURIComponent(primaryKey.value as string)}`;
});
watch([collection, primaryKey], refresh, { immediate: true });

2
app/src/composables/use-template-data.ts
View File

@@ -25,7 +25,7 @@ export default function useTemplateData(collection: ComputedRef<Collection | und
const endpoint = collection.value.collection.startsWith('directus_')
? `/${collection.value.collection.substring(9)}/${primaryKey.value}`
: `/items/${collection.value.collection}/${primaryKey.value}`;
: `/items/${collection.value.collection}/${encodeURIComponent(primaryKey.value)}`;
try {
const result = await api.get(endpoint, {