Syntax fixes (#5367)

* Declare return types on functions

And a very few other type related minor fixes

* Minor syntax fixes

* Remove unnecessary escape chars in regexes
* Remove unnecessary awaits
* Replace deprecated req.connection with req.socket
* Replace deprecated upload with uploadOne
* Remove unnecessary eslint-disable-next-line comments
* Comment empty functions / catch or finally clauses
* Fix irregular whitespaces
* Add missing returns (null)
* Remove unreachable code
* A few logical fixes
* Remove / Handle non-null assertions which are certainly unnecessary (e.g. in
tests)

app/src/modules/users/composables/use-navigation.ts

@@ -6,7 +6,7 @@ import { Role } from '@/types';
 let roles: Ref<Role[] | null> | null = null;
 let loading: Ref<boolean> | null = null;
 
-export default function useNavigation() {
+export default function useNavigation(): Record<string, Ref> {
 	if (roles === null) {
 		roles = ref<Role[] | null>(null);
 	}

app/src/modules/users/routes/collection.vue

@@ -151,6 +151,7 @@ import { useUserStore, usePermissionsStore } from '@/stores';
 import marked from 'marked';
 import useNavigation from '../composables/use-navigation';
 import DrawerBatch from '@/views/private/components/drawer-batch';
+import { Role } from '@/types';
 
 type Item = {
 	[field: string]: any;
@@ -303,7 +304,7 @@ export default defineComponent({
 
 			const title = computed(() => {
 				if (!props.queryFilters?.role) return i18n.t('user_directory');
-				return roles.value?.find((role) => role.id === props.queryFilters.role)?.name;
+				return roles.value?.find((role: Role) => role.id === props.queryFilters.role)?.name;
 			});
 
 			return { breadcrumb, title };