From adb786ed910e450f7d458197de0a9882b2e3d35b Mon Sep 17 00:00:00 2001
From: rijkvanzanten <rijkvanzanten@me.com>
Date: Mon, 21 Sep 2020 12:27:36 -0400
Subject: [PATCH] Only show notification text on errors

Fixes #377
---
 app/src/composables/use-item/use-item.ts | 40 ++++++------------------
 app/src/stores/collections.ts            |  2 --
 app/src/stores/settings.ts               |  1 -
 3 files changed, 10 insertions(+), 33 deletions(-)

diff --git a/app/src/composables/use-item/use-item.ts b/app/src/composables/use-item/use-item.ts
index 00b26a94c6..a9423b2ee6 100644
--- a/app/src/composables/use-item/use-item.ts
+++ b/app/src/composables/use-item/use-item.ts
@@ -93,12 +93,6 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 
 				notify({
 					title: i18n.tc('item_create_success', isBatch.value ? 2 : 1),
-					text: i18n.tc('item_in', isBatch.value ? 2 : 1, {
-						collection: collection.value,
-						primaryKey: isBatch.value
-							? (primaryKey.value as string).split(',').join(', ')
-							: primaryKey.value,
-					}),
 					type: 'success',
 				});
 			} else {
@@ -106,12 +100,6 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 
 				notify({
 					title: i18n.tc('item_update_success', isBatch.value ? 2 : 1),
-					text: i18n.tc('item_in', isBatch.value ? 2 : 1, {
-						collection: collection.value,
-						primaryKey: isBatch.value
-							? (primaryKey.value as string).split(',').join(', ')
-							: primaryKey.value,
-					}),
 					type: 'success',
 				});
 			}
@@ -145,9 +133,11 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 			}
 
 			if (err?.response?.data?.errors) {
-				validationErrors.value = err.response.data.errors.filter((err: APIError) => err.extensions.code === 'FAILED_VALIDATION').map((err: APIError) => {
-					return err.extensions;
-				});
+				validationErrors.value = err.response.data.errors
+					.filter((err: APIError) => err.extensions.code === 'FAILED_VALIDATION')
+					.map((err: APIError) => {
+						return err.extensions;
+					});
 			} else {
 				throw err;
 			}
@@ -175,10 +165,6 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 
 			notify({
 				title: i18n.t('item_create_success'),
-				text: i18n.tc('item_in', isBatch.value ? 2 : 1, {
-					collection: collection.value,
-					primaryKey: isBatch.value ? (primaryKey.value as string).split(',').join(', ') : primaryKey.value,
-				}),
 				type: 'success',
 			});
 
@@ -194,9 +180,11 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 			});
 
 			if (err?.response?.data?.errors) {
-				validationErrors.value = err.response.data.errors.filter((err: APIError) => err.extensions.code === 'FAILED_VALIDATION').map((err: APIError) => {
-					return err.extensions;
-				});
+				validationErrors.value = err.response.data.errors
+					.filter((err: APIError) => err.extensions.code === 'FAILED_VALIDATION')
+					.map((err: APIError) => {
+						return err.extensions;
+					});
 			} else {
 				throw err;
 			}
@@ -237,10 +225,6 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 
 			notify({
 				title: i18n.tc('item_delete_success', isBatch.value ? 2 : 1),
-				text: i18n.tc('item_in', isBatch.value ? 2 : 1, {
-					collection: collection.value,
-					primaryKey: isBatch.value ? (primaryKey.value as string).split(',').join(', ') : primaryKey.value,
-				}),
 				type: 'success',
 			});
 		} catch (err) {
@@ -269,10 +253,6 @@ export function useItem(collection: Ref<string>, primaryKey: Ref<string | number
 
 			notify({
 				title: i18n.tc('item_delete_success', isBatch.value ? 2 : 1),
-				text: i18n.tc('item_in', isBatch.value ? 2 : 1, {
-					collection: collection.value,
-					primaryKey: isBatch.value ? (primaryKey.value as string).split(',').join(', ') : primaryKey.value,
-				}),
 				type: 'success',
 			});
 		} catch (err) {
diff --git a/app/src/stores/collections.ts b/app/src/stores/collections.ts
index 770ca0b571..523e88ab1a 100644
--- a/app/src/stores/collections.ts
+++ b/app/src/stores/collections.ts
@@ -62,7 +62,6 @@ export const useCollectionsStore = createStore({
 				notify({
 					type: 'success',
 					title: i18n.t('update_collection_success'),
-					text: collection,
 				});
 			} catch (error) {
 				notify({
@@ -80,7 +79,6 @@ export const useCollectionsStore = createStore({
 				notify({
 					type: 'success',
 					title: i18n.t('delete_collection_success'),
-					text: collection,
 				});
 			} catch (error) {
 				notify({
diff --git a/app/src/stores/settings.ts b/app/src/stores/settings.ts
index b085496edf..b6b81020d7 100644
--- a/app/src/stores/settings.ts
+++ b/app/src/stores/settings.ts
@@ -34,7 +34,6 @@ export const useSettingsStore = createStore({
 
 				notify({
 					title: i18n.t('settings_update_success'),
-					text: Object.keys(updates).join(', '),
 					type: 'success',
 				});
 			} catch (error) {