github/directus
1
1
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-04-25 03:00:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Return 200 OK on create/update with no read permissions

Browse Source 
Fixes #33
This commit is contained in:
rijkvanzanten
2020-09-21 16:29:07 -04:00
parent d9bfd6148f
commit bb7b76aef9
14 changed files with 332 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
api/src/controllers/fields.ts
View File

@@ -82,9 +82,17 @@ router.post(
await service.createField(req.params.collection, field);
const createdField = await service.readOne(req.params.collection, field.field);
try {
const createdField = await service.readOne(req.params.collection, field.field);
res.locals.payload = { data: createdField || null };
} catch (error) {
if (error instanceof ForbiddenException) {
return next();
}
throw error;
}
res.locals.payload = { data: createdField || null };
return next();
})
);
@@ -95,20 +103,29 @@ router.patch(
asyncHandler(async (req, res, next) => {
const service = new FieldsService({ accountability: req.accountability });
if (Array.isArray(req.body) === false)
if (Array.isArray(req.body) === false) {
throw new InvalidPayloadException('Submitted body has to be an array.');
let results: any = [];
}
for (const field of req.body) {
await service.updateField(req.params.collection, field);
const updatedField = await service.readOne(req.params.collection, field.field);
results.push(updatedField);
}
res.locals.payload = { data: results || null };
try {
let results: any = [];
for (const field of req.body) {
const updatedField = await service.readOne(req.params.collection, field.field);
results.push(updatedField);
res.locals.payload = { data: results || null };
}
} catch (error) {
if (error instanceof ForbiddenException) {
return next();
}
throw error;
}
return next();
})
);
@@ -125,9 +142,17 @@ router.patch(
await service.updateField(req.params.collection, fieldData);
const updatedField = await service.readOne(req.params.collection, req.params.field);
try {
const updatedField = await service.readOne(req.params.collection, req.params.field);
res.locals.payload = { data: updatedField || null };
} catch (error) {
if (error instanceof ForbiddenException) {
return next();
}
throw error;
}
res.locals.payload = { data: updatedField || null };
return next();
})
);