From bd551ea9e4798cbee96084829a397ed03dd1a244 Mon Sep 17 00:00:00 2001 From: Aiden Foxx Date: Tue, 23 Nov 2021 15:37:55 +0100 Subject: [PATCH] Fix LDAP race condition (#9993) --- api/src/auth/drivers/ldap.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/src/auth/drivers/ldap.ts b/api/src/auth/drivers/ldap.ts index 0fd6969ebc..85f419f65d 100644 --- a/api/src/auth/drivers/ldap.ts +++ b/api/src/auth/drivers/ldap.ts @@ -295,12 +295,12 @@ export class LDAPAuthDriver extends AuthDriver { }); client.bind(user.external_identifier!, password, (err: Error | null) => { - client.destroy(); if (err) { reject(handleError(err)); - return; + } else { + resolve(); } - resolve(); + client.destroy(); }); }); }