From c429ecd57c33b08c3c36bec1efe20b152dcaadc8 Mon Sep 17 00:00:00 2001 From: Roger Stringer Date: Fri, 6 Jan 2023 07:17:04 -0800 Subject: [PATCH] healthcheck crashes with local file storage (#16944) * Update api/src/services/server.ts * remove try catch in write * Update api/src/services/server.ts Co-authored-by: Freekrai Co-authored-by: Pascal Jufer Co-authored-by: Brainslug --- api/src/services/server.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/api/src/services/server.ts b/api/src/services/server.ts index 3f64521d86..99a5cd5182 100644 --- a/api/src/services/server.ts +++ b/api/src/services/server.ts @@ -308,8 +308,11 @@ export class ServerService { try { await disk.write(`health-${checkID}`, Readable.from(['check'])); - await disk.read(`health-${checkID}`); - await disk.delete(`health-${checkID}`); + const fileStream = await disk.read(`health-${checkID}`); + fileStream.on('data', async () => { + fileStream.destroy(); + await disk.delete(`health-${checkID}`); + }); } catch (err: any) { checks[`storage:${location}:responseTime`][0].status = 'error'; checks[`storage:${location}:responseTime`][0].output = err;