From c87eb8141fac804fe6cebea1d39cf602c225111e Mon Sep 17 00:00:00 2001
From: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Date: Fri, 8 Jul 2022 20:38:08 +0800
Subject: [PATCH] Prevent empty title attribute in WYSIWYG links (#14322)

---
 app/src/interfaces/input-rich-text-html/useLink.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/src/interfaces/input-rich-text-html/useLink.ts b/app/src/interfaces/input-rich-text-html/useLink.ts
index 08a5cda254..f0a88b604f 100644
--- a/app/src/interfaces/input-rich-text-html/useLink.ts
+++ b/app/src/interfaces/input-rich-text-html/useLink.ts
@@ -110,9 +110,9 @@ export default function useLink(editor: Ref<any>): UsableLink {
 
 		const link = linkSelection.value;
 		if (link.url === null) return;
-		const linkHtml = `<a href="${link.url}" title="${link.title || ''}" target="${link.newTab ? '_blank' : '_self'}" >${
-			link.displayText || link.url
-		}</a>`;
+		const linkHtml = `<a href="${link.url}" ${link.title ? `title="${link.title}"` : ''} target="${
+			link.newTab ? '_blank' : '_self'
+		}" >${link.displayText || link.url}</a>`;
 
 		// New anchor tag or current selection node is an anchor tag
 		if (!linkNode.value || currentSelectionNode.value === linkNode.value) {
@@ -123,7 +123,7 @@ export default function useLink(editor: Ref<any>): UsableLink {
 			currentSelectionNode.value.innerHTML = link.displayText || link.url;
 			linkNode.value.setAttribute('data-mce-href', link.url); // Required for tinymce to update changes
 			linkNode.value.setAttribute('href', link.url);
-			linkNode.value.setAttribute('title', link.title || '');
+			if (link.title) linkNode.value.setAttribute('title', link.title);
 			linkNode.value.setAttribute('target', link.newTab ? '_blank' : '_self');
 			editor.value.selection.select(linkNode.value);
 			editor.value.selection.setNode(linkNode.value);