From 56be2c0f9e5f458a21509313c8e08793730918b4 Mon Sep 17 00:00:00 2001
From: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Date: Tue, 26 Jan 2021 13:03:29 +0100
Subject: [PATCH 1/3] Fix formatting

---
 app/src/components/v-upload/v-upload.vue      |  4 +-
 .../components/relationship-m2m.vue           |  5 +-
 .../components/relationship-o2m.vue           | 51 +++++--------------
 3 files changed, 16 insertions(+), 44 deletions(-)

diff --git a/app/src/components/v-upload/v-upload.vue b/app/src/components/v-upload/v-upload.vue
index d995530a38..cd5e01ef23 100644
--- a/app/src/components/v-upload/v-upload.vue
+++ b/app/src/components/v-upload/v-upload.vue
@@ -161,9 +161,7 @@ export default defineComponent({
 					if (props.multiple === true) {
 						const uploadedFiles = await uploadFiles(Array.from(files), {
 							onProgressChange: (percentage) => {
-								progress.value = Math.round(
-									percentage.reduce((acc, cur) => (acc += cur)) / files.length
-								);
+								progress.value = Math.round(percentage.reduce((acc, cur) => (acc += cur)) / files.length);
 								done.value = percentage.filter((p) => p === 100).length;
 							},
 							preset: props.preset,
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue
index fd734b9fd2..f15bf50623 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue
@@ -332,10 +332,7 @@ export default defineComponent({
 					return !!state.newFields.find((field: any) => field.$type === 'corresponding');
 				},
 				set(enabled: boolean) {
-					if (
-						enabled === true &&
-						!!state.newFields.find((field: any) => field.$type === 'corresponding') === false
-					) {
+					if (enabled === true && !!state.newFields.find((field: any) => field.$type === 'corresponding') === false) {
 						state.newFields = [
 							...state.newFields,
 							{
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue
index 16d4c78031..8c886b9da0 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue
@@ -19,12 +19,7 @@
 					<template #append>
 						<v-menu show-arrow placement="bottom-end">
 							<template #activator="{ toggle }">
-								<v-icon
-									name="list_alt"
-									@click="toggle"
-									v-tooltip="$t('select_existing')"
-									:disabled="isExisting"
-								/>
+								<v-icon name="list_alt" @click="toggle" v-tooltip="$t('select_existing')" :disabled="isExisting" />
 							</template>
 
 							<v-list class="monospace">
@@ -97,12 +92,7 @@
 		<div class="corresponding" v-if="!isExisting">
 			<div class="field">
 				<div class="type-label">{{ $t('create_field') }}</div>
-				<v-checkbox
-					block
-					:disabled="isExisting"
-					:label="correspondingLabel"
-					v-model="hasCorresponding"
-				/>
+				<v-checkbox block :disabled="isExisting" :label="correspondingLabel" v-model="hasCorresponding" />
 			</div>
 			<div class="field">
 				<div class="type-label">{{ $t('field_name') }}</div>
@@ -152,9 +142,7 @@ export default defineComponent({
 		const { hasCorresponding, correspondingLabel } = useCorresponding();
 
 		const relatedCollectionExists = computed(() => {
-			return collectionsStore.state.collections.find(
-				(col) => col.collection === state.relations?.[0].many_collection
-			);
+			return collectionsStore.state.collections.find((col) => col.collection === state.relations?.[0].many_collection);
 		});
 
 		const relatedFieldExists = computed(() => {
@@ -180,8 +168,7 @@ export default defineComponent({
 				return orderBy(
 					collectionsStore.state.collections.filter((collection) => {
 						return (
-							collection.collection.startsWith('directus_') === false &&
-							collection.collection !== props.collection
+							collection.collection.startsWith('directus_') === false && collection.collection !== props.collection
 						);
 					}),
 					['collection'],
@@ -192,19 +179,14 @@ export default defineComponent({
 			const systemCollections = computed(() => {
 				return orderBy(
 					collectionsStore.state.collections.filter((collection) => {
-						return (
-							collection.collection.startsWith('directus_') === true &&
-							collection.collection !== props.collection
-						);
+						return collection.collection.startsWith('directus_') === true && collection.collection !== props.collection;
 					}),
 					['collection'],
 					['asc']
 				);
 			});
 
-			const currentCollectionPrimaryKey = computed(() =>
-				fieldsStore.getPrimaryKeyFieldForCollection(props.collection)
-			);
+			const currentCollectionPrimaryKey = computed(() => fieldsStore.getPrimaryKeyFieldForCollection(props.collection));
 
 			const fields = computed(() => {
 				if (!state.relations[0].many_collection) return [];
@@ -215,9 +197,7 @@ export default defineComponent({
 						text: field.field,
 						value: field.field,
 						disabled:
-							!field.schema ||
-							field.schema?.is_primary_key ||
-							field.type !== currentCollectionPrimaryKey.value.type,
+							!field.schema || field.schema?.is_primary_key || field.type !== currentCollectionPrimaryKey.value.type,
 					}));
 			});
 
@@ -241,16 +221,15 @@ export default defineComponent({
 
 					if (relatedFieldExists.value === true) {
 						return (
-							state.updateFields.find(
-								(updateField: any) => updateField.field === state.relations[0].many_field
-							)?.meta?.interface === 'many-to-one' ||
-							fieldsStore.getField(state.relations[0].many_collection, state.relations[0].many_field)
-								?.meta?.interface === 'many-to-one'
+							state.updateFields.find((updateField: any) => updateField.field === state.relations[0].many_field)?.meta
+								?.interface === 'many-to-one' ||
+							fieldsStore.getField(state.relations[0].many_collection, state.relations[0].many_field)?.meta
+								?.interface === 'many-to-one'
 						);
 					} else {
 						return (
-							state.newFields.find((newField: any) => newField.$type === 'manyRelated')?.meta
-								?.interface === 'many-to-one'
+							state.newFields.find((newField: any) => newField.$type === 'manyRelated')?.meta?.interface ===
+							'many-to-one'
 						);
 					}
 				},
@@ -282,9 +261,7 @@ export default defineComponent({
 							];
 						}
 					} else {
-						const newFieldCreated = !!state.newFields.find(
-							(newField: any) => newField.$type === 'manyRelated'
-						);
+						const newFieldCreated = !!state.newFields.find((newField: any) => newField.$type === 'manyRelated');
 
 						if (newFieldCreated === false) {
 							state.newFields = [

From 8f8b33de097e1c095c893697b6687a6c29586598 Mon Sep 17 00:00:00 2001
From: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Date: Tue, 26 Jan 2021 13:08:29 +0100
Subject: [PATCH 2/3] Fix v-input usages requiring nullable to be false

---
 app/src/components/v-upload/v-upload.vue               |  2 +-
 app/src/interfaces/_system/tfa-setup/tfa-setup.vue     |  4 ++--
 app/src/interfaces/file/file.vue                       |  2 +-
 .../field-detail/components/relationship-m2a.vue       |  4 ++++
 .../field-detail/components/relationship-m2m.vue       |  5 +++++
 .../field-detail/components/relationship-m2o.vue       |  2 ++
 .../field-detail/components/relationship-o2m.vue       |  2 ++
 .../data-model/field-detail/components/schema.vue      |  1 +
 .../field-detail/components/translations.vue           |  5 +++++
 .../components/filter-sidebar-detail/filter-input.vue  | 10 +++++++++-
 10 files changed, 32 insertions(+), 5 deletions(-)

diff --git a/app/src/components/v-upload/v-upload.vue b/app/src/components/v-upload/v-upload.vue
index cd5e01ef23..5a2f6465c2 100644
--- a/app/src/components/v-upload/v-upload.vue
+++ b/app/src/components/v-upload/v-upload.vue
@@ -68,7 +68,7 @@
 					<v-card>
 						<v-card-title>{{ $t('import_from_url') }}</v-card-title>
 						<v-card-text>
-							<v-input :placeholder="$t('url')" v-model="url" :disabled="urlLoading" />
+							<v-input :placeholder="$t('url')" v-model="url" :nullable="false" :disabled="urlLoading" />
 						</v-card-text>
 						<v-card-actions>
 							<v-button :disabled="urlLoading" @click="activeDialog = null" secondary>
diff --git a/app/src/interfaces/_system/tfa-setup/tfa-setup.vue b/app/src/interfaces/_system/tfa-setup/tfa-setup.vue
index 4117470611..af3f74179d 100644
--- a/app/src/interfaces/_system/tfa-setup/tfa-setup.vue
+++ b/app/src/interfaces/_system/tfa-setup/tfa-setup.vue
@@ -15,7 +15,7 @@
 						{{ $t('enter_password_to_enable_tfa') }}
 					</v-card-title>
 					<v-card-text>
-						<v-input v-model="password" type="password" :placeholder="$t('password')" />
+						<v-input v-model="password" :nullable="false" type="password" :placeholder="$t('password')" />
 
 						<v-error v-if="error" :error="error" />
 					</v-card-text>
@@ -48,7 +48,7 @@
 					{{ $t('enter_otp_to_disable_tfa') }}
 				</v-card-title>
 				<v-card-text>
-					<v-input type="text" :placeholder="$t('otp')" v-model="otp" />
+					<v-input type="text" :placeholder="$t('otp')" v-model="otp" :nullable="false" />
 				</v-card-text>
 				<v-card-actions>
 					<v-button class="disable" :loading="loading" @click="disableTFA" :disabled="otp.length !== 6">
diff --git a/app/src/interfaces/file/file.vue b/app/src/interfaces/file/file.vue
index 796f7601d0..5654f3a8e9 100644
--- a/app/src/interfaces/file/file.vue
+++ b/app/src/interfaces/file/file.vue
@@ -107,7 +107,7 @@
 			<v-card>
 				<v-card-title>{{ $t('import_from_url') }}</v-card-title>
 				<v-card-text>
-					<v-input :placeholder="$t('url')" v-model="url" :disabled="urlLoading" />
+					<v-input :placeholder="$t('url')" v-model="url" :nullable="false" :disabled="urlLoading" />
 				</v-card-text>
 				<v-card-actions>
 					<v-button :disabled="urlLoading" @click="activeDialog = null" secondary>
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2a.vue b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2a.vue
index 2be8caced8..e41e1ecf39 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2a.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2a.vue
@@ -12,6 +12,7 @@
 				<v-input
 					:class="{ matches: junctionCollectionExists }"
 					v-model="junctionCollection"
+					:nullable="false"
 					:placeholder="$t('collection') + '...'"
 					:disabled="autoFill || isExisting"
 					db-safe
@@ -77,6 +78,7 @@
 			<v-input
 				:class="{ matches: junctionFieldExists(relations[0].many_field) }"
 				v-model="relations[0].many_field"
+				:nullable="false"
 				:placeholder="$t('foreign_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
@@ -114,6 +116,7 @@
 				class="one-collection-field"
 				:class="{ matches: junctionFieldExists(relations[0].one_collection_field) }"
 				v-model="relations[1].one_collection_field"
+				:nullable="false"
 				:placeholder="$t('collection_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
@@ -149,6 +152,7 @@
 			<v-input
 				:class="{ matches: junctionFieldExists(relations[1].many_field) }"
 				v-model="relations[1].many_field"
+				:nullable="false"
 				:placeholder="$t('foreign_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue
index f15bf50623..f047dbafc4 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2m.vue
@@ -12,6 +12,7 @@
 				<v-input
 					:class="{ matches: junctionCollectionExists }"
 					v-model="junctionCollection"
+					:nullable="false"
 					:placeholder="$t('collection') + '...'"
 					:disabled="autoFill || isExisting"
 					db-safe
@@ -65,6 +66,7 @@
 					:autofocus="autoFill"
 					:class="{ matches: relatedCollectionExists }"
 					v-model="relations[1].one_collection"
+					:nullable="false"
 					:placeholder="$t('collection') + '...'"
 					:disabled="type === 'files' || isExisting"
 					db-safe
@@ -116,6 +118,7 @@
 			<v-input
 				:class="{ matches: junctionFieldExists(relations[0].many_field) }"
 				v-model="relations[0].many_field"
+				:nullable="false"
 				:placeholder="$t('foreign_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
@@ -152,6 +155,7 @@
 			<v-input
 				:class="{ matches: junctionFieldExists(relations[1].many_field) }"
 				v-model="relations[1].many_field"
+				:nullable="false"
 				:placeholder="$t('foreign_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
@@ -187,6 +191,7 @@
 				db-safe
 				:disabled="relatedCollectionExists"
 				v-model="relations[1].one_primary"
+				:nullable="false"
 				:placeholder="$t('primary_key') + '...'"
 			/>
 			<div class="spacer" />
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2o.vue b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2o.vue
index 05b5c1439c..89ea5295d2 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2o.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-m2o.vue
@@ -14,6 +14,7 @@
 					db-safe
 					key="related-collection"
 					v-model="relations[0].one_collection"
+					:nullable="false"
 					:disabled="isExisting"
 					:placeholder="$t('collection') + '...'"
 				>
@@ -60,6 +61,7 @@
 				db-safe
 				:disabled="relatedCollectionExists"
 				v-model="relations[0].one_primary"
+				:nullable="false"
 				:placeholder="$t('primary_key') + '...'"
 			/>
 			<v-icon class="arrow" name="arrow_back" />
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue
index 8c886b9da0..bf6259c9c1 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/relationship-o2m.vue
@@ -13,6 +13,7 @@
 					db-safe
 					:placeholder="$t('collection') + '...'"
 					v-model="relations[0].many_collection"
+					:nullable="false"
 					:disabled="isExisting"
 					:class="{ matches: relatedCollectionExists }"
 				>
@@ -58,6 +59,7 @@
 			<v-input
 				db-safe
 				v-model="relations[0].many_field"
+				:nullable="false"
 				:disabled="isExisting"
 				:placeholder="$t('foreign_key') + '...'"
 				:class="{ matches: relatedFieldExists }"
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/schema.vue b/app/src/modules/settings/routes/data-model/field-detail/components/schema.vue
index 5962c07600..2bb425a2bb 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/schema.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/schema.vue
@@ -15,6 +15,7 @@
 					autofocus
 					class="monospace"
 					v-model="fieldData.field"
+					:nullable="false"
 					db-safe
 					:placeholder="$t('a_unique_column_name')"
 				/>
diff --git a/app/src/modules/settings/routes/data-model/field-detail/components/translations.vue b/app/src/modules/settings/routes/data-model/field-detail/components/translations.vue
index 4b5535c4f7..2257357312 100644
--- a/app/src/modules/settings/routes/data-model/field-detail/components/translations.vue
+++ b/app/src/modules/settings/routes/data-model/field-detail/components/translations.vue
@@ -12,6 +12,7 @@
 				<v-input
 					:class="{ matches: junctionCollectionExists }"
 					v-model="junctionCollection"
+					:nullable="false"
 					:placeholder="$t('collection') + '...'"
 					:disabled="autoFill || isExisting"
 					db-safe
@@ -65,6 +66,7 @@
 					:autofocus="autoFill"
 					:class="{ matches: relatedCollectionExists }"
 					v-model="relations[1].one_collection"
+					:nullable="false"
 					:placeholder="$t('collection') + '...'"
 					:disabled="type === 'files' || isExisting"
 					db-safe
@@ -116,6 +118,7 @@
 			<v-input
 				:class="{ matches: junctionFieldExists(relations[0].many_field) }"
 				v-model="relations[0].many_field"
+				:nullable="false"
 				:placeholder="$t('foreign_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
@@ -152,6 +155,7 @@
 			<v-input
 				:class="{ matches: junctionFieldExists(relations[1].many_field) }"
 				v-model="relations[1].many_field"
+				:nullable="false"
 				:placeholder="$t('foreign_key') + '...'"
 				:disabled="autoFill || isExisting"
 				db-safe
@@ -187,6 +191,7 @@
 				db-safe
 				:disabled="relatedCollectionExists"
 				v-model="relations[1].one_primary"
+				:nullable="false"
 				:placeholder="$t('primary_key') + '...'"
 			/>
 			<div class="spacer" />
diff --git a/app/src/views/private/components/filter-sidebar-detail/filter-input.vue b/app/src/views/private/components/filter-sidebar-detail/filter-input.vue
index bbf1a48f4f..f312be16b1 100644
--- a/app/src/views/private/components/filter-sidebar-detail/filter-input.vue
+++ b/app/src/views/private/components/filter-sidebar-detail/filter-input.vue
@@ -47,7 +47,15 @@
 		</template>
 		<template v-else-if="['empty', 'nempty'].includes(operator) === false">
 			<v-checkbox block :label="$t('active')" v-if="type === 'checkbox'" v-model="_value" :disabled="disabled" />
-			<v-input :disabled="disabled" v-else autofocus v-model="_value" :type="type" :placeholder="$t('enter_a_value')" />
+			<v-input
+				:disabled="disabled"
+				v-else
+				autofocus
+				v-model="_value"
+				:nullable="false"
+				:type="type"
+				:placeholder="$t('enter_a_value')"
+			/>
 		</template>
 	</div>
 </template>

From 4bfbc2ba9fca0109a68fd9a61f453347403cd9e2 Mon Sep 17 00:00:00 2001
From: Nicola Krumschmidt <nicola.krumschmidt@freenet.de>
Date: Tue, 26 Jan 2021 13:14:32 +0100
Subject: [PATCH 3/3] Prevent add/edit dialogs from saving if value is null

---
 .../modules/collections/components/navigation-bookmark.vue    | 4 +++-
 app/src/modules/files/components/add-folder.vue               | 2 +-
 app/src/modules/files/components/navigation-folder.vue        | 4 +++-
 .../routes/data-model/fields/components/field-select.vue      | 2 +-
 app/src/modules/settings/routes/roles/add-new.vue             | 4 ++--
 5 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/app/src/modules/collections/components/navigation-bookmark.vue b/app/src/modules/collections/components/navigation-bookmark.vue
index 4903d8616b..5ba163b02e 100644
--- a/app/src/modules/collections/components/navigation-bookmark.vue
+++ b/app/src/modules/collections/components/navigation-bookmark.vue
@@ -35,7 +35,9 @@
 				</v-card-text>
 				<v-card-actions>
 					<v-button secondary @click="renameActive = false">{{ $t('cancel') }}</v-button>
-					<v-button @click="renameSave" :loading="renameSaving">{{ $t('save') }}</v-button>
+					<v-button @click="renameSave" :disabled="renameValue === null" :loading="renameSaving">
+						{{ $t('save') }}
+					</v-button>
 				</v-card-actions>
 			</v-card>
 		</v-dialog>
diff --git a/app/src/modules/files/components/add-folder.vue b/app/src/modules/files/components/add-folder.vue
index f769ec89a0..5ea674f119 100644
--- a/app/src/modules/files/components/add-folder.vue
+++ b/app/src/modules/files/components/add-folder.vue
@@ -20,7 +20,7 @@
 			</v-card-text>
 			<v-card-actions>
 				<v-button secondary @click="dialogActive = false">{{ $t('cancel') }}</v-button>
-				<v-button :disabled="!newFolderName || newFolderName.length === 0" @click="addFolder" :loading="saving">
+				<v-button :disabled="newFolderName === null" @click="addFolder" :loading="saving">
 					{{ $t('save') }}
 				</v-button>
 			</v-card-actions>
diff --git a/app/src/modules/files/components/navigation-folder.vue b/app/src/modules/files/components/navigation-folder.vue
index 5517c5fffc..7b9e330261 100644
--- a/app/src/modules/files/components/navigation-folder.vue
+++ b/app/src/modules/files/components/navigation-folder.vue
@@ -74,7 +74,9 @@
 				</v-card-text>
 				<v-card-actions>
 					<v-button secondary @click="renameActive = false">{{ $t('cancel') }}</v-button>
-					<v-button @click="renameSave" :loading="renameSaving">{{ $t('save') }}</v-button>
+					<v-button @click="renameSave" :disabled="renameValue === null" :loading="renameSaving">
+						{{ $t('save') }}
+					</v-button>
 				</v-card-actions>
 			</v-card>
 		</v-dialog>
diff --git a/app/src/modules/settings/routes/data-model/fields/components/field-select.vue b/app/src/modules/settings/routes/data-model/fields/components/field-select.vue
index b08ecbf547..943aac3703 100644
--- a/app/src/modules/settings/routes/data-model/fields/components/field-select.vue
+++ b/app/src/modules/settings/routes/data-model/fields/components/field-select.vue
@@ -172,7 +172,7 @@
 					<v-button secondary @click="duplicateActive = false">
 						{{ $t('cancel') }}
 					</v-button>
-					<v-button @click="saveDuplicate" :loading="duplicating">
+					<v-button @click="saveDuplicate" :disabled="duplicateName === null" :loading="duplicating">
 						{{ $t('duplicate') }}
 					</v-button>
 				</v-card-actions>
diff --git a/app/src/modules/settings/routes/roles/add-new.vue b/app/src/modules/settings/routes/roles/add-new.vue
index 1f5edba175..8daf5f4a67 100644
--- a/app/src/modules/settings/routes/roles/add-new.vue
+++ b/app/src/modules/settings/routes/roles/add-new.vue
@@ -23,7 +23,7 @@
 			</v-card-text>
 			<v-card-actions>
 				<v-button to="/settings/roles" secondary>{{ $t('cancel') }}</v-button>
-				<v-button @click="save" :loading="saving">{{ $t('save') }}</v-button>
+				<v-button @click="save" :disabled="roleName === null" :loading="saving">{{ $t('save') }}</v-button>
 			</v-card-actions>
 		</v-card>
 	</v-dialog>
@@ -38,7 +38,7 @@ import { unexpectedError } from '@/utils/unexpected-error';
 
 export default defineComponent({
 	setup() {
-		const roleName = ref<string>();
+		const roleName = ref<string | null>(null);
 		const appAccess = ref(true);
 		const adminAccess = ref(false);