From f2efacdad164c5369a320e05806d7d9c29ce4b9b Mon Sep 17 00:00:00 2001
From: rijkvanzanten <rijkvanzanten@me.com>
Date: Thu, 17 Jun 2021 16:26:37 -0400
Subject: [PATCH] Fix cancel button on new modal dialog

---
 .../insights/components/dashboard-dialog.vue        | 13 +++++--------
 app/src/modules/insights/routes/overview.vue        |  7 ++++++-
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/app/src/modules/insights/components/dashboard-dialog.vue b/app/src/modules/insights/components/dashboard-dialog.vue
index 7b9745de4e..03db36740f 100644
--- a/app/src/modules/insights/components/dashboard-dialog.vue
+++ b/app/src/modules/insights/components/dashboard-dialog.vue
@@ -1,5 +1,5 @@
 <template>
-	<v-dialog :model-value="active" @update:modelValue="$emit('toggle', $event)" persistent @esc="cancel">
+	<v-dialog :model-value="modelValue" @update:modelValue="$emit('update:modelValue', $event)" persistent @esc="cancel">
 		<template #activator="slotBinding">
 			<slot name="activator" v-bind="slotBinding" />
 		</template>
@@ -39,12 +39,9 @@ import { useI18n } from 'vue-i18n';
 
 export default defineComponent({
 	name: 'DashboardDialog',
-	model: {
-		prop: 'active',
-		event: 'toggle',
-	},
+	emits: ['update:modelValue'],
 	props: {
-		active: {
+		modelValue: {
 			type: Boolean,
 			default: false,
 		},
@@ -69,7 +66,7 @@ export default defineComponent({
 		return { values, cancel, saving, save, t };
 
 		function cancel() {
-			emit('toggle', false);
+			emit('update:modelValue', false);
 		}
 
 		async function save() {
@@ -84,7 +81,7 @@ export default defineComponent({
 					await insightsStore.hydrate();
 					router.push(`/insights/${response.data.data.id}`);
 				}
-				emit('toggle', false);
+				emit('update:modelValue', false);
 			} catch (err) {
 				unexpectedError(err);
 			} finally {
diff --git a/app/src/modules/insights/routes/overview.vue b/app/src/modules/insights/routes/overview.vue
index bc2ad713a9..5b0c14d05b 100644
--- a/app/src/modules/insights/routes/overview.vue
+++ b/app/src/modules/insights/routes/overview.vue
@@ -86,7 +86,12 @@
 			</v-card>
 		</v-dialog>
 
-		<dashboard-dialog v-if="editDashboard" active @toggle="editDashboard = null" :dashboard="editDashboard" />
+		<dashboard-dialog
+			v-if="editDashboard"
+			:model-value="true"
+			@toggle="editDashboard = null"
+			:dashboard="editDashboard"
+		/>
 	</private-view>
 </template>