From f39e40dfd1c8b0dd92ddb14163d853ea5c7aa18b Mon Sep 17 00:00:00 2001
From: Pascal Jufer <pascal-jufer@bluewin.ch>
Date: Wed, 6 Dec 2023 18:47:00 +0100
Subject: [PATCH] Add missing translation strings, type & icon for theme
 extensions (#20644)

---
 .changeset/green-dolls-clean.md                             | 6 ++++++
 app/src/lang/translations/en-US.yaml                        | 2 ++
 .../modules/settings/routes/extensions/constants/icons.ts   | 5 +++--
 packages/extensions/package.json                            | 1 +
 .../extensions/src/shared/types/app-extension-config.ts     | 4 +++-
 pnpm-lock.yaml                                              | 3 +++
 6 files changed, 18 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/green-dolls-clean.md

diff --git a/.changeset/green-dolls-clean.md b/.changeset/green-dolls-clean.md
new file mode 100644
index 0000000000..aae637d494
--- /dev/null
+++ b/.changeset/green-dolls-clean.md
@@ -0,0 +1,6 @@
+---
+"@directus/app": patch
+"@directus/extensions": patch
+---
+
+Added missing translation strings, type & icon for theme extensions
diff --git a/app/src/lang/translations/en-US.yaml b/app/src/lang/translations/en-US.yaml
index 7b2e79f17a..058cf53f46 100644
--- a/app/src/lang/translations/en-US.yaml
+++ b/app/src/lang/translations/en-US.yaml
@@ -60,6 +60,7 @@ extension_display: Display
 extension_layout: Layout
 extension_module: Module
 extension_panel: Panel
+extension_theme: Theme
 extension_hook: Hook
 extension_endpoint: Endpoint
 extension_operation: Operation
@@ -69,6 +70,7 @@ extension_displays: Displays
 extension_layouts: Layouts
 extension_modules: Modules
 extension_panels: Panels
+extension_themes: Themes
 extension_hooks: Hooks
 extension_endpoints: Endpoints
 extension_operations: Operations
diff --git a/app/src/modules/settings/routes/extensions/constants/icons.ts b/app/src/modules/settings/routes/extensions/constants/icons.ts
index 0bd1d6f86f..27fb5bf8cb 100644
--- a/app/src/modules/settings/routes/extensions/constants/icons.ts
+++ b/app/src/modules/settings/routes/extensions/constants/icons.ts
@@ -1,11 +1,12 @@
-import { EXTENSION_TYPES } from '@directus/extensions';
+import type { ExtensionType } from '@directus/extensions';
 
-export const iconMap: Record<(typeof EXTENSION_TYPES)[number], string> = {
+export const iconMap: Record<ExtensionType, string> = {
 	interface: 'design_services',
 	display: 'label',
 	layout: 'dataset',
 	module: 'web',
 	panel: 'analytics',
+	theme: 'palette',
 	hook: 'webhook',
 	endpoint: 'api',
 	operation: 'flowsheet',
diff --git a/packages/extensions/package.json b/packages/extensions/package.json
index 997d969d7c..a29202f311 100644
--- a/packages/extensions/package.json
+++ b/packages/extensions/package.json
@@ -32,6 +32,7 @@
 	},
 	"dependencies": {
 		"@directus/constants": "workspace:*",
+		"@directus/themes": "workspace:*",
 		"@directus/types": "workspace:*",
 		"@directus/utils": "workspace:*",
 		"@types/express": "4.17.17",
diff --git a/packages/extensions/src/shared/types/app-extension-config.ts b/packages/extensions/src/shared/types/app-extension-config.ts
index 54918dacb7..9176c85efe 100644
--- a/packages/extensions/src/shared/types/app-extension-config.ts
+++ b/packages/extensions/src/shared/types/app-extension-config.ts
@@ -1,9 +1,10 @@
+import type { Theme } from '@directus/themes';
 import type { DisplayConfig } from './displays.js';
 import type { InterfaceConfig } from './interfaces.js';
 import type { LayoutConfig } from './layouts.js';
 import type { ModuleConfig } from './modules.js';
-import type { PanelConfig } from './panels.js';
 import type { OperationAppConfig } from './operations.js';
+import type { PanelConfig } from './panels.js';
 
 export type AppExtensionConfigs = {
 	interfaces: InterfaceConfig[];
@@ -11,5 +12,6 @@ export type AppExtensionConfigs = {
 	layouts: LayoutConfig[];
 	modules: ModuleConfig[];
 	panels: PanelConfig[];
+	themes: Theme[];
 	operations: OperationAppConfig[];
 };
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 3d18878c45..d137398f8e 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -1222,6 +1222,9 @@ importers:
       '@directus/constants':
         specifier: workspace:*
         version: link:../constants
+      '@directus/themes':
+        specifier: workspace:*
+        version: link:../themes
       '@directus/types':
         specifier: workspace:*
         version: link:../types