From fd93b850e079812978adfa27639938a326a57727 Mon Sep 17 00:00:00 2001 From: NilsBaumgartner1994 <33295329+NilsBaumgartner1994@users.noreply.github.com> Date: Wed, 1 Dec 2021 21:20:27 +0100 Subject: [PATCH] Update BaseStorage (#9985) * Update BaseStorage remove dublicate strings into variables * Apply suggestions from code review Co-authored-by: Rijk van Zanten * Use enum types in keys Co-authored-by: Rijk van Zanten --- packages/sdk/src/base/storage/base.ts | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/packages/sdk/src/base/storage/base.ts b/packages/sdk/src/base/storage/base.ts index e02ebc65d5..7360344041 100644 --- a/packages/sdk/src/base/storage/base.ts +++ b/packages/sdk/src/base/storage/base.ts @@ -4,23 +4,29 @@ export type StorageOptions = { prefix?: string; }; +enum Keys { + AuthToken = 'auth_token', + RefreshToken = 'auth_refresh_token', + Expires = 'auth_expires', +} + export abstract class BaseStorage extends IStorage { protected prefix: string; get auth_token(): string | null { - return this.get('auth_token'); + return this.get(Keys.AuthToken); } set auth_token(value: string | null) { if (value === null) { - this.delete('auth_token'); + this.delete(Keys.AuthToken); } else { - this.set('auth_token', value); + this.set(Keys.AuthToken, value); } } get auth_expires(): number | null { - const value = this.get('auth_expires'); + const value = this.get(Keys.Expires); if (value === null) { return null; } @@ -29,21 +35,21 @@ export abstract class BaseStorage extends IStorage { set auth_expires(value: number | null) { if (value === null) { - this.delete('auth_expires'); + this.delete(Keys.Expires); } else { - this.set('auth_expires', value!.toString()); + this.set(Keys.Expires, value!.toString()); } } get auth_refresh_token(): string | null { - return this.get('auth_refresh_token'); + return this.get(Keys.RefreshToken); } set auth_refresh_token(value: string | null) { if (value === null) { - this.delete('auth_refresh_token'); + this.delete(Keys.RefreshToken); } else { - this.set('auth_refresh_token', value); + this.set(Keys.RefreshToken, value); } }